Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up testsuite #213

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Nov 4, 2024

Clean up the testsuite by:

  1. Removing calls to internal entry-points in favour of public ones.
  2. Updating the use of fixtures to handle context initialization on a per-test basis. This includes a function level fixture to init, and then subsequently de-init when calling a method which requirts context initalization (usually via device.set_current()). It also includes a fixture to deinit after some tests which call set_current() as part of their logic.
  3. As an effect of moving to public entry-points, the tests become more relational. The use of examples as additional tests also increases relational test coverage'

closes #196

Copy link

copy-pr-bot bot commented Nov 4, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work ksimpson-work marked this pull request as ready for review November 4, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure only public entry points are used in tests
1 participant