Bloom filter optimizations (1/5): Less noisy benchmarks #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleeepyjack
added
type: improvement
PointKernel
approved these changes
Feb 12, 2025
| using BF_WORD = nvbench::uint32_t; | ||
|
|
||
| static constexpr auto BF_N = 400'000'000; | ||
| static constexpr auto BF_N = 1'000'000'000; |
Member
There was a problem hiding this comment.
copyright years to be updated otherwise looks good
mhaseeb123
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part 1/5 of the Bloom filter optimization project and must be merged in the correct order.
This PR introduces two changes that reduce the noise level of the benchmark measurements drastically: