Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Consolidate logic for compiler detection #572

Closed
1 task done
miscco opened this issue Oct 17, 2023 · 2 comments · Fixed by #1320
Closed
1 task done

[FEA]: Consolidate logic for compiler detection #572

miscco opened this issue Oct 17, 2023 · 2 comments · Fixed by #1320
Assignees
Labels
cub For all items related to CUB feature request New feature or request. good first issue Good for newcomers. help wanted Request for input or help from the community libcu++ For all items related to libcu++ thrust For all items related to Thrust.

Comments

@miscco
Copy link
Contributor

miscco commented Oct 17, 2023

Is this a duplicate?

Area

General CCCL

Is your feature request related to a problem? Please describe.

With cub, thrust and libcu++ being three different libraries we have a ton of duplicated code.

We want to incrementally move that code into common headers, so that we do not need to repeat it and also only have one pace to fix if changes need to be made

One glaring occurrence of that duplication is the way we determine which host / device compiler is used.

With the #531 we are getting a unified config that we can use in all libraries and also convenient definitions for
_CCCL_COMPILER_{GCC, CLANG, MSVC, NVHPC, NVRTC}

Describe the solution you'd like

We should clean up all existing uses of
_LIBCUDACXX_COMPILER_{GCC, CLANG, MSVC, NVHPC, NVRTC}
THRUST_HOST_COMPILER_{GCC, CLANG, MSVC, INTEL}
CUB_HOST_COMPILER_{GCC, CLANG, MSVC, INTEL}

Describe alternatives you've considered

No response

Additional context

No response

@miscco miscco added feature request New feature or request. good first issue Good for newcomers. thrust For all items related to Thrust. cub For all items related to CUB libcu++ For all items related to libcu++ help wanted Request for input or help from the community labels Oct 17, 2023
@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 17, 2023
@Yaraslaut
Copy link
Contributor

Hi, I would like to work on this issue, could you please assign it to me?

@miscco
Copy link
Contributor Author

miscco commented Jan 24, 2024

Thanks a lot. I assigned you

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Progress in CCCL Jan 24, 2024
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Jan 25, 2024
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Review to In Progress in CCCL Feb 1, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in CCCL Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cub For all items related to CUB feature request New feature or request. good first issue Good for newcomers. help wanted Request for input or help from the community libcu++ For all items related to libcu++ thrust For all items related to Thrust.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants