Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Improve error reporting for segmented reduce #1221

Closed
1 task done
gevtushenko opened this issue Dec 15, 2023 · 0 comments · Fixed by #1430
Closed
1 task done

[BUG]: Improve error reporting for segmented reduce #1221

gevtushenko opened this issue Dec 15, 2023 · 0 comments · Fixed by #1430
Assignees
Labels
bug Something isn't working right.

Comments

@gevtushenko
Copy link
Collaborator

Is this a duplicate?

Type of Bug

Compile-time Error

Component

CUB

Describe the bug

As of #414 we use common value type of offset begin / end iterators as offset type in segmented reduce. Incorrect use of API is hard to diagnose. For instance, user can pass offset iterator with float as its value type. Float is not expected on the implementation side of segmented reduce, leading to many errors that are hard to associate with API misuse.

How to Reproduce

#include <cub/cub.cuh>

int main() {
  using offset_t = float;  // error
  // using offset_t = int; // ok
  float *d_in{}, *d_out{};
  offset_t *d_begin_offsets{}, *d_end_offsets{};
  std::size_t temp_storage_bytes{};
  std::uint8_t *d_temp_storage{};
  cub::DeviceSegmentedReduce::Sum(d_temp_storage, temp_storage_bytes, d_in, d_out, 0, d_begin_offsets, d_end_offsets);
}

Expected behavior

We should use combination of SFINAE and static asserts like we do in device radix sort to improve error reporting.

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

No response

@gevtushenko gevtushenko added the bug Something isn't working right. label Dec 15, 2023
@github-project-automation github-project-automation bot moved this to Todo in CCCL Dec 15, 2023
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Progress in CCCL Feb 28, 2024
@jrhemstad jrhemstad moved this from In Progress to In Review in CCCL Feb 28, 2024
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Review to In Progress in CCCL Mar 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in CCCL Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants