Skip to content

Conversation

@yuanjingx87
Copy link
Collaborator

@yuanjingx87 yuanjingx87 commented Oct 15, 2025

Summary by CodeRabbit

  • Chores
    • Updated internal CI configuration formatting for improved readability and consistency.
    • No changes to app features, behavior, performance, or security.
    • Build, test, and deployment processes remain unchanged.
    • No user-facing updates; no action required.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Yuanjing Xue <[email protected]>
@yuanjingx87 yuanjingx87 requested review from a team as code owners October 15, 2025 17:03
@yuanjingx87 yuanjingx87 requested review from kxdc and niukuo October 15, 2025 17:03
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 15, 2025

📝 Walkthrough

Walkthrough

Whitespace-only reformat of the Authorization condition in .github/workflows/blossom-ci.yml; no logic or list content changes.

Changes

Cohort / File(s) Summary
CI workflow formatting
.github/workflows/blossom-ci.yml
Reflowed whitespace/line breaks around contains(fromJson(...)) in the Authorization check; no semantic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • yiqingy0
  • tburt-nv
  • niukuo

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title “[None][infra] Update CI allowed list 2025_10_15” suggests a change to the CI allow list, but the diff only reformats whitespace around an Authorization condition without modifying any list entries or logic, so it does not accurately summarize the change. Please update the title to reflect the actual change, for example “Format Authorization condition in CI workflow,” and remove the date suffix or any misleading references to updating an allow list.
Description Check ⚠️ Warning The pull request description consists solely of the unedited template skeleton and lacks a properly formatted title, descriptive summary of what or why changes were made, and any details in the Description and Test Coverage sections. It therefore does not meet the repository’s template requirements for a complete PR description. Please replace the template comments with a valid PR title following the ticket and type conventions, provide a concise Description of the changes and their purpose, list relevant Test Coverage entries, and confirm completion of the PR Checklist items.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yuanjingx87 yuanjingx87 changed the title Update CI allowed list [None][infra] Update CI allowed list Oct 15, 2025
@yuanjingx87 yuanjingx87 changed the title [None][infra] Update CI allowed list [None][infra] Update CI allowed list 2025_10_15 Oct 15, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/blossom-ci.yml (1)

42-45: Allowlist update OK; consider externalizing and deduping for maintainability

The change is fine. To reduce churn and avoid duplicates, move the JSON array to a repo/org variable (e.g., BLOSSOM_ALLOWLIST) and reference it here. Also remove duplicates like "ixlmar", "jthomson04", "heyuhhh" to keep the list clean.

Apply minimal change:

-        fromJson('["byshiue", ... "govind-ramnarayan"]'),
+        fromJson(vars.BLOSSOM_ALLOWLIST),
         github.actor)

(Optional) You can also use github.event.comment.user.login instead of github.actor for specificity on issue_comment events.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65ec01b and 142a3b8.

📒 Files selected for processing (1)
  • .github/workflows/blossom-ci.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

@yuanjingx87 yuanjingx87 requested a review from tburt-nv October 15, 2025 18:55
@yuanjingx87
Copy link
Collaborator Author

/bot skip --comment "no CI needed"

@yuanjingx87 yuanjingx87 enabled auto-merge (squash) October 16, 2025 17:39
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21598 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21598 [ skip ] completed with state ABORTED

@yuanjingx87
Copy link
Collaborator Author

/bot skip --comment "no need to run CI"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21603 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21603 [ skip ] completed with state FAILURE

@yuanjingx87
Copy link
Collaborator Author

/bot skip --comment "no need to run CI"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21614 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21614 [ skip ] completed with state SUCCESS
Skipping testing for commit 142a3b8

@yuanjingx87 yuanjingx87 merged commit 85deacf into NVIDIA:main Oct 16, 2025
8 of 13 checks passed
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants