Skip to content

Conversation

@venkywonka
Copy link
Collaborator

@venkywonka venkywonka commented Oct 14, 2025

Summary by CodeRabbit

  • Chores
    • Expanded repository ownership rules to include an OSS Compliance & Legal section covering license/attribution, dependency management (Python/C++), third‑party components, and build/installation scripts, with designated reviewers for each area.
    • Note: The new OSS Compliance & Legal section was inserted twice, resulting in duplicate rules.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka venkywonka requested review from a team as code owners October 14, 2025 23:57
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

📝 Walkthrough

Walkthrough

Adds an OSS Compliance & Legal section to .github/CODEOWNERS defining license/attribution review rules and reviewer assignments across specified path patterns. The same section is inserted twice, resulting in duplicate compliance blocks.

Changes

Cohort / File(s) Summary
CODEOWNERS updates
.github/CODEOWNERS
Inserted OSS Compliance & Legal section covering License Files, Python/C++ dependency management, third-party dependencies, Docker/installation scripts, and the CODEOWNERS file, with path patterns and designated reviewers. The section appears twice (duplicate insertion).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description provides the template headings but does not include any actual content under the Description or Test Coverage sections, leaving the purpose of the changes and their validation unspecified. Please fill in the Description section with a concise summary of the issue and solution, and list relevant tests or coverage information under Test Coverage to ensure the PR meets documentation requirements.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title “[None] [chore] Add OSS compliance to CODEOWNERS” clearly summarizes the primary change by indicating that OSS compliance rules are being added to the CODEOWNERS file. It is concise, directly related to the main update, and avoids unnecessary detail or ambiguity. The inclusion of the chore tag and ticket placeholder follows the project’s established naming convention.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot changed the title [None] @coderabbitai title [None] [chore] Add OSS compliance to CODEOWNERS; duplicate block Oct 14, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
.github/CODEOWNERS (4)

170-175: Broaden Python dependency coverage (constraints, setup.cfg, pip‑tools, env files).

Apply the following to cover common dependency/lock files:

 ### Python Dependency Management
 /setup.py @NVIDIA/trt-llm-oss-compliance
+/setup.cfg @NVIDIA/trt-llm-oss-compliance
 /pyproject.toml @NVIDIA/trt-llm-oss-compliance
 /requirements.txt @NVIDIA/trt-llm-oss-compliance
 /requirements-dev.txt @NVIDIA/trt-llm-oss-compliance
+/**/requirements*.txt @NVIDIA/trt-llm-oss-compliance
+/**/constraints*.txt @NVIDIA/trt-llm-oss-compliance
+/**/requirements*.in @NVIDIA/trt-llm-oss-compliance
+/**/poetry.lock @NVIDIA/trt-llm-oss-compliance
+/**/Pipfile @NVIDIA/trt-llm-oss-compliance
+/**/Pipfile.lock @NVIDIA/trt-llm-oss-compliance
+/**/environment*.yml @NVIDIA/trt-llm-oss-compliance

176-180: Include additional C/C++ build metadata (Conan lock/text, CMake presets).

 ### C++ Build & Dependency Management
 /cpp/CMakeLists.txt @NVIDIA/trt-llm-oss-compliance
 /cpp/conanfile.py @NVIDIA/trt-llm-oss-compliance
+/cpp/conanfile.txt @NVIDIA/trt-llm-oss-compliance
+/cpp/conan.lock @NVIDIA/trt-llm-oss-compliance
 /cpp/cmake/** @NVIDIA/trt-llm-oss-compliance
+/CMakePresets.json @NVIDIA/trt-llm-oss-compliance
+/cpp/CMakePresets.json @NVIDIA/trt-llm-oss-compliance

181-189: Track submodules and broaden third‑party coverage.

 ### Third-Party Dependencies
 ## Any changes to versions, additions, or removals of third-party libraries
 /3rdparty/** @NVIDIA/trt-llm-oss-compliance
+/.gitmodules @NVIDIA/trt-llm-oss-compliance
+/**/third_party/** @NVIDIA/trt-llm-oss-compliance

185-188: Broaden Docker/installation coverage to all Dockerfiles and install scripts.

 ### Docker & Installation Scripts
 ## These scripts install and pin dependency versions
 /docker/common/** @NVIDIA/trt-llm-setup-infra-devs @NVIDIA/trt-llm-infra-devs @NVIDIA/trt-llm-oss-compliance
+/docker/** @NVIDIA/trt-llm-setup-infra-devs @NVIDIA/trt-llm-infra-devs @NVIDIA/trt-llm-oss-compliance
+/**/Dockerfile @NVIDIA/trt-llm-setup-infra-devs @NVIDIA/trt-llm-infra-devs @NVIDIA/trt-llm-oss-compliance
+/**/Dockerfile* @NVIDIA/trt-llm-setup-infra-devs @NVIDIA/trt-llm-infra-devs @NVIDIA/trt-llm-oss-compliance
+/**/install*.sh @NVIDIA/trt-llm-setup-infra-devs @NVIDIA/trt-llm-infra-devs @NVIDIA/trt-llm-oss-compliance

Note: Adding broader patterns later preserves precedence and includes the same infra owners plus compliance.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d855f4 and 4932372.

📒 Files selected for processing (1)
  • .github/CODEOWNERS (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: venkywonka
PR: NVIDIA/TensorRT-LLM#6029
File: .github/pull_request_template.md:45-53
Timestamp: 2025-08-27T17:50:13.264Z
Learning: For PR templates in TensorRT-LLM, avoid suggesting changes that would increase developer overhead, such as converting plain bullets to mandatory checkboxes. The team prefers guidance-style bullets that don't require explicit interaction to reduce friction in the PR creation process.
📚 Learning: 2025-09-09T18:31:44.336Z
Learnt from: venkywonka
PR: NVIDIA/TensorRT-LLM#7658
File: .github/CODEOWNERS:160-164
Timestamp: 2025-09-09T18:31:44.336Z
Learning: The teams NVIDIA/trt-llm-release-nim-branch-approval and NVIDIA/trt-llm-release-branch-approval exist in the NVIDIA organization and are valid for use in .github/CODEOWNERS files, even if they may not be accessible via external API queries due to permissions.

Applied to files:

  • .github/CODEOWNERS
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (3)
.github/CODEOWNERS (3)

162-191: Solid addition; placement and syntax look correct.

Block is valid CODEOWNERS, late placement ensures precedence over broader rules like /.github and /docker.

Please confirm the @NVIDIA/trt-llm-oss-compliance team has repo access so approvals are enforced by GitHub.


181-184: Verify third‑party path naming (‘3rdparty’ vs ‘third_party’).

If the repo uses a different directory name, this rule won’t trigger. Add/adjust patterns accordingly.


162-191: AI summary says duplicate compliance blocks; only one is present here.

If a duplicate existed in earlier commits, ensure it’s removed to avoid conflicting ownership.

@venkywonka
Copy link
Collaborator Author

@NVIDIA/trt-llm-oss-compliance please to review this 🙏🏾

@venkywonka venkywonka self-assigned this Oct 15, 2025
@venkywonka venkywonka changed the title [None] [chore] Add OSS compliance to CODEOWNERS; duplicate block [None] [chore] Add OSS compliance to CODEOWNERS Oct 15, 2025
@MartinMarciniszyn
Copy link
Collaborator

/bot skip --comment "Change in codeowners"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21477 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21477 [ skip ] completed with state SUCCESS
Skipping testing for commit 4932372

@venkywonka venkywonka merged commit 7efaa52 into NVIDIA:main Oct 15, 2025
8 of 11 checks passed
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants