Skip to content

Conversation

@jiaganc
Copy link
Collaborator

@jiaganc jiaganc commented Aug 12, 2025

Summary by CodeRabbit

  • New Features

    • Allow specifying an exact precompiled wheel version (or a location) via configuration; falls back to the package version when unspecified.
    • More flexible handling of the precompiled flag (string-based) for easier configuration and CI use.
    • Improved wheel download command to run pip via the Python interpreter for greater reliability.
  • Chores

    • Build requirements updated to require pip >= 24 for improved build compatibility.

Description

  1. Downloading precompiled package requires pip module but it's not included in the build environment. Fixed by adding pip to the build requirement in pyproject.toml.
  2. TRTLLM doc says it supports overriding the precompiled package version via TRTLLM_USE_PRECOMPILED but it's actually NOT implemented. This MR implement it.
  3. Use == instead of = to specify the package version in pip.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 12, 2025

📝 Walkthrough

Walkthrough

Build config now requires pip >= 24 in pyproject.toml. setup.py updates precompiled wheel handling: environment-driven version selection, updated download_precompiled signature to accept version, and uses "python3 -m pip" to install an exact tensorrt_llm=={version}, treating precompiled flags as strings.

Changes

Cohort / File(s) Summary of Changes
Build system requirements
pyproject.toml
Added pip >= 24 to build-system.requires; build-backend unchanged.
Precompiled wheel logic and install invocation
setup.py
download_precompiled signature changed to (workspace, version). TRTLLM_USE_PRECOMPILED handled as string (or None); introduced precompiled and precompiled_location vars; use_precompiled computed from string values; when needed computes version (use precompiled unless "1", else get_version()); installs via python3 -m pip install tensorrt_llm=={version} or from provided location.

Sequence Diagram(s)

sequenceDiagram
  participant Env as Environment (TRTLLM_USE_PRECOMPILED / PRECOMPILED_LOCATION)
  participant Setup as setup.py
  participant Pip as python3 -m pip

  Env->>Setup: read precompiled, precompiled_location
  Setup->>Setup: precompiled = str|None, precompiled_location = str|None
  Setup->>Setup: use_precompiled = (precompiled != None and precompiled != "0") or precompiled_location != None
  alt use_precompiled and no precompiled_location
    Setup->>Setup: version = (precompiled != "1") ? precompiled : get_version()
    Setup->>Pip: python3 -m pip install tensorrt_llm==version
  else use_precompiled with precompiled_location
    Setup->>Pip: python3 -m pip install <precompiled_location>
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • chzblych
  • EmmaQiaoCh
  • niukuo

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8f205af and d16f485.

📒 Files selected for processing (1)
  • setup.py (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • setup.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jiaganc jiaganc changed the title [None][fix] Fix python-only build with TRTLLM_USE_PRECOMPILED [None][fix] Fix python-only build Aug 12, 2025
@jiaganc jiaganc changed the title [None][fix] Fix python-only build [None][fix] Fix python-only build that uses TRTLLM_USE_PRECOMPILED Aug 12, 2025
@jiaganc
Copy link
Collaborator Author

jiaganc commented Aug 12, 2025

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14955 [ run ] triggered by Bot

@jiaganc jiaganc requested review from a team and ruodil and removed request for a team August 12, 2025 10:44
@tensorrt-cicd
Copy link
Collaborator

PR_Github #14955 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #11289 (Partly Tested) completed with status: 'SUCCESS'

@jiaganc jiaganc force-pushed the dev-jiaganc-fix-precompiled branch from d16f485 to 5f80ebd Compare August 14, 2025 08:44
@jiaganc
Copy link
Collaborator Author

jiaganc commented Aug 14, 2025

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #15277 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #15277 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #11533 (Partly Tested) completed with status: 'SUCCESS'

@jiaganc
Copy link
Collaborator Author

jiaganc commented Aug 14, 2025

/bot skip --comment "Build stages passed. Precompiled build is only used in development, so skip tests to save CI resources."

@tensorrt-cicd
Copy link
Collaborator

PR_Github #15308 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #15308 [ skip ] completed with state SUCCESS
Skipping testing for commit 5f80ebd

@jiaganc jiaganc merged commit afb116f into NVIDIA:main Aug 14, 2025
4 checks passed
@jiaganc jiaganc deleted the dev-jiaganc-fix-precompiled branch August 14, 2025 15:28
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 17, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 17, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 17, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 17, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 18, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 18, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants