chore: Fix KV cache block reuse flag name in quickstart_advanced #3781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #3103 [ run ] triggered by Bot |
hlu1
approved these changes
Apr 23, 2025
QiJune
reviewed
Apr 23, 2025
Collaborator
|
PR_Github #3103 [ run ] completed with state |
Signed-off-by: Mike Iovine <[email protected]>
mikeiovine
force-pushed
the
fix-quickstart-flags
branch
from
cc09af0 to
d1d6b56
Compare
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #3200 [ run ] triggered by Bot |
Collaborator
|
PR_Github #3200 [ run ] completed with state |
Collaborator
Author
|
/bot skip --comment "Passed before rebase" |
Collaborator
|
PR_Github #3217 [ skip ] triggered by Bot |
Collaborator
|
PR_Github #3217 [ skip ] completed with state |
This was referenced May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quickstart_advanced.pyhas KV cache reuse on by default. You can turn it off with a flag. The problem is that the name of the flag is flipped: runningquickstart_advanced.py --kv_cache_enable_block_reusewill actually disable block reuse! This PR fixes this naming mishap.