From 3bc5eb1d91262ae6ca210746c81dd0582cc94a02 Mon Sep 17 00:00:00 2001 From: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com> Date: Tue, 18 Aug 2026 13:18:38 +0800 Subject: [PATCH] [https://nvbugs/6567057][infra] Unwaive disagg helix test after port reservation race fix The waiver was added during post-merge 2887 triage, when trtllm-serve's port reservation was subject to a TOCTOU race: get_free_ports() bound and closed a probe socket, so another process could take the port before the real bind. The stage log shows the resulting failure: [_utils] [get_free_ports] pid=3520683 reserved ports=[58059] via bind-then-close (subject to TOCTOU reuse before rebinding) OSError: [Errno 98] Address already in use RuntimeError: Failed to bind socket to localhost:58059: [Errno 98] Address already in use. Port holder(s): 127.0.0.1:58059 status=LISTEN pid=3532210 name=trtllm-serve That race was eliminated by commit 9997d3ffb0, which switches the server to --port 0 + --report_addr so the socket is held until the real bind. NVBug 6567057 is closed as a duplicate of 6435121, so the waiver is stale and the test can run in CI again. Since the waiver was written, the test was split into -overlap_on and -overlap_off parametrizations, so both waiver lines are removed. In l0_dgx_b200.yml (8-GPU B200, pytorch/mpi) -overlap_on is tagged stage: pre_merge and -overlap_off is stage: post_merge, so the standard pipeline exercises the -overlap_on variant. Signed-off-by: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com> --- tests/integration/test_lists/waives.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/integration/test_lists/waives.txt b/tests/integration/test_lists/waives.txt index 13cec4c43895..eda131023a4d 100644 --- a/tests/integration/test_lists/waives.txt +++ b/tests/integration/test_lists/waives.txt @@ -1,5 +1,3 @@ -accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_auto_dtype_with_helix[fifo_v2-cudagraph:with_padding-pp1dp2cp2-overlap_off] SKIP (https://nvbugs/6567057) -accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_auto_dtype_with_helix[fifo_v2-cudagraph:with_padding-pp1dp2cp2-overlap_on] SKIP (https://nvbugs/6567057) accuracy/test_disaggregated_serving.py::TestGLM52NVFP4::test_nvfp4_nixl[cache_mgr_v1] SKIP (https://nvbugs/6619883) accuracy/test_disaggregated_serving.py::TestLlama3_1_8BInstruct::test_ctx_pp_gen_tp_asymmetric[GSM8K-gen_tp=1-ctx_pp=4] SKIP (https://nvbugs/6428069) accuracy/test_disaggregated_serving.py::TestLlama3_1_8BInstruct::test_ctx_pp_gen_tp_asymmetric[GSM8K-gen_tp=2-ctx_pp=4] SKIP (https://nvbugs/6428069)