Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation in examples /baichuan/ #1242

Closed
caicre opened this issue Mar 6, 2024 · 2 comments
Closed

Incorrect documentation in examples /baichuan/ #1242

caicre opened this issue Mar 6, 2024 · 2 comments
Assignees
Labels
Documentation Improvements or additions to documentation triaged Issue has been triaged by maintainers

Comments

@caicre
Copy link

caicre commented Mar 6, 2024

The readme file write

python convert_checkpoint.py --model_version v1_13b \
                             --model_dir baichuan-inc/Baichuan-13B-Chat \
                             --dtype float16 \
                             --output_dir ./tmp/baichuan_v1_13b/trt_engines/fp16/1-gpu/

and

trtllm-build --checkpoint_dir ./trt_ckpt/baichuan_v1_13b/ \
             --output_dir ./trt_engines/baichuan_v1_13b/ \
             --gemm_plugin float16 \
             --max_batch_size=32 \
             --max_input_len=1024 \
             --max_output_len=512

Perhaps it means that using trtllm-build to generate an engine from the checkpoint given by convert_checkpoint.py? But the input/ouput of them do not match.

Myabe it should be

python convert_checkpoint.py --model_version v1_13b \
                             --model_dir baichuan-inc/Baichuan-13B-Chat \
                             --dtype float16 \
                             --output_dir ./trt_ckpt/baichuan_v1_13b/

and

trtllm-build --checkpoint_dir ./trt_ckpt/baichuan_v1_13b/ \
             --output_dir ./trt_engines/baichuan_v1_13b/ \
             --gemm_plugin float16 \
             --max_batch_size=32 \
             --max_input_len=1024 \
             --max_output_len=512
@byshiue
Copy link
Collaborator

byshiue commented Mar 7, 2024

Thank you for the report. We will fix it in next update in next week.

@byshiue byshiue self-assigned this Mar 7, 2024
@byshiue byshiue added Documentation Improvements or additions to documentation triaged Issue has been triaged by maintainers labels Mar 7, 2024
@kaiyux
Copy link
Member

kaiyux commented Mar 20, 2024

Thanks for the report, the incorrect documentation is fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation triaged Issue has been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

3 participants