Skip to content

Commit b26e161

Browse files
authored
[https://nvbugs/5633340][fix] kill processes properly after test (#8970)
Signed-off-by: Lizhi Zhou <[email protected]>
1 parent 990e674 commit b26e161

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

tests/integration/defs/disaggregated/test_auto_scaling.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
from tensorrt_llm.logger import logger
1414

15-
TEST_PORT = 18000
15+
TEST_PORT = 8000
1616
HEARTBEAT_INTERVAL = 1
1717
INACTIVE_TIMEOUT = 2
1818

@@ -192,13 +192,13 @@ def verify_cluster_info(ready,
192192

193193

194194
def terminate(*args):
195-
try:
196-
for arg in args:
197-
if arg and isinstance(arg, subprocess.Popen):
198-
arg.terminate()
195+
for arg in args:
196+
if arg and isinstance(arg, subprocess.Popen):
197+
try:
198+
arg.kill()
199199
arg.wait(timeout=10)
200-
except Exception:
201-
pass
200+
except Exception:
201+
print(f"Failed to terminate process {arg.pid}")
202202

203203

204204
def request_completion(model_name, prompt, port=TEST_PORT):

tests/integration/test_lists/waives.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,6 @@ accuracy/test_llm_api_pytorch.py::TestDeepSeekV32::test_nvfp4_multi_gpus[baselin
379379
accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_nvfp4_4gpus[moe_backend=CUTLASS-mtp_nextn=0-pp4-fp8kv=True-attention_dp=True-cuda_graph=True-overlap_scheduler=True-torch_compile=False] SKIP (https://nvbugs/5503479)
380380
test_e2e.py::test_openai_chat_harmony SKIP (https://nvbugs/5596382)
381381
test_e2e.py::test_ptp_quickstart_multimodal_multiturn[phi4-multimodal-instruct-fp8-multimodals/Phi-4-multimodal-instruct-FP8] SKIP (https://nvbugs/5568836)
382-
disaggregated/test_auto_scaling.py::test_disagg_server_restart[etcd-round_robin] SKIP (https://nvbugs/5633340)
383382
accuracy/test_cli_flow.py::TestMinitron4BBase::test_fp8 SKIP (https://nvbugs/5606233)
384383
examples/test_gpt.py::test_llm_minitron_fp8_with_pseudo_loras[4b] SKIP (https://nvbugs/5606233)
385384
accuracy/test_llm_api_pytorch.py::TestQwen3_8B::test_bf16[multi_gpus_no_cache] SKIP (https://nvbugs/5606266)

0 commit comments

Comments
 (0)