From 2c9f120315489db876064ab7833526dfaa246c8b Mon Sep 17 00:00:00 2001 From: Thabhelo <50872400+Thabhelo@users.noreply.github.com> Date: Wed, 3 Jun 2026 15:06:40 -0400 Subject: [PATCH] test(onboard): cover Windows Ollama negative probe paths Follow-up to #4089 / #4066 review notes. --- src/lib/onboard/windows-host-ollama.test.ts | 21 +++++++++++++++++++++ src/lib/onboard/windows-host-ollama.ts | 2 ++ 2 files changed, 23 insertions(+) diff --git a/src/lib/onboard/windows-host-ollama.test.ts b/src/lib/onboard/windows-host-ollama.test.ts index da12abcef8f..79fbbb3cdc9 100644 --- a/src/lib/onboard/windows-host-ollama.test.ts +++ b/src/lib/onboard/windows-host-ollama.test.ts @@ -40,4 +40,25 @@ describe("detectWindowsHostOllama", () => { loopbackOnly: false, }); }); + + it("returns uninstalled when not on WSL", () => { + vi.mocked(isWsl).mockReturnValue(false); + + expect(detectWindowsHostOllama()).toEqual({ + installed: false, + installedPath: "", + loopbackOnly: false, + }); + expect(runCapture).not.toHaveBeenCalled(); + }); + + it("returns uninstalled when all Windows Ollama probes miss", () => { + runCapture.mockImplementation(() => ""); + + expect(detectWindowsHostOllama()).toEqual({ + installed: false, + installedPath: "", + loopbackOnly: false, + }); + }); }); diff --git a/src/lib/onboard/windows-host-ollama.ts b/src/lib/onboard/windows-host-ollama.ts index a496d34887b..9ccda7d584e 100644 --- a/src/lib/onboard/windows-host-ollama.ts +++ b/src/lib/onboard/windows-host-ollama.ts @@ -75,6 +75,8 @@ export function detectWindowsHostOllama(): WindowsHostOllamaState { return { installed: false, installedPath: "", loopbackOnly: false }; } const installedPath = probeInstalledPath(); + // `installed` reflects binary presence on disk, not a live daemon. Onboard + // still gates Start/Restart on reachability and loopback binding (#3949). const installed = installedPath.length > 0; const loopbackOnly = installed ? probeLoopbackOnly() : false; return { installed, installedPath, loopbackOnly };