Skip to content

Conversation

@abdalgader-a
Copy link

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

added HFQwen3Exporter for qwen models. This helps on model conversion.

Collection: [Note which collection this PR will affect]

Test

tested on Nemo-RL that use this repo as submodule

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

@ashors1 and anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to a PR in NVIDIA-NeMo/RL 802

@abdalgader-a
Copy link
Author

abdalgader-a commented Aug 1, 2025

@ashors1 -- seems the auto "Isort and Black Formatting" workflow caused many unintended changes. how can stop it?

update: resolved it

@abdalgader-a abdalgader-a force-pushed the abdal-fix-qwen3-export branch from 10a118f to 983ae94 Compare August 1, 2025 11:02
@github-actions github-actions bot removed core Changes to NeMo Core TTS ASR NLP labels Aug 1, 2025
Signed-off-by: abdalgader-a <[email protected]>
@abdalgader-a abdalgader-a force-pushed the abdal-fix-qwen3-export branch from 983ae94 to d493fae Compare August 4, 2025 06:49
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 19, 2025
@ashors1
Copy link
Collaborator

ashors1 commented Aug 19, 2025

Closing since NVIDIA-NeMo/RL#873 was merged

@ashors1 ashors1 closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants