Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can you support DoRA? #9520

Closed
SJmdy opened this issue Jun 23, 2024 · 3 comments
Closed

Can you support DoRA? #9520

SJmdy opened this issue Jun 23, 2024 · 3 comments
Assignees
@cuichenx
Labels
feature request/PR for a new feature stale

Comments

@SJmdy
Copy link

SJmdy commented Jun 23, 2024

Hi Team,
Do you have any plans to support DoRA?

Paper: https://arxiv.org/abs/2402.09353
peft: huggingface/peft#1474

Thank you
@elliottnv elliottnv added the feature request/PR for a new feature label Jul 3, 2024
@cuichenx
Copy link
Collaborator

cuichenx commented Jul 5, 2024

Hi @SJmdy
Dora is a planned feature in the near future. We plan on supporting it once to transition to NeMo 2.0 is mature.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuichenx cuichenx

Labels
feature request/PR for a new feature stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cuichenx @SJmdy @elliottnv