-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
torch.stft() signature has been updated for PyTorch 1.7+ Please update PyTorch to remain compatible with later versions of NeMo. #2780
Comments
I cant seem to reproduce the issue, its working good on colab. Could you rerun? |
So for you to be sure i didnt miss anything, i used "Run all" (cells) trainer.fit(speaker_model) [NeMo I 2021-09-16 06:26:58 label_models:240] val_loss: 32.002 Epoch 4, global step 83: val_loss was not in top 3 it now runs without problems until: "Restoring from a PyTorch Lightning checkpoint To restore a model using the LightningModule.load_from_checkpoint() class method." restored_model = nemo_asr.models.EncDecSpeakerLabelModel.load_from_checkpoint(final_checkpoint) TypeError Traceback (most recent call last) in () 2 frames /usr/local/lib/python3.7/dist-packages/pytorch_lightning/core/saving.py in _load_model_state(cls, checkpoint, strict, cls_kwargs_new) TypeError: init() missing 1 required positional argument: 'cfg' |
This looks to me issue with the latest pytorch lightning. Can you manually run |
this fix brings us to cell/code: manifest_filepath = os.path.join(NEMO_ROOT,'embeddings_manifest.json') [NeMo I 2021-09-16 07:11:06 audio_to_label:445] Time length considered for collate func is 20 NameError Traceback (most recent call last) in () in get_embeddings(speaker_model, manifest_file, batch_size, embedding_dir, device) NameError: name 'tqdm' is not defined |
Please read my above comment, import fix for that is provided through PR #2821 |
ok, i got you. Used the changes you made there and now its running without problems! Great work! {"audio_filepath": "../rivaclient/NeMo/scripts/dataset_processing/data/dev/SPEECHDATA/wav/SV0280/SV0280_6_07_S3653.wav", "offset": 0, "duration": 1.488, "label": "SV0280"} KeyError: Caught KeyError in DataLoader worker process 0. is this related to todays fix? will try later thanks!!! |
Describe the bug
[NeMo W 2021-09-06 11:58:47 patch_utils:50] torch.stft() signature has been updated for PyTorch 1.7+
Please update PyTorch to remain compatible with later versions of NeMo.
and followed by
/usr/local/lib/python3.7/dist-packages/torch/nn/functional.py in _pad(input, pad, mode, value)
4157 assert len(pad) == 2, "3D tensors expect 2 values for padding"
4158 if mode == "reflect":
-> 4159 return torch._C._nn.reflection_pad1d(input, pad)
4160 elif mode == "replicate":
4161 return torch._C._nn.replication_pad1d(input, pad)
RuntimeError: Argument #4: Padding size should be less than the corresponding input dimension, but got: padding (256, 256) at dimension 2 of input [1, 2, 2]
also in this notebook, next to the AN4 Source not available problem:
Original Cell: restored_model.setup_finetune_model(config.model)
TypeError Traceback (most recent call last)
in ()
----> 1 restored_model.setup_finetune_model(config.model)
if i change to
Cell: restored_model.setup_finetune_model(model_config = config.model)
TypeError: setup_finetune_model() missing 1 required positional argument: 'model_config'
NameError Traceback (most recent call last)
in ()
----> 1 restored_model.setup_finetune_model(self, model_config=config.model)
NameError: name 'self' is not defined
same with this
cell: restored_model.set_trainer(trainer_finetune)
TypeError Traceback (most recent call last)
in ()
----> 1 restored_model.set_trainer(trainer_finetune)
2 log_dir_finetune = exp_manager(trainer_finetune, config.get("exp_manager", None))
3 print(log_dir_finetune)
TypeError: set_trainer() missing 1 required positional argument: 'trainer'
Steps/Code to reproduce bug
Cell: trainer.fit(speaker_model)
in
https://colab.research.google.com/github/NVIDIA/NeMo/blob/main/tutorials/speaker_recognition/Speaker_Recognition_Verification.ipynb
Expected behavior
(as expected by the ppl that made this notebook.... Colab training should work without bugfixing :-))
Torch 1.9 is installed, no updates possible as it seems...
Environment overview (please complete the following information)
torch @ https://download.pytorch.org/whl/cu102/torch-1.9.0%2Bcu102-cp37-cp37m-linux_x86_64.whl
torch-stft==0.1.4
torchaudio==0.9.0
torchmetrics==0.5.1
torchsummary==1.5.1
torchtext==0.10.0
torchvision @ https://download.pytorch.org/whl/cu102/torchvision-0.10.0%2Bcu102-cp37-cp37m-linux_x86_64.whl
Environment details
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
The text was updated successfully, but these errors were encountered: