From 9ceec1c75e741fa344ef6d00101fc89ce8e37cc7 Mon Sep 17 00:00:00 2001 From: David Gardner Date: Mon, 27 Jul 2026 08:23:27 -0700 Subject: [PATCH 1/8] Updating versions for v0.2.0 Signed-off-by: David Gardner --- Cargo.toml | 4 ++-- adapters/claude/pyproject.toml | 4 ++-- adapters/claude/uv.lock | 4 ++-- adapters/codex/pyproject.toml | 4 ++-- adapters/codex/uv.lock | 4 ++-- adapters/common/pyproject.toml | 2 +- adapters/common/uv.lock | 2 +- adapters/deepagents/pyproject.toml | 4 ++-- adapters/deepagents/uv.lock | 4 ++-- adapters/hermes/pyproject.toml | 4 ++-- adapters/hermes/uv.lock | 4 ++-- pyproject.toml | 16 ++++++++-------- uv.lock | 12 ++++++------ 13 files changed, 34 insertions(+), 34 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index fc77c16f8..5ec865432 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -14,13 +14,13 @@ default-members = [ resolver = "2" [workspace.package] -version = "0.1.0" +version = "0.2.0" edition = "2024" license = "Apache-2.0" repository = "https://github.com/NVIDIA/nemo-fabric" [workspace.dependencies] -nemo-fabric-core = { path = "crates/fabric-core", version = "0.1.0" } +nemo-fabric-core = { path = "crates/fabric-core", version = "0.2.0" } clap = { version = "4", default-features = false, features = ["derive", "std", "help", "usage", "error-context", "suggestions"] } schemars = { version = "1", features = ["derive"] } diff --git a/adapters/claude/pyproject.toml b/adapters/claude/pyproject.toml index f80d80986..f35222caa 100644 --- a/adapters/claude/pyproject.toml +++ b/adapters/claude/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric-adapters-claude" -version = "0.1.0" +version = "0.2.0" description = "Claude adapter for NeMo Fabric" authors = [ { name = "NVIDIA Corporation" }, @@ -25,7 +25,7 @@ license-files = ["LICENSE"] readme = "README.md" requires-python = ">=3.11" dependencies = [ - "nemo-fabric-adapters-common == 0.1.0", + "nemo-fabric-adapters-common == 0.2.0", "claude-agent-sdk==0.2.120", "tomli-w~=1.2", ] diff --git a/adapters/claude/uv.lock b/adapters/claude/uv.lock index 012c18e12..b2b617547 100644 --- a/adapters/claude/uv.lock +++ b/adapters/claude/uv.lock @@ -350,7 +350,7 @@ wheels = [ [[package]] name = "nemo-fabric-adapters-claude" -version = "0.1.0" +version = "0.2.0" source = { editable = "." } dependencies = [ { name = "claude-agent-sdk" }, @@ -367,7 +367,7 @@ requires-dist = [ [[package]] name = "nemo-fabric-adapters-common" -version = "0.1.0" +version = "0.2.0" source = { editable = "../common" } [[package]] diff --git a/adapters/codex/pyproject.toml b/adapters/codex/pyproject.toml index 7acd61c0f..63b5d0752 100644 --- a/adapters/codex/pyproject.toml +++ b/adapters/codex/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric-adapters-codex" -version = "0.1.0" +version = "0.2.0" description = "Codex adapter for NeMo Fabric" authors = [ { name = "NVIDIA Corporation" }, @@ -25,7 +25,7 @@ license-files = ["LICENSE"] readme = "README.md" requires-python = ">=3.11" dependencies = [ - "nemo-fabric-adapters-common == 0.1.0", + "nemo-fabric-adapters-common == 0.2.0", "openai-codex==0.144.4", "tomli-w~=1.2", ] diff --git a/adapters/codex/uv.lock b/adapters/codex/uv.lock index a76f126a6..b66fd4f11 100644 --- a/adapters/codex/uv.lock +++ b/adapters/codex/uv.lock @@ -13,7 +13,7 @@ wheels = [ [[package]] name = "nemo-fabric-adapters-codex" -version = "0.1.0" +version = "0.2.0" source = { editable = "." } dependencies = [ { name = "nemo-fabric-adapters-common" }, @@ -30,7 +30,7 @@ requires-dist = [ [[package]] name = "nemo-fabric-adapters-common" -version = "0.1.0" +version = "0.2.0" source = { editable = "../common" } [[package]] diff --git a/adapters/common/pyproject.toml b/adapters/common/pyproject.toml index e428d1d49..cd3b63302 100644 --- a/adapters/common/pyproject.toml +++ b/adapters/common/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric-adapters-common" -version = "0.1.0" +version = "0.2.0" description = "Shared Python helpers for NeMo Fabric adapters" authors = [ { name = "NVIDIA Corporation" }, diff --git a/adapters/common/uv.lock b/adapters/common/uv.lock index a9e754d66..b7d8656f9 100644 --- a/adapters/common/uv.lock +++ b/adapters/common/uv.lock @@ -4,5 +4,5 @@ requires-python = ">=3.11" [[package]] name = "nemo-fabric-adapters-common" -version = "0.1.0" +version = "0.2.0" source = { editable = "." } diff --git a/adapters/deepagents/pyproject.toml b/adapters/deepagents/pyproject.toml index ceb261b02..433ba938c 100644 --- a/adapters/deepagents/pyproject.toml +++ b/adapters/deepagents/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric-adapters-deepagents" -version = "0.1.0" +version = "0.2.0" description = "LangChain Deep Agents adapter for NeMo Fabric" authors = [ { name = "NVIDIA Corporation" }, @@ -25,7 +25,7 @@ license-files = ["LICENSE"] readme = "README.md" requires-python = ">=3.11" dependencies = [ - "nemo-fabric-adapters-common == 0.1.0", + "nemo-fabric-adapters-common == 0.2.0", "deepagents>=0.6.12,<0.7.0", "langchain>=1.3,<2.0", "langchain-mcp-adapters>=0.1,<0.3.0", diff --git a/adapters/deepagents/uv.lock b/adapters/deepagents/uv.lock index 72d964e8c..a55ddb68c 100644 --- a/adapters/deepagents/uv.lock +++ b/adapters/deepagents/uv.lock @@ -834,12 +834,12 @@ wheels = [ [[package]] name = "nemo-fabric-adapters-common" -version = "0.1.0" +version = "0.2.0" source = { editable = "../common" } [[package]] name = "nemo-fabric-adapters-deepagents" -version = "0.1.0" +version = "0.2.0" source = { editable = "." } dependencies = [ { name = "deepagents" }, diff --git a/adapters/hermes/pyproject.toml b/adapters/hermes/pyproject.toml index 0cc58fb21..d15d866c1 100644 --- a/adapters/hermes/pyproject.toml +++ b/adapters/hermes/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric-adapters-hermes" -version = "0.1.0" +version = "0.2.0" description = "Hermes Agent adapter for NeMo Fabric" authors = [ { name = "NVIDIA Corporation" }, @@ -26,7 +26,7 @@ readme = "README.md" # Hermes Agent does not currently support Python 3.14 or later. requires-python = ">=3.11,<3.14" dependencies = [ - "nemo-fabric-adapters-common == 0.1.0", + "nemo-fabric-adapters-common == 0.2.0", "pyyaml>=6.0", # needed for writing hermes config files ] diff --git a/adapters/hermes/uv.lock b/adapters/hermes/uv.lock index 2809511b2..c2d5d663c 100644 --- a/adapters/hermes/uv.lock +++ b/adapters/hermes/uv.lock @@ -4,12 +4,12 @@ requires-python = ">=3.11, <3.14" [[package]] name = "nemo-fabric-adapters-common" -version = "0.1.0" +version = "0.2.0" source = { editable = "../common" } [[package]] name = "nemo-fabric-adapters-hermes" -version = "0.1.0" +version = "0.2.0" source = { editable = "." } dependencies = [ { name = "nemo-fabric-adapters-common" }, diff --git a/pyproject.toml b/pyproject.toml index 0986794bc..230b83d2b 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric" -version = "0.1.0" +version = "0.2.0" description = "Python SDK distribution for NeMo Fabric" authors = [ { name = "NVIDIA Corporation" }, @@ -25,7 +25,7 @@ license-files = ["LICENSE"] readme = "pypi.md" requires-python = ">=3.11" dependencies = [ - "nemo-fabric-runtime == 0.1.0", + "nemo-fabric-runtime == 0.2.0", ] [project.urls] @@ -38,15 +38,15 @@ packages = [] [project.optional-dependencies] codex = [ - "nemo-fabric-adapters-codex == 0.1.0", + "nemo-fabric-adapters-codex == 0.2.0", ] claude = [ - "nemo-fabric-adapters-claude == 0.1.0", + "nemo-fabric-adapters-claude == 0.2.0", ] deepagents = [ - "nemo-fabric-adapters-deepagents == 0.1.0", + "nemo-fabric-adapters-deepagents == 0.2.0", ] harbor = [ @@ -55,11 +55,11 @@ harbor = [ ] hermes = [ - "nemo-fabric-adapters-hermes == 0.1.0; python_version < '3.14'", + "nemo-fabric-adapters-hermes == 0.2.0; python_version < '3.14'", ] hermes-agent = [ - "nemo-fabric-adapters-hermes == 0.1.0; python_version < '3.14'", + "nemo-fabric-adapters-hermes == 0.2.0; python_version < '3.14'", "hermes-agent>=0.17.0; python_version < '3.14'", ] @@ -69,7 +69,7 @@ relay = [ ] runtime = [ - "nemo-fabric-runtime == 0.1.0", + "nemo-fabric-runtime == 0.2.0", ] [dependency-groups] diff --git a/uv.lock b/uv.lock index b42dde975..d7cc43548 100644 --- a/uv.lock +++ b/uv.lock @@ -2047,7 +2047,7 @@ wheels = [ [[package]] name = "nemo-fabric" -version = "0.1.0" +version = "0.2.0" source = { editable = "." } dependencies = [ { name = "nemo-fabric-runtime" }, @@ -2169,7 +2169,7 @@ test = [ [[package]] name = "nemo-fabric-adapters-claude" -version = "0.1.0" +version = "0.2.0" source = { editable = "adapters/claude" } dependencies = [ { name = "claude-agent-sdk" }, @@ -2186,7 +2186,7 @@ requires-dist = [ [[package]] name = "nemo-fabric-adapters-codex" -version = "0.1.0" +version = "0.2.0" source = { editable = "adapters/codex" } dependencies = [ { name = "nemo-fabric-adapters-common" }, @@ -2203,12 +2203,12 @@ requires-dist = [ [[package]] name = "nemo-fabric-adapters-common" -version = "0.1.0" +version = "0.2.0" source = { editable = "adapters/common" } [[package]] name = "nemo-fabric-adapters-deepagents" -version = "0.1.0" +version = "0.2.0" source = { editable = "adapters/deepagents" } dependencies = [ { name = "deepagents" }, @@ -2240,7 +2240,7 @@ provides-extras = ["relay"] [[package]] name = "nemo-fabric-adapters-hermes" -version = "0.1.0" +version = "0.2.0" source = { editable = "adapters/hermes" } dependencies = [ { name = "nemo-fabric-adapters-common", marker = "python_full_version < '3.14'" }, From 6a5059631550e04272bb5f6cd7f34fd4d65b4c87 Mon Sep 17 00:00:00 2001 From: Bryan Bednarski Date: Mon, 27 Jul 2026 18:35:30 -0600 Subject: [PATCH 2/8] fix(relay): harden artifact collection Signed-off-by: Bryan Bednarski --- .../src/nemo_fabric_adapters/common/utils.py | 83 ++++++++++---- tests/adapters/test_adapaters_common_utils.py | 102 +++++++++++++++++- 2 files changed, 166 insertions(+), 19 deletions(-) diff --git a/adapters/common/src/nemo_fabric_adapters/common/utils.py b/adapters/common/src/nemo_fabric_adapters/common/utils.py index 1fe8dd2a5..1a3cd9e1d 100644 --- a/adapters/common/src/nemo_fabric_adapters/common/utils.py +++ b/adapters/common/src/nemo_fabric_adapters/common/utils.py @@ -271,7 +271,44 @@ def normalize_relay_output_dirs(plugin_config: dict[str, Any], payload: dict[str atif.setdefault("model_name", relay_model_name(payload)) +def _artifact_directory(value: Any) -> Path | None: + if not value: + return None + try: + directory = Path(value).resolve(strict=True) + except (OSError, TypeError, ValueError): + return None + return directory if directory.is_dir() else None + + +def _artifact_file(value: Any, *, directory: Path) -> Path | None: + try: + path = Path(value).resolve(strict=True) + except (OSError, TypeError, ValueError): + return None + if not path.is_file() or not path.is_relative_to(directory): + return None + return path + + +def _artifact_name_is_local(value: str) -> bool: + try: + return Path(value).name == value + except (OSError, ValueError): + return False + + +def _artifact_glob(directory: Path, pattern: str) -> list[Path]: + if not _artifact_name_is_local(pattern): + return [] + try: + return sorted(directory.glob(pattern)) + except (OSError, ValueError): + return [] + + def collect_relay_artifacts(plugin_config: dict[str, Any]) -> list[dict[str, str]]: + artifacts: list[dict[str, str]] = [] for component in plugin_config.get("components", []): if component.get("kind") != "observability": @@ -282,26 +319,36 @@ def collect_relay_artifacts(plugin_config: dict[str, Any]) -> list[dict[str, str for sink in atof.get("sinks") or []: if not isinstance(sink, dict) or sink.get("type") != "file": continue - output_directory = sink.get("output_directory") - if not output_directory: - continue - directory = Path(output_directory) - if not directory.exists(): - continue - for path in sorted(directory.glob("*.jsonl")): - artifacts.append({"kind": "atof", "path": str(path)}) + directory = _artifact_directory(sink.get("output_directory")) + if directory is not None: + filename = sink.get("filename") + if isinstance(filename, str) and filename: + paths = ( + [directory / filename] + if _artifact_name_is_local(filename) + else [] + ) + else: + paths = _artifact_glob(directory, "*.jsonl") + for path in paths: + resolved = _artifact_file(path, directory=directory) + if resolved is not None: + artifacts.append({"kind": "atof", "path": str(resolved)}) atif = config.get("atif") - if not isinstance(atif, dict) or not atif.get("enabled"): - continue - output_directory = atif.get("output_directory") - if not output_directory: - continue - directory = Path(output_directory) - if not directory.exists(): - continue - for path in sorted(directory.glob("*.json")): - artifacts.append({"kind": "atif", "path": str(path)}) + if isinstance(atif, dict) and atif.get("enabled"): + directory = _artifact_directory(atif.get("output_directory")) + if directory is not None: + template = atif.get("filename_template") + pattern = ( + template.replace("{session_id}", "*") + if isinstance(template, str) and template + else "*.json" + ) + for path in _artifact_glob(directory, pattern): + resolved = _artifact_file(path, directory=directory) + if resolved is not None: + artifacts.append({"kind": "atif", "path": str(resolved)}) return artifacts diff --git a/tests/adapters/test_adapaters_common_utils.py b/tests/adapters/test_adapaters_common_utils.py index b9ed3ba2a..47cfc22d9 100644 --- a/tests/adapters/test_adapaters_common_utils.py +++ b/tests/adapters/test_adapaters_common_utils.py @@ -8,6 +8,7 @@ import tomllib from io import StringIO from pathlib import Path +from typing import Any import nemo_fabric_adapters.common.utils as common_utils import pytest @@ -369,9 +370,15 @@ def test_collect_relay_artifacts(tmp_path: Path): atof_file = atof_dir / "events.atof.jsonl" atif_file = atif_dir / "trajectory-1.atif.json" ignored_file = atif_dir / "ignored.txt" + unrelated_atif = atif_dir / "config.json" + atof_directory = atof_dir / "directory.jsonl" + atif_directory = atif_dir / "trajectory-directory.atif.json" atof_file.write_text("{}", encoding="utf-8") atif_file.write_text("{}", encoding="utf-8") ignored_file.write_text("ignored", encoding="utf-8") + unrelated_atif.write_text("{}", encoding="utf-8") + atof_directory.mkdir() + atif_directory.mkdir() plugin_config = { "components": [ { @@ -390,7 +397,11 @@ def test_collect_relay_artifacts(tmp_path: Path): }, ], }, - "atif": {"enabled": True, "output_directory": str(atif_dir)}, + "atif": { + "enabled": True, + "output_directory": str(atif_dir), + "filename_template": "trajectory-{session_id}.atif.json", + }, }, } ] @@ -427,6 +438,95 @@ def test_collect_relay_artifacts_ignores_missing_output_directories( assert common_utils.collect_relay_artifacts(plugin_config) == [] +def _atof_artifact_config( + output_directory: object, + *, + filename: object | None = None, +) -> dict[str, Any]: + sink: dict[str, Any] = { + "type": "file", + "output_directory": output_directory, + } + if filename is not None: + sink["filename"] = filename + return { + "components": [ + { + "kind": "observability", + "config": { + "atof": { + "enabled": True, + "sinks": [sink], + } + }, + } + ] + } + + +def test_collect_relay_artifacts_honors_configured_atof_filename(tmp_path: Path): + atof_dir = tmp_path / "atof" + atof_dir.mkdir() + configured = atof_dir / "configured.jsonl" + ignored = atof_dir / "ignored.jsonl" + configured.write_text("{}", encoding="utf-8") + ignored.write_text("{}", encoding="utf-8") + plugin_config = _atof_artifact_config(atof_dir, filename=configured.name) + + assert common_utils.collect_relay_artifacts(plugin_config) == [ + {"kind": "atof", "path": str(configured)} + ] + + +def test_collect_relay_artifacts_missing_configured_atof_file_returns_empty( + tmp_path: Path, +): + atof_dir = tmp_path / "atof" + atof_dir.mkdir() + (atof_dir / "unrelated.jsonl").write_text("{}", encoding="utf-8") + plugin_config = _atof_artifact_config(atof_dir, filename="missing.jsonl") + + assert common_utils.collect_relay_artifacts(plugin_config) == [] + + +def test_collect_relay_artifacts_non_string_atof_filename_uses_glob(tmp_path: Path): + atof_dir = tmp_path / "atof" + atof_dir.mkdir() + artifact = atof_dir / "events.jsonl" + artifact.write_text("{}", encoding="utf-8") + plugin_config = _atof_artifact_config(atof_dir, filename=123) + + assert common_utils.collect_relay_artifacts(plugin_config) == [ + {"kind": "atof", "path": str(artifact)} + ] + + +def test_collect_relay_artifacts_rejects_escaping_atof_filenames(tmp_path: Path): + atof_dir = tmp_path / "atof" + atof_dir.mkdir() + outside = tmp_path / "outside.jsonl" + outside.write_text("{}", encoding="utf-8") + + for filename in (str(outside), "../outside.jsonl"): + plugin_config = _atof_artifact_config(atof_dir, filename=filename) + assert common_utils.collect_relay_artifacts(plugin_config) == [] + + +def test_collect_relay_artifacts_ignores_malformed_paths(tmp_path: Path): + atof_dir = tmp_path / "atof" + atof_dir.mkdir() + plugin_config = _atof_artifact_config( + atof_dir, + filename="invalid\0name.jsonl", + ) + plugin_config["components"][0]["config"]["atif"] = { + "enabled": True, + "output_directory": "invalid\0directory", + } + + assert common_utils.collect_relay_artifacts(plugin_config) == [] + + def test_relay_validates_raw_v06_plugin_config(): from nemo_relay import plugin From 4d966d3df186447b1dea9154720caf0fde04a361 Mon Sep 17 00:00:00 2001 From: Bryan Bednarski Date: Mon, 27 Jul 2026 22:23:53 -0600 Subject: [PATCH 3/8] fix(relay): handle artifact resolution loops Signed-off-by: Bryan Bednarski --- .../src/nemo_fabric_adapters/common/utils.py | 4 +-- tests/adapters/test_adapaters_common_utils.py | 35 +++++++++++++++++++ 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/adapters/common/src/nemo_fabric_adapters/common/utils.py b/adapters/common/src/nemo_fabric_adapters/common/utils.py index 1a3cd9e1d..f56b62304 100644 --- a/adapters/common/src/nemo_fabric_adapters/common/utils.py +++ b/adapters/common/src/nemo_fabric_adapters/common/utils.py @@ -276,7 +276,7 @@ def _artifact_directory(value: Any) -> Path | None: return None try: directory = Path(value).resolve(strict=True) - except (OSError, TypeError, ValueError): + except (OSError, RuntimeError, TypeError, ValueError): return None return directory if directory.is_dir() else None @@ -284,7 +284,7 @@ def _artifact_directory(value: Any) -> Path | None: def _artifact_file(value: Any, *, directory: Path) -> Path | None: try: path = Path(value).resolve(strict=True) - except (OSError, TypeError, ValueError): + except (OSError, RuntimeError, TypeError, ValueError): return None if not path.is_file() or not path.is_relative_to(directory): return None diff --git a/tests/adapters/test_adapaters_common_utils.py b/tests/adapters/test_adapaters_common_utils.py index 47cfc22d9..76babafcb 100644 --- a/tests/adapters/test_adapaters_common_utils.py +++ b/tests/adapters/test_adapaters_common_utils.py @@ -489,6 +489,41 @@ def test_collect_relay_artifacts_missing_configured_atof_file_returns_empty( assert common_utils.collect_relay_artifacts(plugin_config) == [] +def test_collect_relay_artifacts_configured_atof_directory_returns_empty( + tmp_path: Path, +): + atof_dir = tmp_path / "atof" + atof_dir.mkdir() + configured = atof_dir / "directory.jsonl" + configured.mkdir() + plugin_config = _atof_artifact_config(atof_dir, filename=configured.name) + + assert common_utils.collect_relay_artifacts(plugin_config) == [] + + +def test_collect_relay_artifacts_ignores_path_resolution_runtime_errors( + tmp_path: Path, + monkeypatch: pytest.MonkeyPatch, +): + artifact_dir = tmp_path / "atof" + artifact_dir.mkdir() + original_resolve = Path.resolve + + def resolve(path: Path, *, strict: bool = False) -> Path: + if path.name == "loop": + raise RuntimeError("symlink loop") + return original_resolve(path, strict=strict) + + monkeypatch.setattr(Path, "resolve", resolve) + + assert common_utils.collect_relay_artifacts( + _atof_artifact_config(tmp_path / "loop") + ) == [] + assert common_utils.collect_relay_artifacts( + _atof_artifact_config(artifact_dir, filename="loop") + ) == [] + + def test_collect_relay_artifacts_non_string_atof_filename_uses_glob(tmp_path: Path): atof_dir = tmp_path / "atof" atof_dir.mkdir() From 5d049db11ae7900c5a920042cfe5f3eba3f1471a Mon Sep 17 00:00:00 2001 From: Bryan Bednarski Date: Tue, 28 Jul 2026 08:24:34 -0600 Subject: [PATCH 4/8] fix(relay): require ATIF artifact templates Signed-off-by: Bryan Bednarski --- .../src/nemo_fabric_adapters/common/utils.py | 8 +++--- tests/adapters/test_adapaters_common_utils.py | 26 +++++++++++++++++++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/adapters/common/src/nemo_fabric_adapters/common/utils.py b/adapters/common/src/nemo_fabric_adapters/common/utils.py index f56b62304..5567e43a1 100644 --- a/adapters/common/src/nemo_fabric_adapters/common/utils.py +++ b/adapters/common/src/nemo_fabric_adapters/common/utils.py @@ -340,11 +340,9 @@ def collect_relay_artifacts(plugin_config: dict[str, Any]) -> list[dict[str, str directory = _artifact_directory(atif.get("output_directory")) if directory is not None: template = atif.get("filename_template") - pattern = ( - template.replace("{session_id}", "*") - if isinstance(template, str) and template - else "*.json" - ) + if not isinstance(template, str) or not template: + continue + pattern = template.replace("{session_id}", "*") for path in _artifact_glob(directory, pattern): resolved = _artifact_file(path, directory=directory) if resolved is not None: diff --git a/tests/adapters/test_adapaters_common_utils.py b/tests/adapters/test_adapaters_common_utils.py index 76babafcb..065d842c9 100644 --- a/tests/adapters/test_adapaters_common_utils.py +++ b/tests/adapters/test_adapaters_common_utils.py @@ -413,6 +413,32 @@ def test_collect_relay_artifacts(tmp_path: Path): ] +@pytest.mark.parametrize("filename_template", [None, "", 123]) +def test_collect_relay_artifacts_requires_valid_atif_filename_template( + tmp_path: Path, + filename_template: object, +): + atif_dir = tmp_path / "atif" + atif_dir.mkdir() + (atif_dir / "config.json").write_text("{}", encoding="utf-8") + atif_config: dict[str, Any] = { + "enabled": True, + "output_directory": str(atif_dir), + } + if filename_template is not None: + atif_config["filename_template"] = filename_template + plugin_config = { + "components": [ + { + "kind": "observability", + "config": {"atif": atif_config}, + } + ] + } + + assert common_utils.collect_relay_artifacts(plugin_config) == [] + + def test_collect_relay_artifacts_ignores_missing_output_directories( tmp_path: Path, monkeypatch: pytest.MonkeyPatch, From 47c838b44ad8abc4c317db2a82d4fad9c354b9e7 Mon Sep 17 00:00:00 2001 From: Bryan Bednarski Date: Tue, 28 Jul 2026 08:42:28 -0600 Subject: [PATCH 5/8] test(claude): declare ATIF artifact template Signed-off-by: Bryan Bednarski --- tests/adapters/test_adapaters_common_utils.py | 2 +- tests/adapters/test_claude_adapter.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/adapters/test_adapaters_common_utils.py b/tests/adapters/test_adapaters_common_utils.py index 065d842c9..e911c85f7 100644 --- a/tests/adapters/test_adapaters_common_utils.py +++ b/tests/adapters/test_adapaters_common_utils.py @@ -537,7 +537,7 @@ def test_collect_relay_artifacts_ignores_path_resolution_runtime_errors( def resolve(path: Path, *, strict: bool = False) -> Path: if path.name == "loop": - raise RuntimeError("symlink loop") + raise RuntimeError return original_resolve(path, strict=strict) monkeypatch.setattr(Path, "resolve", resolve) diff --git a/tests/adapters/test_claude_adapter.py b/tests/adapters/test_claude_adapter.py index f575fe0b9..5d1af53e4 100644 --- a/tests/adapters/test_claude_adapter.py +++ b/tests/adapters/test_claude_adapter.py @@ -684,6 +684,7 @@ async def test_runtime_reports_relay_artifacts(relay_payload, monkeypatch, tmp_p "atif": { "enabled": True, "output_directory": str(tmp_path / "atif"), + "filename_template": "trajectory-{session_id}.atif.json", } }, } From 76b93e68e32f6981d19d48907a5c13b9df39f4ba Mon Sep 17 00:00:00 2001 From: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com> Date: Tue, 28 Jul 2026 09:15:50 -0700 Subject: [PATCH 6/8] fix(release): restore 0.1 package versions Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com> --- Cargo.toml | 4 ++-- adapters/claude/pyproject.toml | 4 ++-- adapters/claude/uv.lock | 4 ++-- adapters/codex/pyproject.toml | 4 ++-- adapters/codex/uv.lock | 4 ++-- adapters/common/pyproject.toml | 2 +- adapters/common/uv.lock | 2 +- adapters/deepagents/pyproject.toml | 4 ++-- adapters/deepagents/uv.lock | 4 ++-- adapters/hermes/pyproject.toml | 4 ++-- adapters/hermes/uv.lock | 4 ++-- pyproject.toml | 16 ++++++++-------- uv.lock | 12 ++++++------ 13 files changed, 34 insertions(+), 34 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 5ec865432..fc77c16f8 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -14,13 +14,13 @@ default-members = [ resolver = "2" [workspace.package] -version = "0.2.0" +version = "0.1.0" edition = "2024" license = "Apache-2.0" repository = "https://github.com/NVIDIA/nemo-fabric" [workspace.dependencies] -nemo-fabric-core = { path = "crates/fabric-core", version = "0.2.0" } +nemo-fabric-core = { path = "crates/fabric-core", version = "0.1.0" } clap = { version = "4", default-features = false, features = ["derive", "std", "help", "usage", "error-context", "suggestions"] } schemars = { version = "1", features = ["derive"] } diff --git a/adapters/claude/pyproject.toml b/adapters/claude/pyproject.toml index f35222caa..f80d80986 100644 --- a/adapters/claude/pyproject.toml +++ b/adapters/claude/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric-adapters-claude" -version = "0.2.0" +version = "0.1.0" description = "Claude adapter for NeMo Fabric" authors = [ { name = "NVIDIA Corporation" }, @@ -25,7 +25,7 @@ license-files = ["LICENSE"] readme = "README.md" requires-python = ">=3.11" dependencies = [ - "nemo-fabric-adapters-common == 0.2.0", + "nemo-fabric-adapters-common == 0.1.0", "claude-agent-sdk==0.2.120", "tomli-w~=1.2", ] diff --git a/adapters/claude/uv.lock b/adapters/claude/uv.lock index b2b617547..012c18e12 100644 --- a/adapters/claude/uv.lock +++ b/adapters/claude/uv.lock @@ -350,7 +350,7 @@ wheels = [ [[package]] name = "nemo-fabric-adapters-claude" -version = "0.2.0" +version = "0.1.0" source = { editable = "." } dependencies = [ { name = "claude-agent-sdk" }, @@ -367,7 +367,7 @@ requires-dist = [ [[package]] name = "nemo-fabric-adapters-common" -version = "0.2.0" +version = "0.1.0" source = { editable = "../common" } [[package]] diff --git a/adapters/codex/pyproject.toml b/adapters/codex/pyproject.toml index 63b5d0752..7acd61c0f 100644 --- a/adapters/codex/pyproject.toml +++ b/adapters/codex/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric-adapters-codex" -version = "0.2.0" +version = "0.1.0" description = "Codex adapter for NeMo Fabric" authors = [ { name = "NVIDIA Corporation" }, @@ -25,7 +25,7 @@ license-files = ["LICENSE"] readme = "README.md" requires-python = ">=3.11" dependencies = [ - "nemo-fabric-adapters-common == 0.2.0", + "nemo-fabric-adapters-common == 0.1.0", "openai-codex==0.144.4", "tomli-w~=1.2", ] diff --git a/adapters/codex/uv.lock b/adapters/codex/uv.lock index b66fd4f11..a76f126a6 100644 --- a/adapters/codex/uv.lock +++ b/adapters/codex/uv.lock @@ -13,7 +13,7 @@ wheels = [ [[package]] name = "nemo-fabric-adapters-codex" -version = "0.2.0" +version = "0.1.0" source = { editable = "." } dependencies = [ { name = "nemo-fabric-adapters-common" }, @@ -30,7 +30,7 @@ requires-dist = [ [[package]] name = "nemo-fabric-adapters-common" -version = "0.2.0" +version = "0.1.0" source = { editable = "../common" } [[package]] diff --git a/adapters/common/pyproject.toml b/adapters/common/pyproject.toml index cd3b63302..e428d1d49 100644 --- a/adapters/common/pyproject.toml +++ b/adapters/common/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric-adapters-common" -version = "0.2.0" +version = "0.1.0" description = "Shared Python helpers for NeMo Fabric adapters" authors = [ { name = "NVIDIA Corporation" }, diff --git a/adapters/common/uv.lock b/adapters/common/uv.lock index b7d8656f9..a9e754d66 100644 --- a/adapters/common/uv.lock +++ b/adapters/common/uv.lock @@ -4,5 +4,5 @@ requires-python = ">=3.11" [[package]] name = "nemo-fabric-adapters-common" -version = "0.2.0" +version = "0.1.0" source = { editable = "." } diff --git a/adapters/deepagents/pyproject.toml b/adapters/deepagents/pyproject.toml index 433ba938c..ceb261b02 100644 --- a/adapters/deepagents/pyproject.toml +++ b/adapters/deepagents/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric-adapters-deepagents" -version = "0.2.0" +version = "0.1.0" description = "LangChain Deep Agents adapter for NeMo Fabric" authors = [ { name = "NVIDIA Corporation" }, @@ -25,7 +25,7 @@ license-files = ["LICENSE"] readme = "README.md" requires-python = ">=3.11" dependencies = [ - "nemo-fabric-adapters-common == 0.2.0", + "nemo-fabric-adapters-common == 0.1.0", "deepagents>=0.6.12,<0.7.0", "langchain>=1.3,<2.0", "langchain-mcp-adapters>=0.1,<0.3.0", diff --git a/adapters/deepagents/uv.lock b/adapters/deepagents/uv.lock index a55ddb68c..72d964e8c 100644 --- a/adapters/deepagents/uv.lock +++ b/adapters/deepagents/uv.lock @@ -834,12 +834,12 @@ wheels = [ [[package]] name = "nemo-fabric-adapters-common" -version = "0.2.0" +version = "0.1.0" source = { editable = "../common" } [[package]] name = "nemo-fabric-adapters-deepagents" -version = "0.2.0" +version = "0.1.0" source = { editable = "." } dependencies = [ { name = "deepagents" }, diff --git a/adapters/hermes/pyproject.toml b/adapters/hermes/pyproject.toml index d15d866c1..0cc58fb21 100644 --- a/adapters/hermes/pyproject.toml +++ b/adapters/hermes/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric-adapters-hermes" -version = "0.2.0" +version = "0.1.0" description = "Hermes Agent adapter for NeMo Fabric" authors = [ { name = "NVIDIA Corporation" }, @@ -26,7 +26,7 @@ readme = "README.md" # Hermes Agent does not currently support Python 3.14 or later. requires-python = ">=3.11,<3.14" dependencies = [ - "nemo-fabric-adapters-common == 0.2.0", + "nemo-fabric-adapters-common == 0.1.0", "pyyaml>=6.0", # needed for writing hermes config files ] diff --git a/adapters/hermes/uv.lock b/adapters/hermes/uv.lock index c2d5d663c..2809511b2 100644 --- a/adapters/hermes/uv.lock +++ b/adapters/hermes/uv.lock @@ -4,12 +4,12 @@ requires-python = ">=3.11, <3.14" [[package]] name = "nemo-fabric-adapters-common" -version = "0.2.0" +version = "0.1.0" source = { editable = "../common" } [[package]] name = "nemo-fabric-adapters-hermes" -version = "0.2.0" +version = "0.1.0" source = { editable = "." } dependencies = [ { name = "nemo-fabric-adapters-common" }, diff --git a/pyproject.toml b/pyproject.toml index 230b83d2b..0986794bc 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" [project] name = "nemo-fabric" -version = "0.2.0" +version = "0.1.0" description = "Python SDK distribution for NeMo Fabric" authors = [ { name = "NVIDIA Corporation" }, @@ -25,7 +25,7 @@ license-files = ["LICENSE"] readme = "pypi.md" requires-python = ">=3.11" dependencies = [ - "nemo-fabric-runtime == 0.2.0", + "nemo-fabric-runtime == 0.1.0", ] [project.urls] @@ -38,15 +38,15 @@ packages = [] [project.optional-dependencies] codex = [ - "nemo-fabric-adapters-codex == 0.2.0", + "nemo-fabric-adapters-codex == 0.1.0", ] claude = [ - "nemo-fabric-adapters-claude == 0.2.0", + "nemo-fabric-adapters-claude == 0.1.0", ] deepagents = [ - "nemo-fabric-adapters-deepagents == 0.2.0", + "nemo-fabric-adapters-deepagents == 0.1.0", ] harbor = [ @@ -55,11 +55,11 @@ harbor = [ ] hermes = [ - "nemo-fabric-adapters-hermes == 0.2.0; python_version < '3.14'", + "nemo-fabric-adapters-hermes == 0.1.0; python_version < '3.14'", ] hermes-agent = [ - "nemo-fabric-adapters-hermes == 0.2.0; python_version < '3.14'", + "nemo-fabric-adapters-hermes == 0.1.0; python_version < '3.14'", "hermes-agent>=0.17.0; python_version < '3.14'", ] @@ -69,7 +69,7 @@ relay = [ ] runtime = [ - "nemo-fabric-runtime == 0.2.0", + "nemo-fabric-runtime == 0.1.0", ] [dependency-groups] diff --git a/uv.lock b/uv.lock index d7cc43548..b42dde975 100644 --- a/uv.lock +++ b/uv.lock @@ -2047,7 +2047,7 @@ wheels = [ [[package]] name = "nemo-fabric" -version = "0.2.0" +version = "0.1.0" source = { editable = "." } dependencies = [ { name = "nemo-fabric-runtime" }, @@ -2169,7 +2169,7 @@ test = [ [[package]] name = "nemo-fabric-adapters-claude" -version = "0.2.0" +version = "0.1.0" source = { editable = "adapters/claude" } dependencies = [ { name = "claude-agent-sdk" }, @@ -2186,7 +2186,7 @@ requires-dist = [ [[package]] name = "nemo-fabric-adapters-codex" -version = "0.2.0" +version = "0.1.0" source = { editable = "adapters/codex" } dependencies = [ { name = "nemo-fabric-adapters-common" }, @@ -2203,12 +2203,12 @@ requires-dist = [ [[package]] name = "nemo-fabric-adapters-common" -version = "0.2.0" +version = "0.1.0" source = { editable = "adapters/common" } [[package]] name = "nemo-fabric-adapters-deepagents" -version = "0.2.0" +version = "0.1.0" source = { editable = "adapters/deepagents" } dependencies = [ { name = "deepagents" }, @@ -2240,7 +2240,7 @@ provides-extras = ["relay"] [[package]] name = "nemo-fabric-adapters-hermes" -version = "0.2.0" +version = "0.1.0" source = { editable = "adapters/hermes" } dependencies = [ { name = "nemo-fabric-adapters-common", marker = "python_full_version < '3.14'" }, From 825c5ffddc64a4eddbda2ddb3a71860878c8e460 Mon Sep 17 00:00:00 2001 From: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com> Date: Tue, 28 Jul 2026 09:15:50 -0700 Subject: [PATCH 7/8] fix(relay): treat ATIF templates literally Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com> --- .../src/nemo_fabric_adapters/common/utils.py | 3 ++- tests/adapters/test_adapaters_common_utils.py | 27 +++++++++++++++++++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/adapters/common/src/nemo_fabric_adapters/common/utils.py b/adapters/common/src/nemo_fabric_adapters/common/utils.py index 5567e43a1..5484cc235 100644 --- a/adapters/common/src/nemo_fabric_adapters/common/utils.py +++ b/adapters/common/src/nemo_fabric_adapters/common/utils.py @@ -5,6 +5,7 @@ from __future__ import annotations +import glob import json import os import sys @@ -342,7 +343,7 @@ def collect_relay_artifacts(plugin_config: dict[str, Any]) -> list[dict[str, str template = atif.get("filename_template") if not isinstance(template, str) or not template: continue - pattern = template.replace("{session_id}", "*") + pattern = glob.escape(template).replace("{session_id}", "*") for path in _artifact_glob(directory, pattern): resolved = _artifact_file(path, directory=directory) if resolved is not None: diff --git a/tests/adapters/test_adapaters_common_utils.py b/tests/adapters/test_adapaters_common_utils.py index e911c85f7..053b9ff1d 100644 --- a/tests/adapters/test_adapaters_common_utils.py +++ b/tests/adapters/test_adapaters_common_utils.py @@ -439,6 +439,33 @@ def test_collect_relay_artifacts_requires_valid_atif_filename_template( assert common_utils.collect_relay_artifacts(plugin_config) == [] +def test_collect_relay_artifacts_treats_atif_template_as_literal(tmp_path: Path): + atif_dir = tmp_path / "atif" + atif_dir.mkdir() + configured = atif_dir / "[team]-session.json" + unrelated = atif_dir / "t-session.json" + configured.write_text("{}", encoding="utf-8") + unrelated.write_text("{}", encoding="utf-8") + plugin_config = { + "components": [ + { + "kind": "observability", + "config": { + "atif": { + "enabled": True, + "output_directory": str(atif_dir), + "filename_template": "[team]-{session_id}.json", + } + }, + } + ] + } + + assert common_utils.collect_relay_artifacts(plugin_config) == [ + {"kind": "atif", "path": str(configured)} + ] + + def test_collect_relay_artifacts_ignores_missing_output_directories( tmp_path: Path, monkeypatch: pytest.MonkeyPatch, From 5aac36226ced34dc7832a1afc0f92ed626b9bb66 Mon Sep 17 00:00:00 2001 From: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com> Date: Tue, 28 Jul 2026 09:21:10 -0700 Subject: [PATCH 8/8] test(ci): compare scaffold paths by identity Signed-off-by: Anuradha Karuppiah <26330987+AnuradhaKaruppiah@users.noreply.github.com> --- tests/e2e/test_cli_scaffold.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/e2e/test_cli_scaffold.py b/tests/e2e/test_cli_scaffold.py index 8d6d9e3d6..a22841de4 100644 --- a/tests/e2e/test_cli_scaffold.py +++ b/tests/e2e/test_cli_scaffold.py @@ -70,7 +70,7 @@ def test_generated_rust_scaffold_builds(tmp_path: Path): manifest = (destination / "Cargo.toml").read_text() assert "[workspace]" in manifest core_dependency = tomllib.loads(manifest)["dependencies"]["nemo-fabric-core"] - assert Path(core_dependency["path"]) == ROOT / "crates/fabric-core" + assert Path(core_dependency["path"]).samefile(ROOT / "crates/fabric-core") expected_version = tomllib.loads((ROOT / "Cargo.toml").read_text())["workspace"][ "package" ]["version"]