Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Hard code labels for the quality and domain classifier #71

Closed
VibhuJawa opened this issue May 20, 2024 · 0 comments · Fixed by #166
Closed

[IMP] Hard code labels for the quality and domain classifier #71

VibhuJawa opened this issue May 20, 2024 · 0 comments · Fixed by #166
Assignees
Labels
enhancement New feature or request

Comments

@VibhuJawa
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

We should prevent feeding in labels to DomainClassifier , Quality Classifier at every initialization of these classifiers.

@ryantwolf , mentioned that the labels are fixed for each classifier right, as in they can't be reordered or altered on-demand and suggested that we should probably refactor this so that the labels are just hardcoded into the DomainClassifier and QualityClassifier so the user doesn't have to manually enter in the labels each time. It would then be good to also add in the docstring of the constructor for each class what the possible options for the filter_by parameter would be.

See link: #58 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment