Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add test_read_data_different_columns_blocksize #557

Open
sarahyurick opened this issue Feb 18, 2025 · 0 comments · May be fixed by #558
Open

Re-add test_read_data_different_columns_blocksize #557

sarahyurick opened this issue Feb 18, 2025 · 0 comments · May be fixed by #558
Assignees
@praateekmahajan
Labels
bug Something isn't working

Comments

@sarahyurick
Copy link
Collaborator

In #555, I added a skip to test_read_data_different_columns_blocksize because the following tests were failing:

2025-02-18T18:26:34.4124241Z FAILED NeMo-Curator/tests/test_read_data.py::test_read_data_different_columns_blocksize[1kb-cudf-parquet]
2025-02-18T18:26:34.4124903Z FAILED NeMo-Curator/tests/test_read_data.py::test_read_data_different_columns_blocksize[5kb-cudf-parquet]
2025-02-18T18:26:34.4125561Z FAILED NeMo-Curator/tests/test_read_data.py::test_read_data_different_columns_blocksize[10kb-cudf-parquet]

with a KeyError: 'Column meta1 does not exist in schema'.

The test was originally created in #285, which has some version dependencies, so the error might be because of that?
@sarahyurick sarahyurick added the bug Something isn't working label Feb 18, 2025
@sarahyurick sarahyurick linked a pull request Feb 18, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@praateekmahajan praateekmahajan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove minhash conditional for 25.02 praateekmahajan/NeMo-Curator
2 participants
@praateekmahajan @sarahyurick