Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_all_files_paths_under documentation #378

Open
sarahyurick opened this issue Nov 18, 2024 · 0 comments · May be fixed by #450
Open

Update get_all_files_paths_under documentation #378

sarahyurick opened this issue Nov 18, 2024 · 0 comments · May be fixed by #450
Assignees
@sarahyurick
Labels
documentation Improvements or additions to documentation

Comments

@sarahyurick
Copy link
Collaborator

sarahyurick commented Nov 18, 2024 •
edited
Loading

Suggestion from Ayush about #318: "As a follow up, it might make sense to track updating tutorials/notebooks to use this newer filter argument in the API."

Examples:
(1)

input_files = get_all_files_paths_under(in_files, keep_extensions="jsonl")
input_dataset = DocumentDataset.read_json(input_files)

(2)

input_files = get_all_files_paths_under(in_files, keep_extensions=["jsonl"])
input_dataset = DocumentDataset.read_json(input_files)

(3)

# Returns a list containing only .jsonl, .parquet, and .csv files
input_files = get_all_files_paths_under(in_files, keep_extensions=["jsonl", "parquet", "csv"])
@sarahyurick sarahyurick added the documentation Improvements or additions to documentation label Nov 18, 2024
@sarahyurick sarahyurick self-assigned this Nov 18, 2024
@sarahyurick sarahyurick changed the title Update columns documentation Update get_all_files_paths_under documentation Dec 20, 2024
@sarahyurick sarahyurick linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahyurick sarahyurick

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update get_all_files_paths_under examples to include keep_extensions sarahyurick/NeMo-Curator
1 participant
@sarahyurick