Move configurable parameters from env vars to config file #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hsin Chen <[email protected]>
Signed-off-by: Hsin Chen <[email protected]>
Signed-off-by: Hsin Chen <[email protected]>
Contributor
|
/ok to test 76c42c0 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates configurable parameters from environment variables to a configuration file, streamlining parameter management and improving consistency. Key changes include:
- Replacing environment variable dependency with explicit config parameters in multiple modules.
- Updating utility functions to preload and retrieve test data using the new config values.
- Reflecting these changes in the workflow configuration and documentation.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utils.py | Refactored functions to preload and retrieve test data using explicit config paths and removed dependency on env vars |
| telemetry_metrics_*_check_tool.py, network_connectivity_check_tool.py, host_performance_check_tool.py, hardware_check_tool.py, monitoring_process_check_tool.py | Updated to use config.test_mode and get_test_data instead of environment variable–driven functions |
| register.py | Updated field types and added new config parameters for test mode and test data paths |
| config.yml | Added test_mode and path parameters for each tool and workflow |
| README.md | Updated documentation to reflect the new configuration approach |
Files not reviewed (1)
- examples/alert_triage_agent/.env_example: Language not supported
examples/alert_triage_agent/src/aiq_alert_triage_agent/maintenance_check.py
Show resolved
Hide resolved
...ert_triage_agent/src/aiq_alert_triage_agent/telemetry_metrics_host_performance_check_tool.py
Show resolved
Hide resolved
Signed-off-by: Hsin Chen <[email protected]>
Contributor
|
/ok to test 8177eaf |
dagardner-nv
added
improvement
dagardner-nv
approved these changes
May 7, 2025
Contributor
dagardner-nv
left a comment
dagardner-nv
left a comment
There was a problem hiding this comment.
LGTM, just a question
examples/alert_triage_agent/src/aiq_alert_triage_agent/configs/config.yml
Show resolved
Hide resolved
...ert_triage_agent/src/aiq_alert_triage_agent/telemetry_metrics_host_performance_check_tool.py
Show resolved
Hide resolved
AnuradhaKaruppiah
approved these changes
May 7, 2025
Signed-off-by: Hsin Chen <[email protected]>
hsin-c
force-pushed
the
hsinc-213-ata-move-params-to-config
branch
from
a36faaa to
443ec27
Compare
Contributor
|
/ok to test 443ec27 |
2 tasks
Contributor
|
/merge |
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
May 8, 2025
This PR moves the parameters used by the model in the environment variables to the config file for easier parameter tracking. Closes NVIDIA#213 Tested offline and validated the generation of an expected output file. Authors: - https://github.com/hsin-c Approvers: - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#222 Signed-off-by: Yuchen Zhang <[email protected]>
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
May 9, 2025
This PR moves the parameters used by the model in the environment variables to the config file for easier parameter tracking. Closes NVIDIA#213 Tested offline and validated the generation of an expected output file. Authors: - https://github.com/hsin-c Approvers: - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#222 Signed-off-by: Yuchen Zhang <[email protected]>
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
May 9, 2025
This PR moves the parameters used by the model in the environment variables to the config file for easier parameter tracking. Closes NVIDIA#213 Tested offline and validated the generation of an expected output file. Authors: - https://github.com/hsin-c Approvers: - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#222
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
May 9, 2025
This PR moves the parameters used by the model in the environment variables to the config file for easier parameter tracking. Closes NVIDIA#213 Tested offline and validated the generation of an expected output file. Authors: - https://github.com/hsin-c Approvers: - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#222 Signed-off-by: Yuchen Zhang <[email protected]>
yczhang-nv
pushed a commit
to yczhang-nv/NeMo-Agent-Toolkit
that referenced
this pull request
May 9, 2025
This PR moves the parameters used by the model in the environment variables to the config file for easier parameter tracking. Closes NVIDIA#213 Tested offline and validated the generation of an expected output file. Authors: - https://github.com/hsin-c Approvers: - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#222 Signed-off-by: Yuchen Zhang <[email protected]>
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Jun 3, 2025
This PR moves the parameters used by the model in the environment variables to the config file for easier parameter tracking. Closes NVIDIA#213 Tested offline and validated the generation of an expected output file. Authors: - https://github.com/hsin-c Approvers: - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#222 Signed-off-by: Eric Evans <[email protected]>
ericevans-nv
pushed a commit
to ericevans-nv/agent-iq
that referenced
this pull request
Jun 3, 2025
This PR moves the parameters used by the model in the environment variables to the config file for easier parameter tracking. Closes NVIDIA#213 Tested offline and validated the generation of an expected output file. Authors: - https://github.com/hsin-c Approvers: - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#222 Signed-off-by: Eric Evans <[email protected]>
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
This PR moves the parameters used by the model in the environment variables to the config file for easier parameter tracking. Closes NVIDIA#213 Tested offline and validated the generation of an expected output file. Authors: - https://github.com/hsin-c Approvers: - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#222
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
This PR moves the parameters used by the model in the environment variables to the config file for easier parameter tracking. Closes NVIDIA#213 Tested offline and validated the generation of an expected output file. Authors: - https://github.com/hsin-c Approvers: - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: NVIDIA#222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the parameters used by the model in the environment variables to the config file for easier parameter tracking.
Closes #213
Tested offline and validated the generation of an expected output file.