-
Notifications
You must be signed in to change notification settings - Fork 416
Update fastapi version #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fastapi version #1117
Conversation
WalkthroughUpdated the FastAPI dependency version constraint in pyproject.toml from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (3){**/*.py,**/*.sh,**/*.md,**/*.toml,**/*.y?(a)ml,**/*.json,**/*.txt,**/*.ini,**/*.cfg,**/*.ipynb}📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Files:
{**/pyproject.toml,uv.lock}📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Files:
**/*⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Anuradha Karuppiah <[email protected]>
1af056c to
651571d
Compare
|
/merge |
This PR updates and documents an extensibility feature in the `NeMo Agent Toolkit` that allows developers to create custom MCP server workers by subclassing MCPFrontEndPluginWorker. Developers can now extend MCPFrontEndPluginWorker to implement custom authentication, middleware, telemetry, or transport logic. Note: The fast api change in #1117 will be merged before this PR ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **New Features** * Mount MCP server at custom URL paths via new base_path config (validated); SSE is routed at /sse and streamable-http supports mounting at base_path/mcp with updated startup behavior and logs. * Pluggable MCP server workers: server creation and route registration are now extensible; optional authentication can be enabled for MCP servers. * **Documentation** * New guide for creating/registering custom MCP server workers and docs with mounting-at-path examples and transport compatibility notes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: #1087
Description
Closes
By Submitting this PR I confirm:
Summary by CodeRabbit