Merge branch 'develop' into feature/cross-workflow-observability

Author: pira998

.coderabbit.yaml

@@ -28,6 +28,7 @@ reviews:
     issue_assessment:
       mode: warning
   auto_review:
+    base_branches: ["develop", "release/.*"]
     enabled: true
     drafts: false
     auto_incremental_review: true

.cursor/rules/general.mdc

@@ -43,7 +43,7 @@ These are the overarching standards that every **source, test, documentation and
   - The `pyproject.toml` should declare a dependency on `nvidia-nat` or another package with a name starting with `nvidia-nat-`.
   - Dependencies should use `~=<version>` format with two-digit versions (e.g., `~=1.0`).
   - If packages contain Python code, they should have tests in a `tests/` directory at the same level as `pyproject.toml`.
-- Unit tests live in `tests/` (or `examples/*/tests`) and use the markers defined in `pyproject.toml` (e.g. `e2e`, `integration`).
+- Unit tests live in `tests/` (or `examples/*/tests`) and use the markers defined in `pyproject.toml` (e.g. `integration`).
 - Documentation sources are Markdown files under `docs/source`. Image files should be placed in `docs/source/_static` directory.
 - Configuration files consumed by code are stored next to that code in a `configs/` folder.
 - Large / binary assets **must** be committed with Git-LFS and placed in a neighbouring `data/` folder.

.cursor/rules/nat-workflows/add-functions.mdc

@@ -161,8 +161,8 @@ class MyCompositeConfig(FunctionBaseConfig, name="my_composite_function"):
 @register_function(config_type=MyCompositeConfig)
 async def register_composite_function(config: MyCompositeConfig, builder: Builder):
     """Registers a function that calls two other functions."""
-    func1 = builder.get_function(config.first_function)
-    func2 = builder.get_function(config.second_function)
+    func1 = await builder.get_function(config.first_function)
+    func2 = await builder.get_function(config.second_function)
 
     async def _composite_function(data: str) -> str:
         res1 = await func1.ainvoke(data)

.gitlab-ci.yml

@@ -39,6 +39,8 @@ variables:
   GIT_SUBMODULE_FORCE_HTTPS: "true"
   GIT_SUBMODULE_STRATEGY: recursive
   MYSQL_ROOT_PASSWORD: "${MYSQL_ROOT_PASSWORD}"
+  NAT_CI_ETCD_HOST: "etcd"
+  NAT_CI_MILVUS_HOST: "milvus"
   NAT_CI_MYSQL_HOST: "mysql"
   NAT_CI_REDIS_HOST: "redis"
   NAT_CI_S3_HOST: "minio"
@@ -76,11 +78,23 @@ check:style:
 test:python_tests:
   stage: test
   services:
-    - mysql:9.3
     - name: minio/minio:RELEASE.2025-07-18T21-56-31Z
       alias: minio
       command: ["server", "/data", "--console-address", ":9001"]
+    - mysql:9.3
+    - name: arizephoenix/phoenix:latest
+      alias: phoenix
     - redis:7-alpine
+    - name: quay.io/coreos/etcd:v3.5.5
+      alias: etcd
+      command: ["etcd", "--advertise-client-urls", "http://0.0.0.0:2379", "--listen-client-urls", "http://0.0.0.0:2379"]
+    - name: milvusdb/milvus:v2.3.1
+      alias: milvus
+      variables:
+        ETCD_ENDPOINTS: etcd:2379
+        MINIO_ADDRESS: minio:9000
+      command: ["milvus", "run", "standalone"]
+
   script:
     - echo "Running tests"
     - ./ci/scripts/gitlab/tests.sh

README.md

@@ -81,13 +81,13 @@ pip install nvidia-nat
 NeMo Agent Toolkit has many optional dependencies which can be installed with the core package. Optional dependencies are grouped by framework and can be installed with the core package. For example, to install the LangChain/LangGraph plugin, run the following:
 
 ```bash
-pip install nvidia-nat[langchain]
+pip install "nvidia-nat[langchain]"
 ```
 
 Or for all optional dependencies:
 
 ```bash
-pip install nvidia-nat[all]
+pip install "nvidia-nat[all]"
 ```
 
 The full list of optional dependencies can be found [here](./docs/source/quick-start/installing.md#framework-integrations).

ci/markdown-link-check-config.json

@@ -14,6 +14,9 @@
         },
         {
             "pattern": "^https://www\\.mysql\\.com"
+        },
+        {
+            "pattern": "^https://arize\\.com"
         }
     ]
 }

ci/release/update_doc_versions1.py

@@ -26,7 +26,7 @@ def main(versions_file: str, new_version: str):
     if new_version.count('.') != 1:
         raise ValueError("Version string must only include <major>.<minor>")
 
-    with open(versions_file, "r", encoding="utf-8") as fh:
+    with open(versions_file, encoding="utf-8") as fh:
         version_list = json.load(fh)
 
     for version_data in version_list:

ci/release/update_toml_dep.py

@@ -41,7 +41,7 @@ def main(toml_file_path: str, new_version: str, package_name: str, version_match
     version_match : str
         Version match specifier to use for the dependency.
     """
-    with open(toml_file_path, "r", encoding="utf-8") as fh:
+    with open(toml_file_path, encoding="utf-8") as fh:
         toml_data = tomlkit.load(fh)
 
     toml_project: tomlkit.items.Table = toml_data['project']

ci/scripts/common.sh

@@ -178,8 +178,6 @@ function get_lfs_files() {
     if [[ "${USE_HOST_GIT}" == "1" ]]; then
         rapids-logger "Using host git, skipping git-lfs install"
     else
-        rapids-logger "Fetching LFS files"
-        git lfs install
         rapids-logger "Calling git lfs fetch"
         git lfs fetch
         rapids-logger "Calling git lfs pull"

ci/scripts/copyright.py

@@ -17,7 +17,6 @@
 
 import argparse
 import datetime
-import io
 import logging
 import os
 import re
@@ -90,7 +89,7 @@ def replace_current_year(line, start, end):
     # first turn a simple regex into double (if applicable). then update years
     res = CheckSimple.sub(r"Copyright (c) \1-\1, NVIDIA CORPORATION", line)
 
-    res = CheckDouble.sub(r"Copyright (c) {:04d}-{:04d}, NVIDIA CORPORATION".format(start, end), res)
+    res = CheckDouble.sub(rf"Copyright (c) {start:04d}-{end:04d}, NVIDIA CORPORATION", res)
     return res
 
 
@@ -137,7 +136,7 @@ def check_copyright(f,
     cr_found = False
     apache_lic_found = not verify_apache_v2
     year_matched = False
-    with io.open(f, "r", encoding="utf-8") as file:
+    with open(f, encoding="utf-8") as file:
         lines = file.readlines()
     for line in lines:
         line_num += 1
@@ -213,7 +212,7 @@ def check_copyright(f,
             logger.info("File: %s. Changing line(s) %s", f, ', '.join(str(x[1]) for x in errs if x[-1] is not None))
             for _, line_num, __, replacement in errs_update:
                 lines[line_num - 1] = replacement
-            with io.open(f, "w", encoding="utf-8") as out_file:
+            with open(f, "w", encoding="utf-8") as out_file:
                 for new_line in lines:
                     out_file.write(new_line)