Move Compress dependencies to setup.py#539
Merged
kevalmorabia97 merged 7 commits intoNov 12, 2025
Merged
Conversation
## What does this PR do? **Type of change:** Documentation **Overview:** Updated the tutorial with more details on how to choose the required config parameters and added MMLU evaluation. --------- Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
LianaMikael
requested review from
RalphMao,
danielkorzekwa and
kevalmorabia97
and removed request for
a team
kevalmorabia97
approved these changes
Nov 12, 2025
| "wandb~=0.17.5", | ||
| "frozendict>=2.4.4", | ||
| "lru-dict", | ||
| "mip", |
Collaborator
There was a problem hiding this comment.
mip installation fails in the pytorch docker container: https://github.com/NVIDIA/TensorRT-Model-Optimizer/actions/runs/19281849124/job/55134742589?pr=539#step:7:591
Does it need any additional linux dependencies?
Contributor
There was a problem hiding this comment.
Maybe wrong base docker container is used? it works with: https://github.com/NVIDIA/TensorRT-Model-Optimizer/blob/dkorzekwa/compress_tutorial/examples/compress/Dockerfile
Collaborator
There was a problem hiding this comment.
I checked. We need to apt install libffi-dev before we pip install mip
Collaborator
There was a problem hiding this comment.
Lets remove frozendict and mip from this list and we will deal with them when we move other components
danielkorzekwa
approved these changes
Nov 12, 2025
LianaMikael
force-pushed
the
dkorzekwa/compress_tutorial
branch
from
bb91d73 to
59d0b46
Compare
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
kevalmorabia97
approved these changes
Nov 12, 2025
…kerfile-compress Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
kevalmorabia97
merged this pull request
into
dkorzekwa/compress_tutorial
3 of 6 checks passed
kevalmorabia97
added a commit
that referenced
this pull request
Nov 12, 2025
**Type of change:** Documentation **Overview:** Replace Dockerfile for Puzzletron compression with dependencies in `setup.py` --------- Signed-off-by: Liana Mikaelyan <45925959+LianaMikael@users.noreply.github.com> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com> Co-authored-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Documentation
Overview: Replace Dockerfile for Puzzletron compression with dependencies in
setup.py