From 5447886d3341d95263d1af99811a2a79e658dcb9 Mon Sep 17 00:00:00 2001 From: Ian Zhang Date: Mon, 2 Feb 2026 18:40:14 -0800 Subject: [PATCH 1/6] [None][Fix] Prevent resource leak warnings Warning: WARNING: destroy_process_group() was not called before program exit which can leak resources. For more info When compiler_helpers() function failed to complete the subprocess --- megatron/core/datasets/utils.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/megatron/core/datasets/utils.py b/megatron/core/datasets/utils.py index e14656df799..b5e2753df3b 100644 --- a/megatron/core/datasets/utils.py +++ b/megatron/core/datasets/utils.py @@ -27,6 +27,10 @@ def compile_helpers(): import sys log_single_rank(logger, logging.ERROR, "Failed to compile the C++ dataset helper functions") + import torch + import torch.distributed as dist + dist.destroy_process_group() + sys.exit(1) From bbe2c64af72000c6af757dca62149eb12224546f Mon Sep 17 00:00:00 2001 From: Xin Yao Date: Thu, 5 Feb 2026 15:27:27 +0800 Subject: [PATCH 2/6] Update utils.py --- megatron/core/datasets/utils.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/megatron/core/datasets/utils.py b/megatron/core/datasets/utils.py index b5e2753df3b..43622c8f755 100644 --- a/megatron/core/datasets/utils.py +++ b/megatron/core/datasets/utils.py @@ -25,12 +25,11 @@ def compile_helpers(): command = ["make", "-C", os.path.abspath(os.path.dirname(__file__))] if subprocess.run(command).returncode != 0: import sys + import torch.distributed as dist log_single_rank(logger, logging.ERROR, "Failed to compile the C++ dataset helper functions") - import torch - import torch.distributed as dist - dist.destroy_process_group() + dist.destroy_process_group() sys.exit(1) From 7be50647caf18f40056288c9ab518b2be86b0c99 Mon Sep 17 00:00:00 2001 From: Xin Yao Date: Mon, 9 Feb 2026 09:28:41 +0800 Subject: [PATCH 3/6] Update utils.py --- megatron/core/datasets/utils.py | 1 + 1 file changed, 1 insertion(+) diff --git a/megatron/core/datasets/utils.py b/megatron/core/datasets/utils.py index 43622c8f755..e2be1f02fa9 100644 --- a/megatron/core/datasets/utils.py +++ b/megatron/core/datasets/utils.py @@ -25,6 +25,7 @@ def compile_helpers(): command = ["make", "-C", os.path.abspath(os.path.dirname(__file__))] if subprocess.run(command).returncode != 0: import sys + import torch.distributed as dist log_single_rank(logger, logging.ERROR, "Failed to compile the C++ dataset helper functions") From 9c8366fe27cd5ec5dc7e568c8be5055562030ff5 Mon Sep 17 00:00:00 2001 From: Xin Yao Date: Mon, 9 Feb 2026 09:31:38 +0800 Subject: [PATCH 4/6] Update utils.py --- megatron/core/datasets/utils.py | 1 + 1 file changed, 1 insertion(+) diff --git a/megatron/core/datasets/utils.py b/megatron/core/datasets/utils.py index e2be1f02fa9..d1e2e400360 100644 --- a/megatron/core/datasets/utils.py +++ b/megatron/core/datasets/utils.py @@ -12,6 +12,7 @@ class Split(Enum): + """Enum train, valid, and test split." train = 0 valid = 1 test = 2 From 2ffbdd6bf4c87453c730c8286cd1ecf05657b847 Mon Sep 17 00:00:00 2001 From: Xin Yao Date: Mon, 9 Feb 2026 09:38:51 +0800 Subject: [PATCH 5/6] Update utils.py --- megatron/core/datasets/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/megatron/core/datasets/utils.py b/megatron/core/datasets/utils.py index d1e2e400360..a1241d8b482 100644 --- a/megatron/core/datasets/utils.py +++ b/megatron/core/datasets/utils.py @@ -12,7 +12,7 @@ class Split(Enum): - """Enum train, valid, and test split." + """Enum train, valid, and test split.""" train = 0 valid = 1 test = 2 From 5833bce47545eab70c8b49179fc4968d6c40ac3a Mon Sep 17 00:00:00 2001 From: Xin Yao Date: Mon, 9 Feb 2026 10:21:14 +0800 Subject: [PATCH 6/6] Update utils.py --- megatron/core/datasets/utils.py | 1 + 1 file changed, 1 insertion(+) diff --git a/megatron/core/datasets/utils.py b/megatron/core/datasets/utils.py index a1241d8b482..26cf5253179 100644 --- a/megatron/core/datasets/utils.py +++ b/megatron/core/datasets/utils.py @@ -13,6 +13,7 @@ class Split(Enum): """Enum train, valid, and test split.""" + train = 0 valid = 1 test = 2