Repository navigation
feat(deployments): reconcile controller and prerequisite DAG (AIRCORE-758) #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tylersbray
merged 4 commits into
main
from
758-deployments-reconciler-prerequisite-dag/tbray
Jun 25, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3c78be4
feat(deployments): add reconcile controller and prerequisite DAG (#758)
tylersbray e2c1f5b
fix(deployments): address remaining PR #315 CodeRabbit review items
tylersbray a1c9de4
chore(deployments): regenerate plugin OpenAPI spec for drift recovery…
tylersbray d036a92
fix(deployments): address PR #315 review feedback from benmccown and …
tylersbray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,24 @@ | ||
| # NeMo Deployments Plugin | ||
|
|
||
| Substrate-agnostic deployment lifecycle for the NeMo Platform: entity schemas, | ||
| CRUD APIs, a `DeploymentBackend` ABC, and an executor registry. | ||
| Backend-agnostic deployment lifecycle for the NeMo Platform: entity schemas, | ||
| CRUD APIs, a `DeploymentBackend` ABC, an executor registry, and a background | ||
| reconcile controller (`DeploymentsController`). | ||
|
|
||
| ## Tests | ||
| ## Controller | ||
|
|
||
| ```bash | ||
| uv sync | ||
| uv run pytest plugins/nemo-deployments/tests/unit -v | ||
| ``` | ||
| Register `DeploymentsController` via the `nemo.controllers` entry point. The controller | ||
| paginates non-terminal deployment/volume lists, reconciles volumes before deployments, | ||
| gates deployment create on mounted volumes reaching `BOUND`, and writes status via the | ||
| entity client (including endpoints and status history). Orphan backend resource cleanup | ||
| runs on a configurable interval and is skipped when the deployment list is unhealthy. | ||
|
|
||
| The controller exposes `is_healthy`, which is `False` when either the deployment-list or | ||
| volume-list query fails. Internally these are tracked separately so operators can tell | ||
| which list query failed without losing that signal behind a single boolean. | ||
|
|
||
| Per-config drift backoff overrides live on `DeploymentConfig.driftRecovery`; unset fields | ||
| fall back to `DeploymentsConfig.controller`. | ||
|
|
||
| Prerequisites are currently declared on `DeploymentConfig` and resolve to a single | ||
| deployment per config name in a workspace. Multiple deployments sharing one config is | ||
| unsupported until prerequisites move to the `Deployment` entity (follow-up work). |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.