From 6865196ad832ac9691a6e1abeb0950f32fef8741 Mon Sep 17 00:00:00 2001 From: Brooke Storm Date: Thu, 21 May 2026 09:28:16 -0700 Subject: [PATCH 1/2] docs: add dco workflow information to CI readme Signed-off-by: Brooke Storm --- .github/CI_README.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/CI_README.md b/.github/CI_README.md index 882e193aef0..696d5695212 100644 --- a/.github/CI_README.md +++ b/.github/CI_README.md @@ -24,12 +24,14 @@ reusable actions, and supporting docs. - `studio-ci.yaml` Frontend/Studio CI workflow. -- `gpu-test.yaml` - GPU integration test workflow. - - `semantic-pull-requests.yaml` Pull request title validation. +- `dco-assistant.yml` + Developer Certificate of Origin (DCO) assistant. It checks pull request + comments for the configured DCO sign-off text and stores accepted signatures + in `dco-signatures.json` on the separate `signatures` branch. + ### Deployment and Release Workflows - `release*.yaml` From 4c2a2a8e2ba19e69c50de373d8361b3aac2c08ba Mon Sep 17 00:00:00 2001 From: Brooke Storm Date: Thu, 21 May 2026 09:37:56 -0700 Subject: [PATCH 2/2] chore: remove the ci workflow instead Signed-off-by: Brooke Storm --- .github/CI_README.md | 11 +++--- .github/workflows/dco-assistant.yml | 58 ----------------------------- 2 files changed, 6 insertions(+), 63 deletions(-) delete mode 100644 .github/workflows/dco-assistant.yml diff --git a/.github/CI_README.md b/.github/CI_README.md index 696d5695212..5d37652c2dd 100644 --- a/.github/CI_README.md +++ b/.github/CI_README.md @@ -27,13 +27,14 @@ reusable actions, and supporting docs. - `semantic-pull-requests.yaml` Pull request title validation. -- `dco-assistant.yml` - Developer Certificate of Origin (DCO) assistant. It checks pull request - comments for the configured DCO sign-off text and stores accepted signatures - in `dco-signatures.json` on the separate `signatures` branch. - ### Deployment and Release Workflows - `release*.yaml` Nightly, RC, and stable release orchestration. These consume a reusable workflow file to minimize duplication. + +## GitHub Apps + +- DCO app + Developer Certificate of Origin (DCO) checks are handled by the installed DCO + app, not by a repository workflow. diff --git a/.github/workflows/dco-assistant.yml b/.github/workflows/dco-assistant.yml deleted file mode 100644 index a8f80ff19ce..00000000000 --- a/.github/workflows/dco-assistant.yml +++ /dev/null @@ -1,58 +0,0 @@ -# Copyright (c) 2025-2026, NVIDIA CORPORATION. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -name: "DCO Assistant" - -on: - issue_comment: - types: [created] - pull_request_target: - types: [opened, closed, synchronize] - -permissions: - actions: write - contents: write - pull-requests: write - statuses: write - -jobs: - DCOAssistant: - if: github.repository_owner == 'NVIDIA-NeMo' - runs-on: ubuntu-latest - steps: - - name: "DCO Assistant" - if: | - github.event.comment.body == 'recheck' || - github.event.comment.body == 'I have read the DCO document, and I hereby sign the DCO.' || - github.event_name == 'pull_request_target' - uses: contributor-assistant/github-action@ca4a40a7d1004f18d9960b404b97e5f30a505a08 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - PERSONAL_ACCESS_TOKEN: ${{ secrets.DCO_ASSISTANT_TOKEN }} - with: - path-to-signatures: "dco-signatures.json" - path-to-document: "https://github.com/NVIDIA-NeMo/nemo-platform/blob/main/DCO" - branch: "signatures" - allowlist: dependabot - create-file-commit-message: "chore: create file to store dco signatures" - signed-commit-message: "chore: $contributorName has signed the dco in #$pullRequestNo" - custom-notsigned-prcomment: | - Thank you for your submission! We ask that $you sign our - [Developer Certificate of Origin](https://github.com/NVIDIA-NeMo/nemo-platform/blob/main/DCO) - before we can accept your contribution. - - You can sign the DCO by adding a comment below using this text: - custom-pr-sign-comment: "I have read the DCO document, and I hereby sign the DCO." - lock-pullrequest-aftermerge: false - use-dco-flag: true