From 58f8d9976c7d9e1a7444305857de5cd319d8bdf6 Mon Sep 17 00:00:00 2001 From: Charlie Truong Date: Tue, 2 Dec 2025 11:21:07 -0600 Subject: [PATCH 1/5] Debug Signed-off-by: Charlie Truong --- nemo_skills/file_utils.py | 1 + 1 file changed, 1 insertion(+) diff --git a/nemo_skills/file_utils.py b/nemo_skills/file_utils.py index fa271bc0d6..00905a9e8e 100644 --- a/nemo_skills/file_utils.py +++ b/nemo_skills/file_utils.py @@ -42,6 +42,7 @@ def _make_w_io_base(f, mode: str): f: A file path or an IOBase object. mode: Mode for opening the file (default is write mode). """ + print("This is a test") if not isinstance(f, io.IOBase): f_dirname = os.path.dirname(f) if f_dirname != "": From 969c84f004939c4df29693a3e28e5c1c8f1f2737 Mon Sep 17 00:00:00 2001 From: Charlie Truong Date: Tue, 2 Dec 2025 14:01:54 -0600 Subject: [PATCH 2/5] Add code rabbit config Signed-off-by: Charlie Truong --- .coderabbit.yaml | 101 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 101 insertions(+) create mode 100644 .coderabbit.yaml diff --git a/.coderabbit.yaml b/.coderabbit.yaml new file mode 100644 index 0000000000..e272db3549 --- /dev/null +++ b/.coderabbit.yaml @@ -0,0 +1,101 @@ +# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json +# https://docs.coderabbit.ai/getting-started/configure-coderabbit/ +# Validator https://docs.coderabbit.ai/configuration/yaml-validator#yaml-validator +# In PR, comment "@coderabbitai configuration" to get the full config including defaults +# Set the language for reviews by using the corresponding ISO language code. +# Default: "en-US" +language: "en-US" +# Settings related to reviews. +# Default: {} +reviews: + # Set the profile for reviews. Assertive profile yields more feedback, that may be considered nitpicky. + # Options: chill, assertive + # Default: "chill" + profile: chill + # Add this keyword in the PR/MR title to auto-generate the title. + # Default: "@coderabbitai" + auto_title_placeholder: '@coderabbitai title' + # Auto Title Instructions - Custom instructions for auto-generating the PR/MR title. + # Default: "" + auto_title_instructions: 'Format: ": ". Category must be one of: feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert, cp. The category must be followed by a colon. Title should be concise (<= 80 chars). Example: "feat: Add logit_bias support".' # current: '' + # Set the commit status to 'pending' when the review is in progress and 'success' when it is complete. + # Default: true + commit_status: false + # Generate walkthrough in a markdown collapsible section. + # Default: false + collapse_walkthrough: true + # Generate an assessment of how well the changes address the linked issues in the walkthrough. + # Default: true + assess_linked_issues: true + # Include possibly related issues in the walkthrough. + # Default: true + related_issues: true + # Related PRs - Include possibly related pull requests in the walkthrough. + # Default: true + related_prs: true + # Suggest labels based on the changes in the pull request in the walkthrough. + # Default: true + suggested_labels: true + # Suggest reviewers based on the changes in the pull request in the walkthrough. + # Default: true + suggested_reviewers: true + # Generate a poem in the walkthrough comment. + # Default: true + poem: false # current: true + # Post review details on each review. Additionally, post a review status when a review is skipped in certain cases. + # Default: true + review_status: false # current: true + # Configuration for pre merge checks + # Default: {} + pre_merge_checks: + # Custom Pre-merge Checks - Add unique checks to enforce your team's standards before merging a pull request. Each check must have a unique name (up to 50 characters) and clear instructions (up to 10000 characters). Use these to automatically verify coding, security, documentation, or business rules and maintain code quality. + # Default: [] + custom_checks: + - name: "Test Results for Major Changes" + mode: "warning" # or "error" to block merges + instructions: | + If this PR contains major changes (such as new features, breaking changes, or significant refactoring), verify that the PR description includes test results or testing information. + If a change could affect numerics or convergence, the PR description should include information demonstrating that there is no regression. + If a change could affect performance, the PR description should include before-and-after performance numbers, as well as the configuration and context in which they apply. + Pass if test results are documented or if the changes are minor. + auto_review: + # Configuration for auto review + # Default: {} + # Automatic Incremental Review - Automatic incremental code review on each push + # Default: true + auto_incremental_review: false # current: true + # Review draft PRs/MRs. + # Default: false + drafts: false + # Base branches (other than the default branch) to review. Accepts regex patterns. Use '.*' to match all branches. + # Default: [] + base_branches: ["main", "r[0-9].*", "chtruong/*"] # current: [] +# Configuration for knowledge base +# Default: {} +knowledge_base: + code_guidelines: + # CodeRabbit will analyse and learn from your organization's code guidelines, which you can mention in the file patterns section. These guidelines will then be used to conduct thorough code reviews. + # Default: {} + enabled: true + # Enabled - Enable CodeRabbit to enforce your organization's coding standards during reviews. + # Default: true + filePatterns: # current: [] + # File Patterns - Specify files for your coding guideline documents in this section. CodeRabbit will scan these files to understand your team's standards and apply them during code reviews. Multiple files supported. File names are case-sensitive. Common files like: (**/.cursorrules, .github/copilot-instructions.md, .github/instructions/*.instructions.md, **/CLAUDE.md, **/GEMINI.md, **/.cursor/rules/*, **/.windsurfrules, **/.clinerules/*, **/.rules/*, **/AGENT.md, **/AGENTS.md) are included by default. + # Default: [] + - "**/CODING_GUIDELINES.md" + - "**/.cursor/rules/*" \ No newline at end of file From 500837dade0bb777068bc3a3984487a2e76b05e5 Mon Sep 17 00:00:00 2001 From: George Armstrong <georgea@nvidia.com> Date: Tue, 2 Dec 2025 12:56:20 -0800 Subject: [PATCH 3/5] Apply suggestion from @gwarmstrong Signed-off-by: George Armstrong <georgea@nvidia.com> --- nemo_skills/file_utils.py | 1 - 1 file changed, 1 deletion(-) diff --git a/nemo_skills/file_utils.py b/nemo_skills/file_utils.py index 00905a9e8e..fa271bc0d6 100644 --- a/nemo_skills/file_utils.py +++ b/nemo_skills/file_utils.py @@ -42,7 +42,6 @@ def _make_w_io_base(f, mode: str): f: A file path or an IOBase object. mode: Mode for opening the file (default is write mode). """ - print("This is a test") if not isinstance(f, io.IOBase): f_dirname = os.path.dirname(f) if f_dirname != "": From 439f51025e05db6deac139e679e8a03d62198f8f Mon Sep 17 00:00:00 2001 From: George Armstrong <georgea@nvidia.com> Date: Tue, 2 Dec 2025 13:01:54 -0800 Subject: [PATCH 4/5] Apply suggestions from code review Signed-off-by: George Armstrong <georgea@nvidia.com> --- .coderabbit.yaml | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index e272db3549..891cad0e96 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -65,14 +65,7 @@ reviews: pre_merge_checks: # Custom Pre-merge Checks - Add unique checks to enforce your team's standards before merging a pull request. Each check must have a unique name (up to 50 characters) and clear instructions (up to 10000 characters). Use these to automatically verify coding, security, documentation, or business rules and maintain code quality. # Default: [] - custom_checks: - - name: "Test Results for Major Changes" - mode: "warning" # or "error" to block merges - instructions: | - If this PR contains major changes (such as new features, breaking changes, or significant refactoring), verify that the PR description includes test results or testing information. - If a change could affect numerics or convergence, the PR description should include information demonstrating that there is no regression. - If a change could affect performance, the PR description should include before-and-after performance numbers, as well as the configuration and context in which they apply. - Pass if test results are documented or if the changes are minor. + custom_checks: [] auto_review: # Configuration for auto review # Default: {} @@ -84,7 +77,7 @@ reviews: drafts: false # Base branches (other than the default branch) to review. Accepts regex patterns. Use '.*' to match all branches. # Default: [] - base_branches: ["main", "r[0-9].*", "chtruong/*"] # current: [] + base_branches: ["main", "chtruong/*"] # current: [] # Configuration for knowledge base # Default: {} knowledge_base: @@ -97,5 +90,4 @@ knowledge_base: filePatterns: # current: [] # File Patterns - Specify files for your coding guideline documents in this section. CodeRabbit will scan these files to understand your team's standards and apply them during code reviews. Multiple files supported. File names are case-sensitive. Common files like: (**/.cursorrules, .github/copilot-instructions.md, .github/instructions/*.instructions.md, **/CLAUDE.md, **/GEMINI.md, **/.cursor/rules/*, **/.windsurfrules, **/.clinerules/*, **/.rules/*, **/AGENT.md, **/AGENTS.md) are included by default. # Default: [] - - "**/CODING_GUIDELINES.md" - - "**/.cursor/rules/*" \ No newline at end of file + - "CONTRIBUTING.md" \ No newline at end of file From bc3903dd187aba8b2966bedf47be39d33b0cb18d Mon Sep 17 00:00:00 2001 From: George Armstrong <georgea@nvidia.com> Date: Tue, 2 Dec 2025 13:10:00 -0800 Subject: [PATCH 5/5] Apply suggestion from @gwarmstrong Signed-off-by: George Armstrong <georgea@nvidia.com> --- .coderabbit.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 891cad0e96..39d892a94d 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -90,4 +90,4 @@ knowledge_base: filePatterns: # current: [] # File Patterns - Specify files for your coding guideline documents in this section. CodeRabbit will scan these files to understand your team's standards and apply them during code reviews. Multiple files supported. File names are case-sensitive. Common files like: (**/.cursorrules, .github/copilot-instructions.md, .github/instructions/*.instructions.md, **/CLAUDE.md, **/GEMINI.md, **/.cursor/rules/*, **/.windsurfrules, **/.clinerules/*, **/.rules/*, **/AGENT.md, **/AGENTS.md) are included by default. # Default: [] - - "CONTRIBUTING.md" \ No newline at end of file + - "CONTRIBUTING.md"