diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000000..2673715981 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,61 @@ +# Order is important: later matches have higher precedence + +# List of reviewer teams +# @nvidia-nemo/rl_reviewers_algo +# @nvidia-nemo/rl_reviewers_supervised +# @nvidia-nemo/rl_reviewers_async +# @nvidia-nemo/rl_reviewers_automodel +# @nvidia-nemo/rl_reviewers_ci +# @nvidia-nemo/rl_reviewers_doc +# @nvidia-nemo/rl_reviewers_environments +# @nvidia-nemo/rl_reviewers_eval +# @nvidia-nemo/rl_reviewers_generation +# @nvidia-nemo/rl_reviewers_infra +# @nvidia-nemo/rl_reviewers_mcore +# @nvidia-nemo/rl_reviewers_multimodal +# @nvidia-nemo/rl_reviewers_models +# @nvidia-nemo/rl_reviewers_perf + +# Catch-all if not defined +* @nvidia-nemo/rl_maintainers + +# CI/Test +/.github/ @nvidia-nemo/rl_reviewers_ci +/tests/ @nvidia-nemo/rl_reviewers_ci + +# Examples and configs (TODO: Add all algo subteams eventually) +/examples/ @nvidia-nemo/rl_reviewers_algo +/examples/**/*vlm* @nvidia-nemo/rl_reviewers_multimodal +/examples/**/*sft* @nvidia-nemo/rl_reviewers_supervised +/examples/**/*dpo* @nvidia-nemo/rl_reviewers_supervised +/examples/**/*rm* @nvidia-nemo/rl_reviewers_supervised + +# Core (TODO: Add all algo subteams eventually) +/nemo_rl/algorithms/ @nvidia-nemo/rl_reviewers_algo +/nemo_rl/algorithms/sft.py @nvidia-nemo/rl_reviewers_supervised +/nemo_rl/algorithms/dpo.py @nvidia-nemo/rl_reviewers_supervised +/nemo_rl/algorithms/rm.py @nvidia-nemo/rl_reviewers_supervised +/nemo_rl/environments/ @nvidia-nemo/rl_reviewers_environments @nvidia-nemo/rl_reviewers_algo +/nemo_rl/data/ @nvidia-nemo/rl_reviewers_algo +/nemo_rl/experience/ @nvidia-nemo/rl_reviewers_environments @nvidia-nemo/rl_reviewers_algo +/nemo_rl/evals/ @nvidia-nemo/rl_reviewers_eval +/nemo_rl/distributed/ @nvidia-nemo/rl_reviewers_infra +/nemo_rl/models/ @nvidia-nemo/rl_reviewers_automodel @nvidia-nemo/rl_reviewers_mcore +/nemo_rl/models/dtensor/ @nvidia-nemo/rl_reviewers_automodel +/nemo_rl/models/generation/ @nvidia-nemo/rl_reviewers_generation +/nemo_rl/models/generation/fp8.py @nvidia-nemo/rl_reviewers_perf +/nemo_rl/models/megatron/ @nvidia-nemo/rl_reviewers_mcore +/nemo_rl/models/policy/dtensor* @nvidia-nemo/rl_reviewers_automodel +/nemo_rl/models/policy/megatron* @nvidia-nemo/rl_reviewers_mcore +/nemo_rl/utils/flop* @nvidia-nemo/rl_reviewers_perf + +# Infra, tooling, and docs +/docker/ @nvidia-nemo/rl_reviewers_infra +/docs/ @nvidia-nemo/rl_reviewers_doc +/3rdparty/Automodel-workspace/ @nvidia-nemo/rl_reviewers_automodel +/3rdparty/Megatron-LM-workspace/ @nvidia-nemo/rl_reviewers_mcore +/3rdparty/Megatron-Bridge-workspace/ @nvidia-nemo/rl_reviewers_mcore +/ray.sub @nvidia-nemo/rl_reviewers_infra + +# Codeowners +/.github/CODEOWNERS @nvidia-nemo/rl_maintainers diff --git a/nemo_rl/converters/__init__.py b/nemo_rl/converters/__init__.py deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/nemo_rl/converters/huggingface/__init__.py b/nemo_rl/converters/huggingface/__init__.py deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/nemo_rl/converters/huggingface/vllm_export.py b/nemo_rl/converters/huggingface/vllm_export.py deleted file mode 100644 index 341a77c5bc..0000000000 --- a/nemo_rl/converters/huggingface/vllm_export.py +++ /dev/null @@ -1,13 +0,0 @@ -# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. diff --git a/nemo_rl/converters/megatron/__init__.py b/nemo_rl/converters/megatron/__init__.py deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/nemo_rl/converters/megatron/vllm_export.py b/nemo_rl/converters/megatron/vllm_export.py deleted file mode 100644 index 341a77c5bc..0000000000 --- a/nemo_rl/converters/megatron/vllm_export.py +++ /dev/null @@ -1,13 +0,0 @@ -# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. diff --git a/nemo_rl/metrics/__init__.py b/nemo_rl/metrics/__init__.py deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/nemo_rl/metrics/metrics_utils.py b/nemo_rl/metrics/metrics_utils.py deleted file mode 100644 index 341a77c5bc..0000000000 --- a/nemo_rl/metrics/metrics_utils.py +++ /dev/null @@ -1,13 +0,0 @@ -# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. diff --git a/pyrefly.toml b/pyrefly.toml index 51b5574002..0464f138d5 100644 --- a/pyrefly.toml +++ b/pyrefly.toml @@ -35,11 +35,6 @@ project-includes = [ "nemo_rl/algorithms/__init__.py", "nemo_rl/algorithms/interfaces.py", "nemo_rl/algorithms/utils.py", - "nemo_rl/converters/__init__.py", - "nemo_rl/converters/huggingface/__init__.py", - "nemo_rl/converters/huggingface/vllm_export.py", - "nemo_rl/converters/megatron/__init__.py", - "nemo_rl/converters/megatron/vllm_export.py", "nemo_rl/data/__init__.py", "nemo_rl/data/datasets.py", "nemo_rl/data/eval_datasets/__init__.py", @@ -87,8 +82,6 @@ project-includes = [ "nemo_rl/evals/answer_parsing.py", "nemo_rl/experience/__init__.py", "nemo_rl/experience/rollouts.py", - "nemo_rl/metrics/__init__.py", - "nemo_rl/metrics/metrics_utils.py", "nemo_rl/models/__init__.py", "nemo_rl/models/dtensor/__init__.py", "nemo_rl/models/dtensor/parallelize.py",