From 94154e898f9c39418cae14519d180f66f9bd2077 Mon Sep 17 00:00:00 2001 From: yaoyu-33 Date: Wed, 22 Apr 2026 15:00:11 -0700 Subject: [PATCH] [ci] fix: re-enable test_fsdp_pretrain_with_checkpoint after TE 2.14 fix The test was marked `pleasefixme` due to a TE 2.14 regression where `split_swiglu_linear_fc1` validated the local FSDP shard shape instead of the global DTensor shape (NVIDIA/TransformerEngine#2795). Our TE pin (f031cf87 on release_v2.14) already includes the cherry-picked fix (a4a073b), so the marker can be removed. Closes: NVIDIA-NeMo/Megatron-Bridge#2998 Co-Authored-By: Claude Opus 4.6 Signed-off-by: yaoyu-33 --- .../functional_tests/test_groups/training/test_megatron_fsdp.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/functional_tests/test_groups/training/test_megatron_fsdp.py b/tests/functional_tests/test_groups/training/test_megatron_fsdp.py index 505268013a..b3f6744d34 100644 --- a/tests/functional_tests/test_groups/training/test_megatron_fsdp.py +++ b/tests/functional_tests/test_groups/training/test_megatron_fsdp.py @@ -352,7 +352,6 @@ def test_fsdp_pretrain_basic(self, tmp_path): clear_directories(tmp_path) @pytest.mark.run_only_on("GPU") - @pytest.mark.pleasefixme # Broken after TE2.14 bump def test_fsdp_pretrain_with_checkpoint(self, tmp_path): """ Test FSDP training with checkpoint saving using fsdp_dtensor format.