Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTIA/SigMF lags gnuradio/SigMF #29

Open
aromanielloNTIA opened this issue Aug 8, 2022 · 3 comments
Open

NTIA/SigMF lags gnuradio/SigMF #29

aromanielloNTIA opened this issue Aug 8, 2022 · 3 comments

Comments

@aromanielloNTIA
Copy link
Member

It looks like SCOS Actions' use of NTIA/SigMF instead of the official gnuradio/SigMF is a relic from a time before NTIA/sigmf-ns-ntia existed. The official SigMF has a v1.0.0 release, which we should be using instead of an unmaintained and out-of-date fork.

This will also make the SigMF dependency installable from PyPi along with most other dependencies, which should speed up SCOS build times a little bit, since it's one fewer package that will need to be built from source.

@aromanielloNTIA
Copy link
Member Author

The release page for gnuradio/SigMF v1.0.0 indicates backwards compatibility. This shouldn't be a difficult switch (maybe just increment the version number?), and I don't get any errors from crudely changing the dependency to gnuradio/SigMF 1.0.0.

@aromanielloNTIA
Copy link
Member Author

aromanielloNTIA commented Aug 9, 2022

There appear to be incompatibilities due to the changes made on the multi-recording-archive branch of NTIA/SigMF. I do actually get an error when running gnuradio/SigMF 1.0.0 when trying to download the archive results, due to differences made in the SigMFFile class.

Official SigMF does support multiple recordings in an archive, by making them part of a SigMF collection. See here for more details.

@aromanielloNTIA
Copy link
Member Author

Despite SigMF collections being present in the SigMF specification, it seems like they are not implemented as part of the official Python package. The best course of action here is probably to fork gnuradio/SigMF v1.0.0, add support for collections, and open a PR on gnuradio/SigMF to merge the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant