Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take headers instead of Broker instances + scan numbers in databroker public APIs #68

Open
leofang opened this issue Oct 18, 2019 · 0 comments

Comments

@leofang
Copy link
Collaborator

leofang commented Oct 18, 2019

Suggestions from @tacaswell (copied from Slack):

  • the headers do have access to db they came from so you can dig back to get it.
  • the scan numbers are not guaranteed to be unique
  • If we were to come up with some other scheme for generating valid headers or finding the valid header (using search, fabricating it from a bunch of files from another facility, etc) it will just work if your functions take in headers. If they expect (db, scan_id) then we would have to also fabricate a databroker to slice into
  • maintaining back-compat on header.db is going to be easier to maintain long term then making sure db[n] works, particuarly if we know the thing that needs to survive is h.db.reg.retrieve
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant