Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure_kafka_publisher not working when Broker instance passed to configure_base #207

Open
gwbischof opened this issue Oct 31, 2024 · 0 comments · May be fixed by #208
Open

configure_kafka_publisher not working when Broker instance passed to configure_base #207

gwbischof opened this issue Oct 31, 2024 · 0 comments · May be fixed by #208

Comments

@gwbischof
Copy link
Contributor

gwbischof commented Oct 31, 2024 •
edited
Loading

broker_name can be a Broker instance, or a string in the call to configure_base, but configure_kafka_publisher expects a string. So configure_kafka_publisher will fail if you pass a Broker to configure_base.

nslsii/nslsii/__init__.py

Line 74 in 8a952c2

broker_name : Union[str, Broker, None], optional

@gwbischof gwbischof changed the title configure_kafka_publisher not working when broker instance passed to configure_base configure_kafka_publisher not working when Broker instance passed to configure_base Oct 31, 2024
@gwbischof gwbischof linked a pull request Nov 1, 2024 that will close this issue
Open
@maffettone maffettone mentioned this issue Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix configure_kafka_publisher call gwbischof/nslsii
1 participant
@gwbischof