Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arugments for find_photons() look to be inverted for version '0.2.0rc2' #24

Open
ambarb opened this issue Jun 9, 2023 · 0 comments
Open

Comments

@ambarb
Copy link

ambarb commented Jun 9, 2023

@stuwilkins in the example notebook of this repo, we find we get zero photons using pycentroids version
'0.2.0rc2'

https://github.com/NSLS-II/centroids/blame/f9a8b54143aab7de6ec0e6dd5f992c93ad33f8ec/examples/Single_Photon_Test.ipynb#L212

image

Looking at the docstring, it seems that the threshold (250) and filter (3) are inverted for the version deployed on our jupyterserver.

We can update the notebook in a PR, but just wanted to check first.

Also, the histograms look generally the same, but we found 794 events not 702 after just fixing the argument order above. The histograms look largely the same, but the 2x2 scatter plots look like the correlation of fits for xfrac and yfrac are improved. Perhaps this is expected as improvements were made to code. Can you confirm the algorithm should be "better" or do we need to adjust the argument values ?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant