Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more cmods to the attic #1292

Open
brtietz opened this issue Mar 5, 2025 · 3 comments
Open

Move more cmods to the attic #1292

brtietz opened this issue Mar 5, 2025 · 3 comments
Assignees

Comments

@brtietz
Copy link
Collaborator

brtietz commented Mar 5, 2025

Code coverage indicated a number of cmods that could stand to be moved to the attic. The list so far is:

-cmod_fossilgen.cpp
-cmod_utilityrate(1-4).cpp

Flesh out this list and move these to the attic for the next release

@brtietz brtietz self-assigned this Mar 5, 2025
@brtietz brtietz added this to the SAM 2025 release patch 1 milestone Mar 5, 2025
@janinefreeman
Copy link
Collaborator

I don't see any other obvious ones to move (to me), but would appreciate if @tyneises would check that there aren't any old/unused csp compute modules hanging around. Thanks!

@brtietz
Copy link
Collaborator Author

brtietz commented Mar 14, 2025

Partially solved with #1297. I believe there is a CSP attic PR coming, so leaving this open for now as a reminder.

@tyneises
Copy link
Collaborator

CSP clean up here #1299 and here NREL/SAM#2037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants