You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #95 adds in new safe methods for adding/modifying/removing hive entities from the simulation state. Now, we need to go through and update the usage of the old methods to use these new safe methods internally.
I just did a quick test of this, comparing a method that returns the old ErrorOr type to a function that returns the ResultE type (and unwraps the result). The performance cost for this is ~1 microsecond. This seems like an okay tradeoff in performance relative to what we gain in ergonomics.
PR #95 adds in new safe methods for adding/modifying/removing hive entities from the simulation state. Now, we need to go through and update the usage of the old methods to use these new safe methods internally.
For example, in
hive/hive/state/vehicle_state/dispatch_trip.py
Line 78 in 19f07ea
modify_request_safe()
.The text was updated successfully, but these errors were encountered: