API for generic Sensors #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbmouret
reviewed
Sep 21, 2020
jbmouret
reviewed
Sep 21, 2020
jbmouret
reviewed
Sep 21, 2020
Closed
|
Merging.. I note that we should create a random generator (similar to limbo) and add some noise models to the sensors... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add a generic API for creating and using sensors in robot_dart. This will also remove
CameraOSRclass, and adds a MagnumCameraclass as a sensor. Things remaining:RemoveCameraOSRAdd python bindingsAdd tests for sensors (only camera now)Tests for IMU and FT sensors added (no test for camera can be made at the moment)Add a simple IMU sensorAdd force/torque sensorBody Node name does not suffice. We need to have reference to the robot.