Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements to wscript (-fPIC) and dart.py + add line number in assert #179

Merged
merged 4 commits into from
Apr 15, 2022

Conversation

jbmouret
Copy link
Collaborator

A few minor improvements:

  • add -fPIC
  • add a directory in dart.py to find dart
  • add line number in ROBOT_DART_ASSERT

Copy link
Member

@costashatz costashatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor comments. Other than this. Thanks! It's looking good!

wscript Outdated Show resolved Hide resolved
wscript Outdated Show resolved Hide resolved
@costashatz
Copy link
Member

@jbmouret this should finalized now. I did some minor modifications (e.g. when building shared, we do not need -fPIC; the code generated is position independent by definition) and I updated all searches for all libs (I added also search for the new M1 chips that some students of mine had problems with).. Let me know if this is working for you..

@costashatz
Copy link
Member

@jbmouret is this OK to merge?

@jbmouret
Copy link
Collaborator Author

yes (in which case do we want to remove -fPIC?)

@costashatz
Copy link
Member

(in which case do we want to remove -fPIC?)

If we are building shared libs, PIC is already there by definition so the flag is useless. Also, I cannot see an application at the moment, but maybe someone finds some weird application for removing -fPIC (e.g. an architecture/CPU not allowing PIC).

@costashatz costashatz merged commit 158f72e into master Apr 15, 2022
@costashatz costashatz deleted the wscript_improvements branch April 15, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants