fix big_sur (osx 11.6) compilation #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costashatz
requested changes
Oct 1, 2021
costashatz
approved these changes
Oct 1, 2021
|
@jbmouret thanks for this.. I am merging and will check together with the Mac CI if we need to search for "frameworks". |
costashatz
added a commit
that referenced
this pull request
Dec 8, 2021
fix big_sur (osx 11.6) compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It mainly skip the check for OpenGL libs since this is a framework and Magnum already does its stuffs for this. I am not sure this works for older OS X version because it was working before without this fix.
However, we do not have that many OS X users (except me).