Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[magnum]: do not use deprecated Magnum functions #138

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Conversation

costashatz
Copy link
Member

Update for latest upstream Magnum...

@costashatz costashatz added this to the RobotDART 1.0.0 milestone Sep 15, 2021
@costashatz costashatz self-assigned this Sep 15, 2021
@jbmouret
Copy link
Collaborator

shouldn't we merge this to `devel' and keep the master to a specific version of Magnum?

Merging this will break all the installations/containers that did not update Magnum yet, I guess...

@costashatz
Copy link
Member Author

We need to first have a devel branch.. ;)

I think that I like more the following: master is development, other branches or tags for stable things. I can create one for your needs. What do you think?

@jbmouret
Copy link
Collaborator

Yes, this works for me too, but we need to keep a "release x" branch in that case :)

@costashatz
Copy link
Member Author

Good! I'll first make a PR to remove (the dead now) travis and use GitHub actions for CI. Then I'll create separate release branches..

@costashatz
Copy link
Member Author

@jbmouret I'll merge this and let me know if things will break for your dockers/setups. Of course the easiest solution is just to use latest Corrade/Magnum etc, but once we make the 1.0.0 release we'll provide installation instructions for specific commits of Corrade/Magnum etc for easy portability and avoid issues.

@costashatz costashatz merged commit b8f0db5 into master Oct 1, 2021
@costashatz costashatz deleted the new_magnum branch October 1, 2021 22:39
costashatz added a commit that referenced this pull request Dec 8, 2021
[magnum]: do not use deprecated Magnum functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants