Remove the link to the dependencies (esp. assimp) #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it is not required anymore. (that is, we link with Dart and Dart links with assimp on its own).
|
@jbmouret thanks for this. I will need to adapt the Magnum part. If the plugin is statically compiled, we need to link to assimp and the other libraries. Or not? I think that we do.. |
This was
linked to
issues
Nov 27, 2020
|
I think we need to test because it might work without adding the dep. |
|
@jbmouret thanks for this. I put back the checks in |
costashatz
added a commit
that referenced
this pull request
Dec 8, 2021
Remove the link to the dependencies (esp. assimp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that linking to the dependencies is not required with modern OS/linkers (that is, we link with Dart and Dart links with assimp on its own).
If we do it, this easily leads to inconsistencies if we do not find the same version (e.g dart uses assimp5 and we find assimp3). Also, this is useless code to maintain :)