fix the real time factor + improve scheduler + improve status bar #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbmouret is this ok to merge? |
|
Yes. I will do a different PR for the next changes. |
costashatz
pushed a commit
that referenced
this pull request
Dec 8, 2021
fix the real time factor + improve scheduler + improve status bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were computing the real-time factor using the wall time instead of the iteration time. This means that if we were real-time but had one iteration slower than realtime, we could never catch up and reach a real-time factor of 1. Basically, to reach a real-time factor of 1, we needed many iterations faster than real time if we had been late in the past.
I switched to a real-time factor that corresponds to the iteration time, which corresponds better to what we want to know (I think).
By the way, if you log the iteration time, you will see that in graphics we often have iterations that last 14 ms (400 ms at the start), which do not come from the 'sync' mechanism (apparently). There is no problem in _plain.