Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the robot URDF in some 'path'? #52

Closed
jbmouret opened this issue May 12, 2020 · 3 comments · Fixed by #74
Closed

Install the robot URDF in some 'path'? #52

jbmouret opened this issue May 12, 2020 · 3 comments · Fixed by #74

Comments

@jbmouret
Copy link
Collaborator

Should we install the URDF files in something like $PREFIX/robot_dart/robots/ ?

Because for now we need to copy/link them in each project.

@costashatz costashatz added this to the RobotDART 1.0.0 milestone May 12, 2020
@jbmouret
Copy link
Collaborator Author

How do we include the URDF?

  • as submodules?
  • as files directly (with meshes, etc.)

And where do we install them?

I feel we need to have well-curated URDF because 'random urdf' usually do not work well. We also need to tune the collision shapes, etc. for maximum performance.

@costashatz
Copy link
Member

I feel we need to have well-curated URDF

I agree with you here.

And where do we install them?

Let's first finish the main restructuring of the library and then we should discuss on how to add example robots in robot_dart (along with their URDFs).

@jbmouret
Copy link
Collaborator Author

jbmouret commented Jun 2, 2020

We are almost there :) Thinking about it, I would suggest to create classes for each robot (Talos, Iiwa, etc.) because this would make it easier to define sensors and accessors with intuitive names.

Each class would use a default URDF, which would be taken from either a 'res' directory if it exists, from a ROBOT_DART_PATH env variable, or from $PREFIX/share/robot_dart/robots (installed with robot_dart). Of course, the user could use a different URDF with the same robot class (in that case, the user provides the path). $PREFIX should be taken from the compilation line.

The res directory is to make sure that the developers of robot_dart are using the urdf of the source tree and not the urdf that are installed on the system. The users should use the system files. The env. variable is to make it possible to have several installations of robot_dart files / switch etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants