Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails on Ubuntu 24.04 #202

Closed
c-joly opened this issue Jun 18, 2024 · 14 comments
Closed

Installation fails on Ubuntu 24.04 #202

c-joly opened this issue Jun 18, 2024 · 14 comments
Assignees

Comments

@c-joly
Copy link

c-joly commented Jun 18, 2024

Hello @costashatz, here is an issue linked to the Joss review openjournals/joss-reviews#6771

I tried the installation script on an Ubuntu Virtual Machine 24.04 with arm64 architecture, and it looks to have a problem in the apt dependencies. I attached the terminal log here: https://gist.github.com/c-joly/3d68d729b40c51aa6b11231771941435 (note: I changed the script to make it stop at the first error)

Note: the install script passed flawlessly on Ubuntu 22.04 arm64

It looks like the apt dependencies are not satisfied on the last version of Ubuntu (at least for arm64 architecture, I can't test for amd64 with my Mac M2). Maybe you should consider to limit the versions of Ubuntu that are fine, >= 20.04 may be too optimistic.

@costashatz
Copy link
Member

Hey @c-joly! Thanks for testing.

Interesting that the DART developers have pre-built binaries for 22.04 and not for 24.04 (at least for arm64). I will test on 24.04 on an amd64 arch and see what I get. Then I'll update the script or the docs accordingly.

Good to know that Ubuntu 22.04 worked easily (even on arm64)!

Thanks again!

@boisgera
Copy link
Contributor

Hi @costashatz!

AFAICT, I the same issue also exists for x86, see below ; that makes sense, the 24.04 release is still rather new. So the title of this issue could be updated.

Small nitpicking : could you modify the install_ubuntu.sh script so that it stop as soon as an error is met?
(see for example Unofficial bash strict mode).

Cheers,

Sébastien

boisgera@box:~/robot_dart$ ./scripts/install_ubuntu.sh
[sudo] password for boisgera:
PPA publishes dbgsym, you may need to include 'main/debug' component
Repository: 'Types: deb
URIs: https://ppa.launchpadcontent.net/dartsim/ppa/ubuntu/
Suites: noble
Components: main
'
More info: https://launchpad.net/~dartsim/+archive/ubuntu/ppa
Adding repository.
Hit:1 http://archive.ubuntu.com/ubuntu noble InRelease
Get:2 http://archive.ubuntu.com/ubuntu noble-updates InRelease [126 kB]        
Hit:3 http://security.ubuntu.com/ubuntu noble-security InRelease              
Ign:4 https://ppa.launchpadcontent.net/dartsim/ppa/ubuntu noble InRelease      
Err:5 https://ppa.launchpadcontent.net/dartsim/ppa/ubuntu noble Release
  404  Not Found [IP: 185.125.190.80 443]
Hit:6 http://archive.ubuntu.com/ubuntu noble-backports InRelease
Reading package lists... Done
E: The repository 'https://ppa.launchpadcontent.net/dartsim/ppa/ubuntu noble Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
Ign:1 https://ppa.launchpadcontent.net/dartsim/ppa/ubuntu noble InRelease
Err:2 https://ppa.launchpadcontent.net/dartsim/ppa/ubuntu noble Release        
  404  Not Found [IP: 185.125.190.80 443]
Hit:3 http://archive.ubuntu.com/ubuntu noble InRelease                        
Hit:4 http://security.ubuntu.com/ubuntu noble-security InRelease              
Hit:5 http://archive.ubuntu.com/ubuntu noble-updates InRelease
Hit:6 http://archive.ubuntu.com/ubuntu noble-backports InRelease
Reading package lists... Done
E: The repository 'https://ppa.launchpadcontent.net/dartsim/ppa/ubuntu noble Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.

@costashatz costashatz changed the title Installation fails on Ubuntu 24.04 ARM64 Installation fails on Ubuntu 24.04 Jun 20, 2024
@costashatz
Copy link
Member

@boisgera good to know! I'll inform the DART developers and update the docs until they are up to date. I know they are being very meticulous for the ROS supported Ubuntu versions. So I guess ROS is not on 24.04 yet..

@costashatz
Copy link
Member

costashatz commented Aug 26, 2024

@c-joly @boisgera can you both try again? It seems that DART is now available in 24.04 (see here).

Edit: You can try the scripts_exit branch so that the scripts stop at error.

@boisgera
Copy link
Contributor

boisgera commented Aug 26, 2024

(Edit. Sorry, I did not try the script_exit branch, let me do that again)

On Ubuntu 22.04, I do have an unexpected end of file error message.

The same error will appear (faster) if I only check the syntax of the install script, without running it

~/tmp/robot_dart$ bash -n ./scripts/install_ubuntu.sh 
./scripts/install_ubuntu.sh: line 106: syntax error: unexpected end of file

@boisgera
Copy link
Contributor

There is a missing fi in the script; when it's added, it passes the syntax check. I am trying the install again right now.

@costashatz
Copy link
Member

There is a missing fi in the script; when it's added, it passes the syntax check. I am trying the install again right now.

I just pushed in the master branch, the corrected script (putting the fi in the correct place as it could be ambiguous).

Thank you for your effort :)

@boisgera
Copy link
Contributor

I have this error quite late in the build:

Cloning into 'magnum-bindings'...
remote: Enumerating objects: 5937, done.
remote: Counting objects: 100% (1328/1328), done.
remote: Compressing objects: 100% (466/466), done.
remote: Total 5937 (delta 970), reused 1186 (delta 862), pack-reused 4609 (from 1)
Receiving objects: 100% (5937/5937), 1.64 MiB | 1.46 MiB/s, done.
Resolving deltas: 100% (4459/4459), done.
-- The CXX compiler identification is GNU 13.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Corrade (missing: CORRADE_INCLUDE_DIR
  _CORRADE_CONFIGURE_FILE)
Call Stack (most recent call first):
  /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  modules/FindCorrade.cmake:312 (find_package_handle_standard_args)
  modules/FindMagnum.cmake:262 (find_package)
  CMakeLists.txt:59 (find_package)


-- Configuring incomplete, errors occurred!

@costashatz
Copy link
Member

I have this error quite late in the build:

OK! Let me have a deeper look and come back to it. At least it seems that the Ubuntu 24.04 issue is gone. I'll fix the rest! Thanks! I'll ping you once I have this ready.

@costashatz
Copy link
Member

costashatz commented Aug 28, 2024

@boisgera @c-joly the master branch now contains an install_ubuntu.sh script that should work for >=20.04. I just tried in clean docker images.

Can you please try again and confirm this? Edit: just try for 24.04. No need for extra work here :)

Thanks again!

@c-joly
Copy link
Author

c-joly commented Aug 29, 2024

Hi @costashatz, @boisgera,

Just tried on my VM Ubuntu 24.04 ARM64. Install script works fine, and after updating .bashrc as requested in the doc, I can run several C++ examples and their Python equivalent.

However, I noticed some problems with some examples. I experienced errors due to setScale, for examples with all examples with Talos and Tiago. @boisgera , @costashatz : can you check on x64 architecture?

Below the error I got:

cyril@joss-24:~/robot_dart/build$ ./talos_fast_plain 
talos_fast_plain: ./dart/dynamics/MeshShape.cpp:240: void dart::dynamics::MeshShape::setScale(const Eigen::Vector3d&): Assertion `(scale.array() > 0.0).all()' failed.
Aborted (core dumped)

@costashatz
Copy link
Member

costashatz commented Aug 29, 2024

However, I noticed some problems with some examples. I experienced errors due to setScale, for examples with all examples with Talos and Tiago. @boisgera , @costashatz : can you check on x64 architecture?

I checked and it appears that this is coming from DART (it also happens in x64). They have tightened their checks for mesh scaling. Imho, they should allow negative ones (this just mirrors the mesh; very common practice in graphics community to put negative scale). I will contact them and see how we can solve this. Not very important, but annoying to not be able to use the basic examples. Thanks for catching this.

Edit: For reference, here's the issue on DART's repo.

@costashatz
Copy link
Member

@c-joly this is fixed in DART's master branch (see dartsim/dart#1841). So in the next release, this is going to be okay ;)

I will add a line in the documentation.

@costashatz
Copy link
Member

I think this is ready to be closed! @c-joly let me know if you find something else that needs fixing. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants