Fix: Workflow maintaing conda environment#60
Conversation
bensonr
left a comment
There was a problem hiding this comment.
I think we need to be careful about specifying bash as its behavior can change as we update the underlying container or system OS.
jjuyeonkim
left a comment
There was a problem hiding this comment.
Looks good to me -- similar to NOAA-GFDL/pace#146.
|
|
||
| - name: Orchestrated dace:cpu Translate Test | ||
| shell: bash -l {0} | ||
| shell: bash -el {0} |
There was a problem hiding this comment.
Is this shell specification still necessary?
There was a problem hiding this comment.
Yes, without it the python installed in the conda environment cannot be accessed.
There was a problem hiding this comment.
All other steps seem to be fine with the default run shell specification in lines 29-31. How is this step different?
I guess I'm missing something obvious here ... just asking cause I'm curious how this works.
There was a problem hiding this comment.
Oh...I totally forgot to remove this, thanks!
We can add other shells to test when needed, as is depicted in this documentation. |
Description
This PR ensures that the same shell is opened across workflow steps and no longer calls for removal of
sqliteafter installation.🚧
To be merged after PR 146 in Pace
Fixes:
Current issues in the workflow
How Has This Been Tested?
Tested with the current set of unit tests
Checklist: