Skip to content

Updated container for Github Action and reusable workflow #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmalatino merged 14 commits into from
Jun 26, 2024
Merged

Updated container for Github Action and reusable workflow #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bc2210d
updated generate_eta_files
Apr 30, 2024
04ec836
Merge remote-tracking branch 'origin/develop' into updated_ci
May 6, 2024
338058a
remove notebook, add script
May 8, 2024
fab7821
lint
May 10, 2024
7bd5e97
Merge remote-tracking branch 'origin/develop' into updated_ci
Jun 11, 2024
37139a6
correct path
Jun 11, 2024
923c572
update constraints
Jun 11, 2024
af8b3f1
python3 execute
Jun 11, 2024
8a0c598
Update main_unit_tests_mpich.yaml
mlee03 Jun 11, 2024
271e65e
Update main_unit_tests_mpich.yaml
mlee03 Jun 11, 2024
7e604fb
update input directory
Jun 11, 2024
a5b17ea
Merge remote-tracking branch 'mkl/updated_ci' into updated_ci
Jun 11, 2024
a248292
get ..s correct
Jun 11, 2024
01491bc
lint
Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions .github/workflows/main_unit_tests_mpich.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: "Main unit tests with mpich"
on:
push:
pull_request:
types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled]

Expand All @@ -12,15 +13,18 @@ jobs:
main_unit_tests:
runs-on: ubuntu-latest
container:
image: ghcr.io/noaa-gfdl/pace_mpich:3.11.9
image: ghcr.io/noaa-gfdl/miniforge:mpich
steps:
- name: Checkout Pace repository
uses: actions/checkout@v4
with:
- name: Checkout Pace repository
uses: actions/checkout@v4
with:
submodules: 'recursive'
- name: setup env and run tests (test)
run: |
cp /home/scripts/setup_env.sh . && chmod +x setup_env.sh
cp /home/scripts/run_tests.sh . && chmod +x run_tests.sh
./setup_env.sh
./run_tests.sh
- name: setup env and generate input files
run: |
pip3 install --upgrade pip setuptools wheel
pip3 install -r requirements_dev.txt -c constraints.txt
cd tests/main && mkdir -p input && cd input
python3 ../../../examples/generate_eta_files.py
cd ../../../
- name:

@oelbert oelbert Jun 18, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to name this step?

@mlee03 mlee03 Jun 24, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Oliver, I'm so sorry! I decided to push in the reusable workflow changes to this PR, it might need your review again. 😇

run: pytest -x tests/main
26 changes: 0 additions & 26 deletions .github/workflows/main_unit_tests_openmpi.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion constraints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ pathspec==0.12.1
# via black
pexpect==4.9.0
# via ipython
platformdirs==2.6.2
platformdirs==3.10.0
# via
# black
# jupyter-core
Expand Down