Boilerplate code for fast deploy of NDSL#39
Merged
Conversation
xyuan
previously approved these changes
May 15, 2024
xyuan
left a comment
There was a problem hiding this comment.
would we have a util directory, and put all these utility code there instead of ndsl directory?
Collaborator
Author
|
I personally don't like |
|
sure, that makes sense, thanks
…On Wed, May 15, 2024 at 9:54 AM Florian Deconinck ***@***.***> wrote:
I personally don't like util directories as they become a dumping ground
for everything and anything quickly (we use to have one we clean up with
Frank). Each tools & features should be named with what they do
—
Reply to this email directly, view it on GitHub
<#39 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFCG2D7RP2G7YUOGCUK3Y3ZCNSKBAVCNFSM6AAAAABHWLWJDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGYYTAOBZGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
oelbert
approved these changes
May 17, 2024
oelbert
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Small suggestion if you want for names.
Is part of the thinking that we will end up making a similar function for gpu orchestrated backends and others?
fmalatino
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to present an unified, easy and clean API to the user, we start here a series of "boilerplate" code that wrap common use cases. The first of those is the "quick test" with a one tile, no boundaries, no comms, for
numpyandorchestrated dace:cpuHow Has This Been Tested?
Adding two boilerplate code
Checklist: