Skip to content

Boilerplate code for fast deploy of NDSL#39

Merged
fmalatino merged 5 commits into
developfrom
feature/boilerplate
May 20, 2024
Merged

Boilerplate code for fast deploy of NDSL#39
fmalatino merged 5 commits into
developfrom
feature/boilerplate

Conversation

@FlorianDeconinck

@FlorianDeconinck FlorianDeconinck commented May 14, 2024

Copy link
Copy Markdown
Collaborator

Description
In order to present an unified, easy and clean API to the user, we start here a series of "boilerplate" code that wrap common use cases. The first of those is the "quick test" with a one tile, no boundaries, no comms, for numpy and orchestrated dace:cpu

How Has This Been Tested?
Adding two boilerplate code

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New check tests, if applicable, are included

fmalatino
fmalatino previously approved these changes May 14, 2024

@fmalatino fmalatino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmalatino fmalatino requested review from mlee03, oelbert and xyuan May 14, 2024 19:04
xyuan
xyuan previously approved these changes May 15, 2024

@xyuan xyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would we have a util directory, and put all these utility code there instead of ndsl directory?

@FlorianDeconinck

Copy link
Copy Markdown
Collaborator Author

I personally don't like util directories as they become a dumping ground for everything and anything quickly (we use to have one we clean up with Frank). Each tools & features should be named with what they do

@xyuan

xyuan commented May 15, 2024 via email

Copy link
Copy Markdown

@oelbert oelbert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Small suggestion if you want for names.

Is part of the thinking that we will end up making a similar function for gpu orchestrated backends and others?

Comment thread ndsl/boilerplate.py Outdated
Comment thread ndsl/boilerplate.py Outdated
@FlorianDeconinck FlorianDeconinck dismissed stale reviews from xyuan and fmalatino via 0f8906b May 20, 2024 13:55

@oelbert oelbert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@fmalatino fmalatino merged commit e30bd6b into develop May 20, 2024
@FlorianDeconinck FlorianDeconinck deleted the feature/boilerplate branch May 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants