From 26ed3f1407999009f28513caded564ebc8337251 Mon Sep 17 00:00:00 2001 From: Frank Malatino Date: Wed, 11 Jun 2025 12:20:24 -0400 Subject: [PATCH 1/3] Changes needed for external grid data read-in, needed halo update and fill corners call --- ndsl/grid/generation.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ndsl/grid/generation.py b/ndsl/grid/generation.py index 7b28c2ff..4c65676e 100644 --- a/ndsl/grid/generation.py +++ b/ndsl/grid/generation.py @@ -482,6 +482,12 @@ def from_external( terms._grid_64.view[:, :, 0] = rad_conv * x terms._grid_64.view[:, :, 1] = rad_conv * y + terms._comm.halo_update(terms._grid_64, n_points=terms._halo) + + fill_corners_2d( + terms._grid_64.data, terms._grid_indexing, gridtype="B", direction="x" + ) + terms._init_agrid() return terms From 06444d43d14a1584d61aceef78ad6019c5b9b12b Mon Sep 17 00:00:00 2001 From: Frank Malatino Date: Fri, 13 Jun 2025 12:34:32 -0400 Subject: [PATCH 2/3] Transpose of read in lon/lat arrays --- ndsl/grid/generation.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ndsl/grid/generation.py b/ndsl/grid/generation.py index 4c65676e..d3d7d426 100644 --- a/ndsl/grid/generation.py +++ b/ndsl/grid/generation.py @@ -479,8 +479,8 @@ def from_external( ) rad_conv = PI / 180.0 - terms._grid_64.view[:, :, 0] = rad_conv * x - terms._grid_64.view[:, :, 1] = rad_conv * y + terms._grid_64.view[:, :, 0] = rad_conv * x.T + terms._grid_64.view[:, :, 1] = rad_conv * y.T terms._comm.halo_update(terms._grid_64, n_points=terms._halo) From 163de58b7bcc091003151bf207217e4c50340448 Mon Sep 17 00:00:00 2001 From: Frank Malatino Date: Mon, 16 Jun 2025 15:05:06 -0400 Subject: [PATCH 3/3] Removing transpose of data in from_external MetricTerms class method --- ndsl/grid/generation.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ndsl/grid/generation.py b/ndsl/grid/generation.py index d3d7d426..4c65676e 100644 --- a/ndsl/grid/generation.py +++ b/ndsl/grid/generation.py @@ -479,8 +479,8 @@ def from_external( ) rad_conv = PI / 180.0 - terms._grid_64.view[:, :, 0] = rad_conv * x.T - terms._grid_64.view[:, :, 1] = rad_conv * y.T + terms._grid_64.view[:, :, 0] = rad_conv * x + terms._grid_64.view[:, :, 1] = rad_conv * y terms._comm.halo_update(terms._grid_64, n_points=terms._halo)