+Use RHO_PGF_REF for the pressure gradient forces#392
Conversation
Use the new runtime parameter RHO_PGF_REF instead of RHO_0 to set the reference density that is subtracted off from the other densities when calculating the finite volume pressure gradient forces. Although the answers are mathematically equivalent for any value of this parameter, a judicious choice can reduce the impacts of roundoff errors by about 2 orders of magnitude. By default, RHO_PGF_REF is set to RHO_0, and all answers are bitwise identical. However, there is a new runtime parameter that appears in many of the MOM_parameter_doc.all files.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #392 +/- ##
============================================
- Coverage 38.17% 38.17% -0.01%
============================================
Files 269 269
Lines 76553 76553
Branches 14076 14076
============================================
- Hits 29226 29224 -2
- Misses 42077 42079 +2
Partials 5250 5250
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adcroft
left a comment
adcroft
left a comment
There was a problem hiding this comment.
I had to re-read since the difference between CS%Rho0 and GV%Rho0 was not easily discerned in the terminal. Testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/19898
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/19939 ✔️ 🟡 The confusion between |
* Add three new CVMix parameters CVMix moved three hard-coded fortran parameters to user-defined parameters than can be set via cvmix_init_kpp(). This PR allows users to set those three parameters via MOM_input / MOM_override, but the MOM6 default values match the CVMix default values (which match the previously-hardcoded values) * Update CVMix external in pkg/ Need updated CVMix API that includes ER_Cb, ER_Cs, and ER_Cu arguments to CVMix_init_kpp() * Description comments weren't in right format The comments describing the new variables of the KPP_Cs class were "!" not "!<" so doxygen didn't recognize them
4 participants
Use the new runtime parameter RHO_PGF_REF instead of RHO_0 to set the reference density that is subtracted off from the other densities when calculating the finite volume pressure gradient forces. Although the answers are mathematically equivalent for any value of this parameter, a judicious choice can reduce the impacts of roundoff errors by about 2 orders of magnitude. By default, RHO_PGF_REF is set to RHO_0, and all answers are bitwise identical. However, there is a new runtime parameter that appears in many of the MOM_parameter_doc.all files.