From 219dd7e7ffe1a28f1e04a21cc7659d27e0a25eb8 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 05:32:28 -0400 Subject: [PATCH 01/33] fix acronym --- doc/UsersGuide/source/Acronyms.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/UsersGuide/source/Acronyms.rst b/doc/UsersGuide/source/Acronyms.rst index 1395ec20d7..b057e9cf84 100644 --- a/doc/UsersGuide/source/Acronyms.rst +++ b/doc/UsersGuide/source/Acronyms.rst @@ -37,7 +37,7 @@ Acronyms +----------------+---------------------------------------------------+ | GFS | Global Forecast System | +----------------+---------------------------------------------------+ - | GSD | Global Systems Division | + | GSL | Global Systems Laboratory | +----------------+---------------------------------------------------+ | HTML | Hypertext Markup Language | +----------------+---------------------------------------------------+ From bde5f6f341d5c8257d7c00ed0d3d3316eeceb231 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 05:48:17 -0400 Subject: [PATCH 02/33] chg pull_request_target labels to pull_request --- .github/workflows/update_project_labels.yaml | 40 ++++++++++---------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index adc9bb45c0..c0c16d20d7 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -19,9 +19,9 @@ jobs: steps: - name: Lack of baseline labels if: | - !contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') && - !contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') && - !contains(github.event.pull_request_target.labels.*.name, 'New Baselines') + !contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && + !contains(github.event.pull_request.labels.*.name, 'Baseline Updates') && + !contains(github.event.pull_request.labels.*.name, 'New Baselines') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -31,9 +31,9 @@ jobs: field-value: 'Unknown' - name: Contradictory labels if: | - contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') && - (contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') || - contains(github.event.pull_request_target.labels.*.name, 'New Baselines')) + contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && + (contains(github.event.pull_request.labels.*.name, 'Baseline Updates') || + contains(github.event.pull_request.labels.*.name, 'New Baselines')) uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -43,9 +43,9 @@ jobs: field-value: 'Unknown' - name: Baseline changes labels if: | - (contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') || - contains(github.event.pull_request_target.labels.*.name, 'New Baselines')) && - !contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') + (contains(github.event.pull_request.labels.*.name, 'Baseline Updates') || + contains(github.event.pull_request.labels.*.name, 'New Baselines')) && + !contains(github.event.pull_request.labels.*.name, 'No Baseline Change') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -55,9 +55,9 @@ jobs: field-value: 'Yes' - name: No baseline changes label if: | - contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') && - !contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') && - !contains(github.event.pull_request_target.labels.*.name, 'New Baselines') + contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && + !contains(github.event.pull_request.labels.*.name, 'Baseline Updates') && + !contains(github.event.pull_request.labels.*.name, 'New Baselines') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -74,7 +74,7 @@ jobs: issues: write steps: - name: Input data required - if: contains(github.event.pull_request_target.labels.*.name, 'Input Data Changes') + if: contains(github.event.pull_request.labels.*.name, 'Input Data Changes') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -83,7 +83,7 @@ jobs: field-name: "Input Data Req'd" field-value: 'Yes' - name: No input data changes - if: (!contains(github.event.pull_request_target.labels.*.name, 'Input Data Changes')) + if: (!contains(github.event.pull_request.labels.*.name, 'Input Data Changes')) uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -102,8 +102,8 @@ jobs: steps: - name: Normal Priority if: | - !contains(github.event.pull_request_target.labels.*.name, 'Priority: Critical') && - !contains(github.event.pull_request_target.labels.*.name, 'Priority: High') + !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && + !contains(github.event.pull_request.labels.*.name, 'Priority: High') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -112,7 +112,7 @@ jobs: field-name: 'Priority' field-value: 'Normal' - name: Critical priority - if: "contains(github.event.pull_request_target.labels.*.name, 'Priority: Critical')" + if: "contains(github.event.pull_request.labels.*.name, 'Priority: Critical')" uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -121,7 +121,7 @@ jobs: field-name: 'Priority' field-value: 'Yes' - name: High Priority - if: "(contains(github.event.pull_request_target.labels.*.name, 'Priority: High'))" + if: "(contains(github.event.pull_request.labels.*.name, 'Priority: High'))" uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -131,8 +131,8 @@ jobs: field-value: 'High' - name: Unknown Priority if: | - contains(github.event.pull_request_target.labels.*.name, 'Priority: Critical') && - contains(github.event.pull_request_target.labels.*.name, 'Priority: High') + contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && + contains(github.event.pull_request.labels.*.name, 'Priority: High') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 From dc9450b465a57718b58afda67b9e7bf8e0d70066 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 05:53:41 -0400 Subject: [PATCH 03/33] add pull_request_target for labels --- .../update_project_labels_target.yaml | 142 ++++++++++++++++++ 1 file changed, 142 insertions(+) create mode 100644 .github/workflows/update_project_labels_target.yaml diff --git a/.github/workflows/update_project_labels_target.yaml b/.github/workflows/update_project_labels_target.yaml new file mode 100644 index 0000000000..adc9bb45c0 --- /dev/null +++ b/.github/workflows/update_project_labels_target.yaml @@ -0,0 +1,142 @@ +name: Update Project Labels +on: + pull_request_target: + types: + - opened + - reopened + - labeled + - unlabeled + + +jobs: + baseline-labels: + name: Update project with baseline labels + runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: write + issues: write + steps: + - name: Lack of baseline labels + if: | + !contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') && + !contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') && + !contains(github.event.pull_request_target.labels.*.name, 'New Baselines') + uses: nipe0324/update-project-v2-item-field@v2.0.2 + with: + #project-url: https://github.com/orgs/ufs-community/projects/70 + project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + github-token: ${{ secrets.PR_PROJECT_TOKEN }} + field-name: 'Baseline Changes' + field-value: 'Unknown' + - name: Contradictory labels + if: | + contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') && + (contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') || + contains(github.event.pull_request_target.labels.*.name, 'New Baselines')) + uses: nipe0324/update-project-v2-item-field@v2.0.2 + with: + #project-url: https://github.com/orgs/ufs-community/projects/70 + project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + github-token: ${{ secrets.PR_PROJECT_TOKEN }} + field-name: 'Baseline Changes' + field-value: 'Unknown' + - name: Baseline changes labels + if: | + (contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') || + contains(github.event.pull_request_target.labels.*.name, 'New Baselines')) && + !contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') + uses: nipe0324/update-project-v2-item-field@v2.0.2 + with: + #project-url: https://github.com/orgs/ufs-community/projects/70 + project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + github-token: ${{ secrets.PR_PROJECT_TOKEN }} + field-name: 'Baseline Changes' + field-value: 'Yes' + - name: No baseline changes label + if: | + contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') && + !contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') && + !contains(github.event.pull_request_target.labels.*.name, 'New Baselines') + uses: nipe0324/update-project-v2-item-field@v2.0.2 + with: + #project-url: https://github.com/orgs/ufs-community/projects/70 + project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + github-token: ${{ secrets.PR_PROJECT_TOKEN }} + field-name: 'Baseline Changes' + field-value: 'No' + data-labels: + name: Update project with input data labels + runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: write + issues: write + steps: + - name: Input data required + if: contains(github.event.pull_request_target.labels.*.name, 'Input Data Changes') + uses: nipe0324/update-project-v2-item-field@v2.0.2 + with: + #project-url: https://github.com/orgs/ufs-community/projects/70 + project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + github-token: ${{ secrets.PR_PROJECT_TOKEN }} + field-name: "Input Data Req'd" + field-value: 'Yes' + - name: No input data changes + if: (!contains(github.event.pull_request_target.labels.*.name, 'Input Data Changes')) + uses: nipe0324/update-project-v2-item-field@v2.0.2 + with: + #project-url: https://github.com/orgs/ufs-community/projects/70 + project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + github-token: ${{ secrets.PR_PROJECT_TOKEN }} + field-name: "Input Data Req'd" + field-value: 'No' + #Figure out "Combine" toggle & logic + priority-labels: + name: Update project with priority labels + runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: write + issues: write + steps: + - name: Normal Priority + if: | + !contains(github.event.pull_request_target.labels.*.name, 'Priority: Critical') && + !contains(github.event.pull_request_target.labels.*.name, 'Priority: High') + uses: nipe0324/update-project-v2-item-field@v2.0.2 + with: + #project-url: https://github.com/orgs/ufs-community/projects/70 + project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + github-token: ${{ secrets.PR_PROJECT_TOKEN }} + field-name: 'Priority' + field-value: 'Normal' + - name: Critical priority + if: "contains(github.event.pull_request_target.labels.*.name, 'Priority: Critical')" + uses: nipe0324/update-project-v2-item-field@v2.0.2 + with: + #project-url: https://github.com/orgs/ufs-community/projects/70 + project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + github-token: ${{ secrets.PR_PROJECT_TOKEN }} + field-name: 'Priority' + field-value: 'Yes' + - name: High Priority + if: "(contains(github.event.pull_request_target.labels.*.name, 'Priority: High'))" + uses: nipe0324/update-project-v2-item-field@v2.0.2 + with: + #project-url: https://github.com/orgs/ufs-community/projects/70 + project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + github-token: ${{ secrets.PR_PROJECT_TOKEN }} + field-name: 'Priority' + field-value: 'High' + - name: Unknown Priority + if: | + contains(github.event.pull_request_target.labels.*.name, 'Priority: Critical') && + contains(github.event.pull_request_target.labels.*.name, 'Priority: High') + uses: nipe0324/update-project-v2-item-field@v2.0.2 + with: + #project-url: https://github.com/orgs/ufs-community/projects/70 + project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + github-token: ${{ secrets.PR_PROJECT_TOKEN }} + field-name: 'Priority' + field-value: 'Unknown' From a940bb1c6108cd182a6a3dc7e4e88082606c2919 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 19:02:56 -0400 Subject: [PATCH 04/33] change task names --- .github/workflows/update_project_labels.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index c0c16d20d7..3a6363c6da 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -10,7 +10,7 @@ on: jobs: baseline-labels: - name: Update project with baseline labels + name: Baseline labels runs-on: ubuntu-latest permissions: contents: read @@ -66,7 +66,7 @@ jobs: field-name: 'Baseline Changes' field-value: 'No' data-labels: - name: Update project with input data labels + name: Input data runs-on: ubuntu-latest permissions: contents: read @@ -93,7 +93,7 @@ jobs: field-value: 'No' #Figure out "Combine" toggle & logic priority-labels: - name: Update project with priority labels + name: Priority runs-on: ubuntu-latest permissions: contents: read From 4d619c47013dbf0489a6b1edb7059d9b5cee8be4 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 19:05:33 -0400 Subject: [PATCH 05/33] change task names --- .github/workflows/update_project_labels_target.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/update_project_labels_target.yaml b/.github/workflows/update_project_labels_target.yaml index adc9bb45c0..a77d990708 100644 --- a/.github/workflows/update_project_labels_target.yaml +++ b/.github/workflows/update_project_labels_target.yaml @@ -10,7 +10,7 @@ on: jobs: baseline-labels: - name: Update project with baseline labels + name: Baseline labels runs-on: ubuntu-latest permissions: contents: read @@ -66,7 +66,7 @@ jobs: field-name: 'Baseline Changes' field-value: 'No' data-labels: - name: Update project with input data labels + name: Input data runs-on: ubuntu-latest permissions: contents: read @@ -93,7 +93,7 @@ jobs: field-value: 'No' #Figure out "Combine" toggle & logic priority-labels: - name: Update project with priority labels + name: Priority runs-on: ubuntu-latest permissions: contents: read From 63640dd7b26a868a4bc38bca9d70c6fe095123ce Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 19:10:44 -0400 Subject: [PATCH 06/33] rename tasks; rm pull_request (no target) --- .github/workflows/update_project_labels.yaml | 158 ------------------- 1 file changed, 158 deletions(-) delete mode 100644 .github/workflows/update_project_labels.yaml diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml deleted file mode 100644 index 82da88b0e9..0000000000 --- a/.github/workflows/update_project_labels.yaml +++ /dev/null @@ -1,158 +0,0 @@ -name: Update Project Labels -on: - pull_request_target: - types: - - opened - - reopened - - labeled - - unlabeled - -jobs: - baseline-labels: - name: Baseline labels - runs-on: ubuntu-latest - permissions: - contents: read - pull-requests: write - issues: write - steps: - - name: Lack of baseline labels - if: | - !contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && - !contains(github.event.pull_request.labels.*.name, 'Baseline Updates') && - !contains(github.event.pull_request.labels.*.name, 'New Baselines') - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Baseline Changes' - field-value: 'Unknown' - - name: Contradictory labels - if: | - contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && - (contains(github.event.pull_request.labels.*.name, 'Baseline Updates') || - contains(github.event.pull_request.labels.*.name, 'New Baselines')) - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Baseline Changes' - field-value: 'Unknown' - - name: Baseline changes labels - if: | - (contains(github.event.pull_request.labels.*.name, 'Baseline Updates') || - contains(github.event.pull_request.labels.*.name, 'New Baselines')) && - !contains(github.event.pull_request.labels.*.name, 'No Baseline Change') - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Baseline Changes' - field-value: 'Yes' - - name: No baseline changes label - if: | - contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && - !contains(github.event.pull_request.labels.*.name, 'Baseline Updates') && - !contains(github.event.pull_request.labels.*.name, 'New Baselines') - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Baseline Changes' - field-value: 'No' - data-labels: - name: Input data - runs-on: ubuntu-latest - permissions: - contents: read - pull-requests: write - issues: write - steps: - - name: Input data required - if: contains(github.event.pull_request.labels.*.name, 'Input Data Changes') - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: "Input Data Req'd" - field-value: 'Yes' - - name: No input data changes - if: (!contains(github.event.pull_request.labels.*.name, 'Input Data Changes')) - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: "Input Data Req'd" - field-value: 'No' - #Figure out "Combine" toggle & logic - priority-labels: - name: Priority - runs-on: ubuntu-latest - permissions: - contents: read - pull-requests: write - issues: write - steps: - - name: Normal Priority - if: | - !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && - !contains(github.event.pull_request.labels.*.name, 'Priority: High') - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Priority' - field-value: 'Normal' - - name: Critical priority - if: "contains(github.event.pull_request.labels.*.name, 'Priority: Critical')" - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Priority' - field-value: 'Yes' - - name: High Priority - if: "(contains(github.event.pull_request.labels.*.name, 'Priority: High'))" - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Priority' - field-value: 'High' - - name: Unknown Priority - if: | - contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && - contains(github.event.pull_request.labels.*.name, 'Priority: High') - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Priority' - field-value: 'Unknown' - subcomponent-labels: - name: Update project with input data labels - runs-on: ubuntu-latest - permissions: - contents: read - pull-requests: write - issues: write - steps: - - name: TBD - #if: (contains(github.event.pull_request.labels.*.name, 'Priority: High')) - #uses: nipe0324/update-project-v2-item-field@v2.0.2 - #with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - #project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - #github-token: ${{ secrets.PR_PROJECT_TOKEN }} - #field-name: 'Baseline Changes' - #field-value: 'Yes' From e03930cad7a0c37f1abf59359197c7eea9ed8e79 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 19:30:41 -0400 Subject: [PATCH 07/33] clarify PR template language around test_changes.list --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f3fa263689..4b9ea4089c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -15,7 +15,7 @@ - [ ] All subcomponent pull requests (if any) have been reviewed by their code managers. - [ ] Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). **Exceptions:** documentation-only PRs, CI-only PRs, etc. - [ ] Commit log file w/full results from RT suite run (if applicable). - - [ ] Commit 'test_changes.list' (unless file is empty). + - [ ] Verify that 'test_changes.list' indicates which tests, if any, are changed by this PR. If needed, commit the updated 'test_changes.list' file. - [ ] Fill out all sections of this template. --- From 6eb07b7c9741b7f94c1c2e9b90562fea773d3696 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 19:53:40 -0400 Subject: [PATCH 08/33] chg data in to pull_request from pr target --- .github/workflows/update_project_labels_target.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/update_project_labels_target.yaml b/.github/workflows/update_project_labels_target.yaml index a77d990708..ac733d5515 100644 --- a/.github/workflows/update_project_labels_target.yaml +++ b/.github/workflows/update_project_labels_target.yaml @@ -74,7 +74,7 @@ jobs: issues: write steps: - name: Input data required - if: contains(github.event.pull_request_target.labels.*.name, 'Input Data Changes') + if: contains(github.event.pull_request.labels.*.name, 'Input Data Changes') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -83,7 +83,7 @@ jobs: field-name: "Input Data Req'd" field-value: 'Yes' - name: No input data changes - if: (!contains(github.event.pull_request_target.labels.*.name, 'Input Data Changes')) + if: (!contains(github.event.pull_request.labels.*.name, 'Input Data Changes')) uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 From a2bb75a9478fcf45b3fe02fbf67b8a8e34a3674b Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 19:59:55 -0400 Subject: [PATCH 09/33] chg to pull_request from pr target --- .../update_project_labels_target.yaml | 36 +++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/workflows/update_project_labels_target.yaml b/.github/workflows/update_project_labels_target.yaml index ac733d5515..3a6363c6da 100644 --- a/.github/workflows/update_project_labels_target.yaml +++ b/.github/workflows/update_project_labels_target.yaml @@ -19,9 +19,9 @@ jobs: steps: - name: Lack of baseline labels if: | - !contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') && - !contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') && - !contains(github.event.pull_request_target.labels.*.name, 'New Baselines') + !contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && + !contains(github.event.pull_request.labels.*.name, 'Baseline Updates') && + !contains(github.event.pull_request.labels.*.name, 'New Baselines') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -31,9 +31,9 @@ jobs: field-value: 'Unknown' - name: Contradictory labels if: | - contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') && - (contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') || - contains(github.event.pull_request_target.labels.*.name, 'New Baselines')) + contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && + (contains(github.event.pull_request.labels.*.name, 'Baseline Updates') || + contains(github.event.pull_request.labels.*.name, 'New Baselines')) uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -43,9 +43,9 @@ jobs: field-value: 'Unknown' - name: Baseline changes labels if: | - (contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') || - contains(github.event.pull_request_target.labels.*.name, 'New Baselines')) && - !contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') + (contains(github.event.pull_request.labels.*.name, 'Baseline Updates') || + contains(github.event.pull_request.labels.*.name, 'New Baselines')) && + !contains(github.event.pull_request.labels.*.name, 'No Baseline Change') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -55,9 +55,9 @@ jobs: field-value: 'Yes' - name: No baseline changes label if: | - contains(github.event.pull_request_target.labels.*.name, 'No Baseline Change') && - !contains(github.event.pull_request_target.labels.*.name, 'Baseline Updates') && - !contains(github.event.pull_request_target.labels.*.name, 'New Baselines') + contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && + !contains(github.event.pull_request.labels.*.name, 'Baseline Updates') && + !contains(github.event.pull_request.labels.*.name, 'New Baselines') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -102,8 +102,8 @@ jobs: steps: - name: Normal Priority if: | - !contains(github.event.pull_request_target.labels.*.name, 'Priority: Critical') && - !contains(github.event.pull_request_target.labels.*.name, 'Priority: High') + !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && + !contains(github.event.pull_request.labels.*.name, 'Priority: High') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -112,7 +112,7 @@ jobs: field-name: 'Priority' field-value: 'Normal' - name: Critical priority - if: "contains(github.event.pull_request_target.labels.*.name, 'Priority: Critical')" + if: "contains(github.event.pull_request.labels.*.name, 'Priority: Critical')" uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -121,7 +121,7 @@ jobs: field-name: 'Priority' field-value: 'Yes' - name: High Priority - if: "(contains(github.event.pull_request_target.labels.*.name, 'Priority: High'))" + if: "(contains(github.event.pull_request.labels.*.name, 'Priority: High'))" uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -131,8 +131,8 @@ jobs: field-value: 'High' - name: Unknown Priority if: | - contains(github.event.pull_request_target.labels.*.name, 'Priority: Critical') && - contains(github.event.pull_request_target.labels.*.name, 'Priority: High') + contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && + contains(github.event.pull_request.labels.*.name, 'Priority: High') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 From b5421fee113595777be73ad97dadd401cad2e2af Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 20:10:50 -0400 Subject: [PATCH 10/33] fix critical priority --- .github/workflows/update_project_labels_target.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update_project_labels_target.yaml b/.github/workflows/update_project_labels_target.yaml index 3a6363c6da..4c2141bb25 100644 --- a/.github/workflows/update_project_labels_target.yaml +++ b/.github/workflows/update_project_labels_target.yaml @@ -119,7 +119,7 @@ jobs: project-url: https://github.com/orgs/NOAA-EPIC/projects/18 github-token: ${{ secrets.PR_PROJECT_TOKEN }} field-name: 'Priority' - field-value: 'Yes' + field-value: 'Critical' - name: High Priority if: "(contains(github.event.pull_request.labels.*.name, 'Priority: High'))" uses: nipe0324/update-project-v2-item-field@v2.0.2 From 658f60a001a4f1539d58355cc086036922e6a8ad Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 20:34:40 -0400 Subject: [PATCH 11/33] fix parentheses? --- .github/workflows/update_project_labels_target.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/update_project_labels_target.yaml b/.github/workflows/update_project_labels_target.yaml index 4c2141bb25..9f88434538 100644 --- a/.github/workflows/update_project_labels_target.yaml +++ b/.github/workflows/update_project_labels_target.yaml @@ -19,9 +19,9 @@ jobs: steps: - name: Lack of baseline labels if: | - !contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && - !contains(github.event.pull_request.labels.*.name, 'Baseline Updates') && - !contains(github.event.pull_request.labels.*.name, 'New Baselines') + (!contains(github.event.pull_request.labels.*.name, 'No Baseline Change')) && + (!contains(github.event.pull_request.labels.*.name, 'Baseline Updates')) && + (!contains(github.event.pull_request.labels.*.name, 'New Baselines')) uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 @@ -43,9 +43,9 @@ jobs: field-value: 'Unknown' - name: Baseline changes labels if: | - (contains(github.event.pull_request.labels.*.name, 'Baseline Updates') || - contains(github.event.pull_request.labels.*.name, 'New Baselines')) && - !contains(github.event.pull_request.labels.*.name, 'No Baseline Change') + !contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && + ( contains(github.event.pull_request.labels.*.name, 'Baseline Updates') || + contains(github.event.pull_request.labels.*.name, 'New Baselines') ) uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 From 2865a965c07845545a85eb1b2ff51bf3bfbeaf32 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 20:37:18 -0400 Subject: [PATCH 12/33] add quotes for BL labels --- .github/workflows/update_project_labels_target.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/update_project_labels_target.yaml b/.github/workflows/update_project_labels_target.yaml index 9f88434538..a944b010f3 100644 --- a/.github/workflows/update_project_labels_target.yaml +++ b/.github/workflows/update_project_labels_target.yaml @@ -19,9 +19,9 @@ jobs: steps: - name: Lack of baseline labels if: | - (!contains(github.event.pull_request.labels.*.name, 'No Baseline Change')) && - (!contains(github.event.pull_request.labels.*.name, 'Baseline Updates')) && - (!contains(github.event.pull_request.labels.*.name, 'New Baselines')) + "!contains(github.event.pull_request.labels.*.name, 'No Baseline Change')" && + "!contains(github.event.pull_request.labels.*.name, 'Baseline Updates')" && + "!contains(github.event.pull_request.labels.*.name, 'New Baselines')" uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 From 0d0caa472d7f47142688a651bef5fc71e4313865 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 20:42:49 -0400 Subject: [PATCH 13/33] fix spaces --- .github/workflows/update_project_labels_target.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/update_project_labels_target.yaml b/.github/workflows/update_project_labels_target.yaml index a944b010f3..f673a0aed6 100644 --- a/.github/workflows/update_project_labels_target.yaml +++ b/.github/workflows/update_project_labels_target.yaml @@ -20,7 +20,7 @@ jobs: - name: Lack of baseline labels if: | "!contains(github.event.pull_request.labels.*.name, 'No Baseline Change')" && - "!contains(github.event.pull_request.labels.*.name, 'Baseline Updates')" && + "!contains(github.event.pull_request.labels.*.name, 'Baseline Updates')" && "!contains(github.event.pull_request.labels.*.name, 'New Baselines')" uses: nipe0324/update-project-v2-item-field@v2.0.2 with: @@ -32,7 +32,7 @@ jobs: - name: Contradictory labels if: | contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && - (contains(github.event.pull_request.labels.*.name, 'Baseline Updates') || + (contains(github.event.pull_request.labels.*.name, 'Baseline Updates') || contains(github.event.pull_request.labels.*.name, 'New Baselines')) uses: nipe0324/update-project-v2-item-field@v2.0.2 with: From 44af740b15eb17be5dd5374a98515d16c7f17500 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 20:54:32 -0400 Subject: [PATCH 14/33] rm extraneous quotes --- .github/workflows/update_project_labels_target.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/update_project_labels_target.yaml b/.github/workflows/update_project_labels_target.yaml index f673a0aed6..0cb061d709 100644 --- a/.github/workflows/update_project_labels_target.yaml +++ b/.github/workflows/update_project_labels_target.yaml @@ -19,9 +19,9 @@ jobs: steps: - name: Lack of baseline labels if: | - "!contains(github.event.pull_request.labels.*.name, 'No Baseline Change')" && - "!contains(github.event.pull_request.labels.*.name, 'Baseline Updates')" && - "!contains(github.event.pull_request.labels.*.name, 'New Baselines')" + !contains(github.event.pull_request.labels.*.name, 'No Baseline Change') && + !contains(github.event.pull_request.labels.*.name, 'Baseline Updates') && + !contains(github.event.pull_request.labels.*.name, 'New Baselines') uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 From 8fc40b7e3d169a5bb616637740f84a2cff2a938c Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 21:29:51 -0400 Subject: [PATCH 15/33] fix whitespace --- .github/workflows/update_project_labels_target.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/update_project_labels_target.yaml b/.github/workflows/update_project_labels_target.yaml index 0cb061d709..c604ced643 100644 --- a/.github/workflows/update_project_labels_target.yaml +++ b/.github/workflows/update_project_labels_target.yaml @@ -7,7 +7,6 @@ on: - labeled - unlabeled - jobs: baseline-labels: name: Baseline labels From d0267a6f34fffb4772aad98709214ba93527e9b9 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 21:32:30 -0400 Subject: [PATCH 16/33] remove labeled for add PR to project --- .github/workflows/add_pr_to_project.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/add_pr_to_project.yaml b/.github/workflows/add_pr_to_project.yaml index 012559a84d..68455f0061 100644 --- a/.github/workflows/add_pr_to_project.yaml +++ b/.github/workflows/add_pr_to_project.yaml @@ -4,7 +4,6 @@ on: types: - opened - reopened - - labeled jobs: add-to-project: From 414fe28855ccf843a9af230d10e5b711978dd30a Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 21:33:42 -0400 Subject: [PATCH 17/33] rename file --- ...date_project_labels_target.yaml => update_project_labels.yaml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{update_project_labels_target.yaml => update_project_labels.yaml} (100%) diff --git a/.github/workflows/update_project_labels_target.yaml b/.github/workflows/update_project_labels.yaml similarity index 100% rename from .github/workflows/update_project_labels_target.yaml rename to .github/workflows/update_project_labels.yaml From 02f245dbb173a0b0e615b223bc734ae0e87c84ae Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 21:56:31 -0400 Subject: [PATCH 18/33] address combinability for priority --- .github/workflows/update_project_labels.yaml | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index c604ced643..337a78c59d 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -98,11 +98,25 @@ jobs: contents: read pull-requests: write issues: write + env: + - PRIORITY: '' steps: + - name: Combinable? + uses: EndBug/project-fields@v2 + id: fields + with: + operation: get + fields: Priority + github_token: ${{ secrets.PR_PROJECT_TOKEN }} + project_url: https://github.com/ufs-community/ufs-weather-model/pull/${{ github.event.pull_request.number }} + run: | + echo ${{ github.event.pull_request.number }} + PRIORITY=${{ steps.fields.outputs.values }} - name: Normal Priority if: | !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && - !contains(github.event.pull_request.labels.*.name, 'Priority: High') + !contains(github.event.pull_request.labels.*.name, 'Priority: High') && + $PRIORITY!='Combine' uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 From 72d05e07c777349cd249eeec474d480fe34a3dbd Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:11:07 -0400 Subject: [PATCH 19/33] get priority field --- .github/workflows/update_project_labels.yaml | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 337a78c59d..a40d47eaea 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -90,7 +90,6 @@ jobs: github-token: ${{ secrets.PR_PROJECT_TOKEN }} field-name: "Input Data Req'd" field-value: 'No' - #Figure out "Combine" toggle & logic priority-labels: name: Priority runs-on: ubuntu-latest @@ -101,17 +100,16 @@ jobs: env: - PRIORITY: '' steps: - - name: Combinable? + - name: Read Priority field uses: EndBug/project-fields@v2 - id: fields + id: priority_field with: operation: get fields: Priority github_token: ${{ secrets.PR_PROJECT_TOKEN }} - project_url: https://github.com/ufs-community/ufs-weather-model/pull/${{ github.event.pull_request.number }} - run: | - echo ${{ github.event.pull_request.number }} - PRIORITY=${{ steps.fields.outputs.values }} + project_url: ${{ github.event.pull_request.html_url }} + - name: Assign value to Priority field + run: PRIORITY=${{ steps.priority_field.outputs.values }} - name: Normal Priority if: | !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && From 14e6521a31a76da0ff31597795e91c08f20d7af8 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:14:29 -0400 Subject: [PATCH 20/33] rm extra - --- .github/workflows/update_project_labels.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index a40d47eaea..80c58f12cb 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -98,7 +98,7 @@ jobs: pull-requests: write issues: write env: - - PRIORITY: '' + PRIORITY: '' steps: - name: Read Priority field uses: EndBug/project-fields@v2 From 487c9645b7998ca09b9d3354883baf3e8099bd61 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:18:56 -0400 Subject: [PATCH 21/33] properly assign --- .github/workflows/update_project_labels.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 80c58f12cb..8287599876 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -109,7 +109,7 @@ jobs: github_token: ${{ secrets.PR_PROJECT_TOKEN }} project_url: ${{ github.event.pull_request.html_url }} - name: Assign value to Priority field - run: PRIORITY=${{ steps.priority_field.outputs.values }} + run: echo "PRIORITY=${{ steps.priority_field.outputs.values }}" >> $GITHUB_ENV - name: Normal Priority if: | !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && From ed2f68087874333efbd17b882bf42e443c34ab27 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:21:36 -0400 Subject: [PATCH 22/33] properly assign --- .github/workflows/update_project_labels.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 8287599876..0d2fabe1e9 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -109,7 +109,9 @@ jobs: github_token: ${{ secrets.PR_PROJECT_TOKEN }} project_url: ${{ github.event.pull_request.html_url }} - name: Assign value to Priority field - run: echo "PRIORITY=${{ steps.priority_field.outputs.values }}" >> $GITHUB_ENV + run: | + PRIORITY="${{ steps.priority_field.outputs.values }}" + echo "PRIORITY=$PRIORITY" >> $GITHUB_ENV - name: Normal Priority if: | !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && From 493b3ab9920227bafa8191326f487955ff1ce8c0 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:25:00 -0400 Subject: [PATCH 23/33] properly assign --- .github/workflows/update_project_labels.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 0d2fabe1e9..30cd38864d 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -110,8 +110,9 @@ jobs: project_url: ${{ github.event.pull_request.html_url }} - name: Assign value to Priority field run: | - PRIORITY="${{ steps.priority_field.outputs.values }}" - echo "PRIORITY=$PRIORITY" >> $GITHUB_ENV + priority="${{ steps.priority_field.outputs.values }}" + echo $PRIORITY + echo "PRIORITY=$priority" >> $GITHUB_ENV - name: Normal Priority if: | !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && From ac3287bb5b6e25cf2f83b67608a3c9c67ac95e83 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:29:45 -0400 Subject: [PATCH 24/33] access --- .github/workflows/update_project_labels.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 30cd38864d..80a961893d 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -112,12 +112,13 @@ jobs: run: | priority="${{ steps.priority_field.outputs.values }}" echo $PRIORITY + echo $priority echo "PRIORITY=$priority" >> $GITHUB_ENV - name: Normal Priority if: | !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && !contains(github.event.pull_request.labels.*.name, 'Priority: High') && - $PRIORITY!='Combine' + ${{ env.PRIORITY }}!='Combine' uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 From 6ca0294dfa2b83ee7d4c73a719de0c7a1d81db89 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:33:50 -0400 Subject: [PATCH 25/33] fix project/resource url --- .github/workflows/update_project_labels.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 80a961893d..24cf38f393 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -101,13 +101,15 @@ jobs: PRIORITY: '' steps: - name: Read Priority field - uses: EndBug/project-fields@v2 + uses: EndBug/project-fields@v2.1.0 id: priority_field with: operation: get fields: Priority github_token: ${{ secrets.PR_PROJECT_TOKEN }} - project_url: ${{ github.event.pull_request.html_url }} + #project-url: https://github.com/orgs/ufs-community/projects/70 + project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + resource_url: ${{ github.event.pull_request.html_url }} - name: Assign value to Priority field run: | priority="${{ steps.priority_field.outputs.values }}" From 539dfb9c386413737dcafe6912d342985aba6076 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:35:35 -0400 Subject: [PATCH 26/33] fix typo --- .github/workflows/update_project_labels.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 24cf38f393..01fde63bbc 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -107,8 +107,8 @@ jobs: operation: get fields: Priority github_token: ${{ secrets.PR_PROJECT_TOKEN }} - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 + #project_url: https://github.com/orgs/ufs-community/projects/70 + project_url: https://github.com/orgs/NOAA-EPIC/projects/18 resource_url: ${{ github.event.pull_request.html_url }} - name: Assign value to Priority field run: | From f7918e6bac3bdfe612118cac5c16c934c5cc69d3 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:42:14 -0400 Subject: [PATCH 27/33] echo priority --- .github/workflows/update_project_labels.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 01fde63bbc..65f88375b1 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -113,9 +113,8 @@ jobs: - name: Assign value to Priority field run: | priority="${{ steps.priority_field.outputs.values }}" - echo $PRIORITY - echo $priority echo "PRIORITY=$priority" >> $GITHUB_ENV + echo ${{ env.PRIORITY }} - name: Normal Priority if: | !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && From 135c7a1bc66f730b28cda76d26075424e34477a8 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:45:46 -0400 Subject: [PATCH 28/33] access --- .github/workflows/update_project_labels.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 65f88375b1..5648b607cf 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -114,12 +114,11 @@ jobs: run: | priority="${{ steps.priority_field.outputs.values }}" echo "PRIORITY=$priority" >> $GITHUB_ENV - echo ${{ env.PRIORITY }} - name: Normal Priority if: | !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && !contains(github.event.pull_request.labels.*.name, 'Priority: High') && - ${{ env.PRIORITY }}!='Combine' + $PRIORITY!='Combine' uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 From 5fdd223d0255a27323b8d857c333780aab6edad1 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:50:23 -0400 Subject: [PATCH 29/33] test syntax --- .github/workflows/update_project_labels.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 5648b607cf..0e634dbc4c 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -114,6 +114,8 @@ jobs: run: | priority="${{ steps.priority_field.outputs.values }}" echo "PRIORITY=$priority" >> $GITHUB_ENV + echo $($PRIORITY!='Combine') + echo ${{ env.PRIORITY != 'Combine' }} - name: Normal Priority if: | !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && From 7ebad44de2885211ce29a94b9998919068c0e9d2 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 22:55:53 -0400 Subject: [PATCH 30/33] test combinability --- .github/workflows/update_project_labels.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 0e634dbc4c..faab25662c 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -114,13 +114,11 @@ jobs: run: | priority="${{ steps.priority_field.outputs.values }}" echo "PRIORITY=$priority" >> $GITHUB_ENV - echo $($PRIORITY!='Combine') - echo ${{ env.PRIORITY != 'Combine' }} - name: Normal Priority if: | !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && !contains(github.event.pull_request.labels.*.name, 'Priority: High') && - $PRIORITY!='Combine' + ${{ env.PRIORITY != 'Combine' }} uses: nipe0324/update-project-v2-item-field@v2.0.2 with: #project-url: https://github.com/orgs/ufs-community/projects/70 From d6003df2972e178456c9f3cdf84235647a61a5e0 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Sun, 28 Sep 2025 23:10:57 -0400 Subject: [PATCH 31/33] add test echo --- .github/workflows/update_project_labels.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index faab25662c..122fa625e1 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -114,6 +114,8 @@ jobs: run: | priority="${{ steps.priority_field.outputs.values }}" echo "PRIORITY=$priority" >> $GITHUB_ENV + echo $PRIORITY + echo $( [ $PRIORITY != 'Combine' ] ) - name: Normal Priority if: | !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && From c0130cffebe6dd005969dc53f1b0de60b1dc55c1 Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Mon, 29 Sep 2025 08:07:36 -0400 Subject: [PATCH 32/33] rm normal priority logic --- .github/workflows/update_project_labels.yaml | 30 -------------------- 1 file changed, 30 deletions(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index 122fa625e1..fc679ae951 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -97,37 +97,7 @@ jobs: contents: read pull-requests: write issues: write - env: - PRIORITY: '' steps: - - name: Read Priority field - uses: EndBug/project-fields@v2.1.0 - id: priority_field - with: - operation: get - fields: Priority - github_token: ${{ secrets.PR_PROJECT_TOKEN }} - #project_url: https://github.com/orgs/ufs-community/projects/70 - project_url: https://github.com/orgs/NOAA-EPIC/projects/18 - resource_url: ${{ github.event.pull_request.html_url }} - - name: Assign value to Priority field - run: | - priority="${{ steps.priority_field.outputs.values }}" - echo "PRIORITY=$priority" >> $GITHUB_ENV - echo $PRIORITY - echo $( [ $PRIORITY != 'Combine' ] ) - - name: Normal Priority - if: | - !contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && - !contains(github.event.pull_request.labels.*.name, 'Priority: High') && - ${{ env.PRIORITY != 'Combine' }} - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Priority' - field-value: 'Normal' - name: Critical priority if: "contains(github.event.pull_request.labels.*.name, 'Priority: Critical')" uses: nipe0324/update-project-v2-item-field@v2.0.2 From 761e86f4026ce181468d5498d19c2fcbb519059a Mon Sep 17 00:00:00 2001 From: Gillian Petro Date: Mon, 29 Sep 2025 08:57:53 -0400 Subject: [PATCH 33/33] remove priority label logic --- .github/workflows/update_project_labels.yaml | 37 -------------------- 1 file changed, 37 deletions(-) diff --git a/.github/workflows/update_project_labels.yaml b/.github/workflows/update_project_labels.yaml index fc679ae951..cfbaae4353 100644 --- a/.github/workflows/update_project_labels.yaml +++ b/.github/workflows/update_project_labels.yaml @@ -90,40 +90,3 @@ jobs: github-token: ${{ secrets.PR_PROJECT_TOKEN }} field-name: "Input Data Req'd" field-value: 'No' - priority-labels: - name: Priority - runs-on: ubuntu-latest - permissions: - contents: read - pull-requests: write - issues: write - steps: - - name: Critical priority - if: "contains(github.event.pull_request.labels.*.name, 'Priority: Critical')" - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Priority' - field-value: 'Critical' - - name: High Priority - if: "(contains(github.event.pull_request.labels.*.name, 'Priority: High'))" - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Priority' - field-value: 'High' - - name: Unknown Priority - if: | - contains(github.event.pull_request.labels.*.name, 'Priority: Critical') && - contains(github.event.pull_request.labels.*.name, 'Priority: High') - uses: nipe0324/update-project-v2-item-field@v2.0.2 - with: - #project-url: https://github.com/orgs/ufs-community/projects/70 - project-url: https://github.com/orgs/NOAA-EPIC/projects/18 - github-token: ${{ secrets.PR_PROJECT_TOKEN }} - field-name: 'Priority' - field-value: 'Unknown'