Consider surface ocean current in air-sea flux calculation by binli2337 · Pull Request #755 · NOAA-EMC/ufsatm

binli2337 · 2024-01-14T17:43:30Z

Description

This PR will update ccpp-physics and GFDL_atmos_cubed_sphere components to include surface ocean current in the computation of air-sea fluxes.

This PR will also add a new namelist called "icplocn2atm."
When icplocn2atm=0, surface ocean current is not used in the computation of air-sea fluxes.
When icpocn2atm=1, surface ocean current is used in the computation of air-sea fluxes.

Issue(s) addressed

fixes Consider surface ocean current in the computation of air-sea fluxes #753
fixes Enable taking into account sea surface current in atmosphere-ocean coupling ufs-community/ufs-weather-model#1975

Testing

How were these changes tested? The changes were tested in the HAFS-MOM6 system.
What compilers / HPCs was it tested with? Intel
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
New tests will not be added to UFS regression test system.
Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera.

Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below. No
Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

Co-authored-by: @binli2337, @BinLiu-NOAA, @WeiguoWang-NOAA, @BijuThomas-NOAA, @hyunsookkim-NOAA, @XuLi-NOAA, @MariaAristizabal-NOAA, @JohnSteffen-NOAA

…and allow one to override data integrity checks in FMS restart logic

…hafsv0.3_final Conflicts: atmos_cubed_sphere

…nLiu-NOAA

…nLiu-NOAA): suite_FV3_HAFS_v0_thompson.xml suite_FV3_HAFS_v0_thompson_nonsst.xml suite_FV3_HAFS_v0_thompson_noahmp.xml suite_FV3_HAFS_v0_thompson_noahmp_nonsst.xml

…_final

…afsv0.3_final

…022.

…hafsv0.3_final

…sing the prime meridian.

…ling time steps). This is to reduce the overhead introduced by downscaling the coupling variables from FV3ATM parent to nest.

…branch of the hafs-community fork.

…unity/fv3atm into feature/hafsv0.3_final

…FS sa-TKE EDMF PBL scheme for HAFS/hurricane modeling.

…os_cubed_sphere.

…hafs_sync_202210

in internal tracker output (fort.602, phtcf file).

…hafs_sync_202210

…re and ccpp-physics.

…#622) * fix initialization for moving nest grid

…ranch.

…hafsv2_baseline_with_ssc

and suite_FV3_HAFS_v1_thompson_nonsst.xml under ccpp/suites since they are used by operational HAFS configurations.

DeniseWorthen

The changes look OK to me, but someone w/ more familiarity w/ the moving nest code should also review.

BinLiu-NOAA

Looks good. Tested under HAFS application already.

grantfirl · 2024-02-01T18:38:59Z

ufs-community/ccpp-physics#155 was merged. This PR branch is ready to revert .gitmodules and commit the latest ufs/dev hash of ccpp-physics: ufs-community/ccpp-physics@51452b8

BinLiu-NOAA · 2024-02-01T20:11:17Z

ufs-community/ccpp-physics#155 was merged. This PR branch is ready to revert .gitmodules and commit the latest ufs/dev hash of ccpp-physics: ufs-community/ccpp-physics@51452b8

Thanks, @grantfirl!

Waiting for NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/311 being merged.

zach1221 · 2024-02-01T20:16:53Z

atmos_cubed_sphere hash: NOAA-GFDL/GFDL_atmos_cubed_sphere@6663459

zach1221 · 2024-02-01T20:27:43Z

@jkbk2004 We have approvals here, can you please merge this PR?

BinLiu-NOAA and others added 30 commits April 14, 2022 21:22

Update submodule atmos_cubed_sphere.

f126b8f

Performance optimization of moving nest.

ab314b4

Moving nest performance optimization stage 2.

bf80a91

update gitmodules and hash for atmos_cubed_sphere

b4e6b97

update atmos_model and FV3GFS_io read performance when io_layout=1,1 …

01c494a

…and allow one to override data integrity checks in FMS restart logic

Merge branch 'NOAA-EMC:develop' into emc_io_fixes

bcbe661

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

72265ba

…hafsv0.3_final Conflicts: atmos_cubed_sphere

Add the following HAFS ccpp physics suites (@ChunxiZhang-NOAA and @Bi…

18fffe3

…nLiu-NOAA): suite_FV3_HAFS_v0_thompson.xml suite_FV3_HAFS_v0_thompson_nonsst.xml suite_FV3_HAFS_v0_thompson_noahmp.xml suite_FV3_HAFS_v0_thompson_noahmp_nonsst.xml

Merge remote-tracking branch 'upstream/develop' into feature/hafsv0.3…

d0b8ca8

…_final

Merge remote-tracking branch 'remotes/RB/emc_io_fixes' into feature/h…

1dc7c3f

…afsv0.3_final

Update submodule UPP to point its latest develop branch as of 05/18/2…

725fe8e

…022.

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

637d972

…hafsv0.3_final

Update submodule upp, which has the fix for regional latlon grid cros…

63b3f23

…sing the prime meridian.

Only call atmosphere_fill_nest_cpl at the cap driver time steps (coup…

324924f

…ling time steps). This is to reduce the overhead introduced by downscaling the coupling variables from FV3ATM parent to nest.

Removed reference to unused variable parent_x.

7f7e9f5

Update to point submodule ccpp/physics to the feature/hafsv0.3_final …

003b0f9

…branch of the hafs-community fork.

FV3-related typedefs changes for the Hurricane PBL options

9d6d138

Merge branch 'feature/hafsv0.3_final' of https://github.com/hafs-comm…

186342f

…unity/fv3atm into feature/hafsv0.3_final

Update submodule ccpp/physics, which added the tc_pbl option in the G…

4c42e4a

…FS sa-TKE EDMF PBL scheme for HAFS/hurricane modeling.

Update to point the support/HAFS branch for upp, ccpp-physics and atm…

f7cd326

…os_cubed_sphere.

Update submodules of atmos_cubed_sphere, ccpp/physics, upp.

1121f57

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

edc9ddd

…hafs_sync_202210

Adding upoff as a namelist parameter

3c270f8

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

c29f113

…hafs_sync_202210

Update submodule atmos_cubed_sphere, which has updated the time string

7ec516c

in internal tracker output (fort.602, phtcf file).

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

a51f970

…hafs_sync_202210

Update .gitmodules to point back to support/HAFS branches for FV3dyco…

1384c41

…re and ccpp-physics.

Merge remote-tracking branch 'upstream/develop' into support/HAFS

6f69340

fix initialization issue for moving nest grid in debug mode (NOAA-EMC…

1b036b2

…#622) * fix initialization for moving nest grid

Update submodule atmos_cubed_sphere to point the production/hafs.v1 b…

3f5fcba

…ranch.

Merge branch 'develop' into feature/hafsv2_baseline_with_ssc

6fd94d6

binli2337 mentioned this pull request Jan 19, 2024

Consider sea surface currents in air-sea flux calculation for ufs atmosphere-ocean coupling ufs-community/ufs-weather-model#2104

Merged

41 tasks

BinLiu-NOAA mentioned this pull request Jan 19, 2024

Enable taking into account sea surface current in atmosphere-ocean coupling ufs-community/ufs-weather-model#1975

Closed

binli2337 and others added 6 commits January 26, 2024 09:57

Update atmos_cubed_sphere and ccpp/physics

a508a35

Merge branch 'develop' into feature/hafsv2_baseline_with_ssc

7e9eefa

Merge remote-tracking branch 'remotes/upstream/develop' into feature/…

9663c74

…hafsv2_baseline_with_ssc

Update HAFS thompson ccpp suites and move suite_FV3_HAFS_v1_thompson.xml

65529a8

and suite_FV3_HAFS_v1_thompson_nonsst.xml under ccpp/suites since they are used by operational HAFS configurations.

Update usfco and vsfco standard and long names in GFS_typedefs.meta.

bbfb56c

Update standard name for icplocn2atm in ccpp/data/GFS_typedefs.meta.

f092c93

DeniseWorthen reviewed Jan 29, 2024

View reviewed changes

Comment thread atmos_model.F90

binli2337 added 4 commits January 30, 2024 13:17

Update ccpp/physics.

4715ed1

Merge branch 'develop' into feature/hafsv2_baseline_with_ssc

fcb0bdb

Update ccpp/physics.

263ade5

Merge branch 'develop' into feature/hafsv2_baseline_with_ssc

b7587df

zach1221 requested review from BrianCurtis-NOAA and DeniseWorthen January 31, 2024 14:31

DeniseWorthen requested a review from junwang-noaa January 31, 2024 14:40

DeniseWorthen approved these changes Jan 31, 2024

View reviewed changes

junwang-noaa reviewed Jan 31, 2024

View reviewed changes

Comment thread ccpp/suites_not_used/suite_FV3_HAFS_v1_thompson_noahmp_nonsst.xml

junwang-noaa reviewed Jan 31, 2024

View reviewed changes

Comment thread ccpp/suites_not_used/suite_FV3_HAFS_v1_thompson_noahmp.xml

BinLiu-NOAA approved these changes Jan 31, 2024

View reviewed changes

junwang-noaa approved these changes Jan 31, 2024

View reviewed changes

Update atmos_cubed_sphere,ccpp and .gitmodules.

1091d03

jkbk2004 requested a review from DusanJovic-NOAA February 1, 2024 20:30

jkbk2004 merged commit 8db821c into NOAA-EMC:develop Feb 1, 2024

grantfirl mentioned this pull request Mar 18, 2024

UFS-dev PR#155 NCAR/fv3atm#124

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consider surface ocean current in air-sea flux calculation#755

Consider surface ocean current in air-sea flux calculation#755
jkbk2004 merged 75 commits into
NOAA-EMC:developfrom
binli2337:feature/hafsv2_baseline_with_ssc

binli2337 commented Jan 14, 2024 •

edited

Loading

Uh oh!

Uh oh!

DeniseWorthen left a comment

Uh oh!

Uh oh!

Uh oh!

BinLiu-NOAA left a comment

Uh oh!

grantfirl commented Feb 1, 2024

Uh oh!

BinLiu-NOAA commented Feb 1, 2024

Uh oh!

zach1221 commented Feb 1, 2024

Uh oh!

zach1221 commented Feb 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

binli2337 commented Jan 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue(s) addressed

Testing

Dependencies

Uh oh!

Uh oh!

DeniseWorthen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BinLiu-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

grantfirl commented Feb 1, 2024

Uh oh!

BinLiu-NOAA commented Feb 1, 2024

Uh oh!

zach1221 commented Feb 1, 2024

Uh oh!

zach1221 commented Feb 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

binli2337 commented Jan 14, 2024 •

edited

Loading